[PATCH 0/2] Convert Qualcomm SATA PHY bindings to dtschema

[PATCH 0/2] Convert Qualcomm SATA PHY bindings to dtschema

[Rayyan Ansari]

Hi,
The following patches:
- Convert the old apq8064 and ipq806x text bindings, to a new unified
  qcom,sata-phy binding in yaml.
- Remove reg-names from the SATA PHY node in apq8064.dtsi to conform to
  the bindings

Thanks,
Rayyan

Rayyan Ansari (2):
  dt-bindings: phy: qcom,sata-phy: convert to dtschema
  ARM: dts: qcom: apq8064: drop reg-names on sata-phy node

 .../bindings/phy/qcom,sata-phy.yaml           | 55 +++++++++++++++++++
 .../bindings/phy/qcom-apq8064-sata-phy.txt    | 24 --------
 .../bindings/phy/qcom-ipq806x-sata-phy.txt    | 23 --------
 arch/arm/boot/dts/qcom/qcom-apq8064.dtsi      |  1 -
 4 files changed, 55 insertions(+), 48 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/phy/qcom,sata-phy.yaml
 delete mode 100644 Documentation/devicetree/bindings/phy/qcom-apq8064-sata-phy.txt
 delete mode 100644 Documentation/devicetree/bindings/phy/qcom-ipq806x-sata-phy.txt

-- 
2.45.2

[PATCH 1/2] dt-bindings: phy: qcom,sata-phy: convert to dtschema

[Rayyan Ansari]

Convert the bindings for the SATA PHY on both apq8064 and ipq806x from
the old text format to yaml.

Signed-off-by: Rayyan Ansari <rayyan.ansari@linaro.org>
---
 .../bindings/phy/qcom,sata-phy.yaml           | 55 +++++++++++++++++++
 .../bindings/phy/qcom-apq8064-sata-phy.txt    | 24 --------
 .../bindings/phy/qcom-ipq806x-sata-phy.txt    | 23 --------
 3 files changed, 55 insertions(+), 47 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/phy/qcom,sata-phy.yaml
 delete mode 100644 Documentation/devicetree/bindings/phy/qcom-apq8064-sata-phy.txt
 delete mode 100644 Documentation/devicetree/bindings/phy/qcom-ipq806x-sata-phy.txt

diff --git a/Documentation/devicetree/bindings/phy/qcom,sata-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sata-phy.yaml
new file mode 100644
index 000000000000..0bf18d32c133
--- /dev/null
+++ b/Documentation/devicetree/bindings/phy/qcom,sata-phy.yaml
@@ -0,0 +1,55 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/phy/qcom,sata-phy.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm SATA PHY Controller
+
+maintainers:
+  - Bjorn Andersson <andersson@kernel.org>
+  - Konrad Dybcio <konrad.dybcio@linaro.org>
+
+description:
+  The Qualcomm SATA PHY describes on-chip SATA Physical layer controllers.
+
+properties:
+  compatible:
+    enum:
+      - qcom,ipq806x-sata-phy
+      - qcom,apq8064-sata-phy
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  clock-names:
+    const: cfg
+
+  '#phy-cells':
+    const: 0
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - clock-names
+  - '#phy-cells'
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/qcom,gcc-ipq806x.h>
+    sata_phy: sata-phy@1b400000 {
+        compatible = "qcom,ipq806x-sata-phy";
+        reg = <0x1b400000 0x200>;
+
+        clocks = <&gcc SATA_PHY_CFG_CLK>;
+        clock-names = "cfg";
+
+        #phy-cells = <0>;
+    };
+
diff --git a/Documentation/devicetree/bindings/phy/qcom-apq8064-sata-phy.txt b/Documentation/devicetree/bindings/phy/qcom-apq8064-sata-phy.txt
deleted file mode 100644
index 952f6c96bab9..000000000000
--- a/Documentation/devicetree/bindings/phy/qcom-apq8064-sata-phy.txt
+++ /dev/null
@@ -1,24 +0,0 @@
-Qualcomm APQ8064 SATA PHY Controller
-------------------------------------
-
-SATA PHY nodes are defined to describe on-chip SATA Physical layer controllers.
-Each SATA PHY controller should have its own node.
-
-Required properties:
-- compatible: compatible list, contains "qcom,apq8064-sata-phy".
-- reg: offset and length of the SATA PHY register set;
-- #phy-cells: must be zero
-- clocks: a list of phandles and clock-specifier pairs, one for each entry in
-  clock-names.
-- clock-names: must be "cfg" for phy config clock.
-
-Example:
-	sata_phy: sata-phy@1b400000 {
-		compatible = "qcom,apq8064-sata-phy";
-		reg = <0x1b400000 0x200>;
-
-		clocks = <&gcc SATA_PHY_CFG_CLK>;
-		clock-names = "cfg";
-
-		#phy-cells = <0>;
-	};
diff --git a/Documentation/devicetree/bindings/phy/qcom-ipq806x-sata-phy.txt b/Documentation/devicetree/bindings/phy/qcom-ipq806x-sata-phy.txt
deleted file mode 100644
index 76bfbd056202..000000000000
--- a/Documentation/devicetree/bindings/phy/qcom-ipq806x-sata-phy.txt
+++ /dev/null
@@ -1,23 +0,0 @@
-Qualcomm IPQ806x SATA PHY Controller
-------------------------------------
-
-SATA PHY nodes are defined to describe on-chip SATA Physical layer controllers.
-Each SATA PHY controller should have its own node.
-
-Required properties:
-- compatible: compatible list, contains "qcom,ipq806x-sata-phy"
-- reg: offset and length of the SATA PHY register set;
-- #phy-cells: must be zero
-- clocks: must be exactly one entry
-- clock-names: must be "cfg"
-
-Example:
-	sata_phy: sata-phy@1b400000 {
-		compatible = "qcom,ipq806x-sata-phy";
-		reg = <0x1b400000 0x200>;
-
-		clocks = <&gcc SATA_PHY_CFG_CLK>;
-		clock-names = "cfg";
-
-		#phy-cells = <0>;
-	};
-- 
2.45.2

Re: [PATCH 1/2] dt-bindings: phy: qcom,sata-phy: convert to dtschema

[Krzysztof Kozlowski]

On 15/07/2024 15:01, Rayyan Ansari wrote:
> Convert the bindings for the SATA PHY on both apq8064 and ipq806x from
> the old text format to yaml.
> 
> Signed-off-by: Rayyan Ansari <rayyan.ansari@linaro.org>

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

[PATCH 2/2] ARM: dts: qcom: apq8064: drop reg-names on sata-phy node

[Rayyan Ansari]

Remove the reg-names property in the sata-phy node as it is not present
in the bindings and is not required by the driver.

Signed-off-by: Rayyan Ansari <rayyan.ansari@linaro.org>
---
 arch/arm/boot/dts/qcom/qcom-apq8064.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi
index 769e151747c3..81cf387e1817 100644
--- a/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi
@@ -871,7 +871,6 @@ sata_phy0: phy@1b400000 {
 			compatible = "qcom,apq8064-sata-phy";
 			status = "disabled";
 			reg = <0x1b400000 0x200>;
-			reg-names = "phy_mem";
 			clocks = <&gcc SATA_PHY_CFG_CLK>;
 			clock-names = "cfg";
 			#phy-cells = <0>;
-- 
2.45.2

Re: [PATCH 2/2] ARM: dts: qcom: apq8064: drop reg-names on sata-phy node

[Konrad Dybcio]

On 15.07.2024 3:01 PM, Rayyan Ansari wrote:
> Remove the reg-names property in the sata-phy node as it is not present
> in the bindings and is not required by the driver.
> 
> Signed-off-by: Rayyan Ansari <rayyan.ansari@linaro.org>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad

Re: (subset) [PATCH 0/2] Convert Qualcomm SATA PHY bindings to dtschema

[Bjorn Andersson]

On Mon, 15 Jul 2024 14:01:05 +0100, Rayyan Ansari wrote:
> The following patches:
> - Convert the old apq8064 and ipq806x text bindings, to a new unified
>   qcom,sata-phy binding in yaml.
> - Remove reg-names from the SATA PHY node in apq8064.dtsi to conform to
>   the bindings
> 
> Thanks,
> Rayyan
> 
> [...]

Applied, thanks!

[2/2] ARM: dts: qcom: apq8064: drop reg-names on sata-phy node
      commit: 89721c0e5bf14e06dea2b42ab5efdff4bf035f83

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: [PATCH 0/2] Convert Qualcomm SATA PHY bindings to dtschema

[Vinod Koul]

On Mon, 15 Jul 2024 14:01:05 +0100, Rayyan Ansari wrote:
> The following patches:
> - Convert the old apq8064 and ipq806x text bindings, to a new unified
>   qcom,sata-phy binding in yaml.
> - Remove reg-names from the SATA PHY node in apq8064.dtsi to conform to
>   the bindings
> 
> Thanks,
> Rayyan
> 
> [...]

Applied, thanks!

[1/2] dt-bindings: phy: qcom,sata-phy: convert to dtschema
      commit: 4bf8b462f84dd81c5938341a5468c3b669dbb1af
[2/2] ARM: dts: qcom: apq8064: drop reg-names on sata-phy node
      (no commit info)

Best regards,
-- 
Vinod Koul <vkoul@kernel.org>