Re: [PATCH 1/2] dt-bindings: arm: rockchip: add Firefly CORE PX30 JD4

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1209 bytes --]

On Tue, Jul 16, 2024 at 04:51:04PM +0100, Christopher Obbard wrote:
> The Firefly CORE PX30 JD4 board is a SOM and motherboard bundle from
> Firefly. Add devicetree binding documentation for it.
> 
> Signed-off-by: Christopher Obbard <chris.obbard@collabora.com>
> ---
>  Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index e04c213a0dee4..19e06e1253e15 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -148,6 +148,11 @@ properties:
>            - const: engicam,px30-core
>            - const: rockchip,px30
>  
> +      - description: Firefly Core PX30 JD4
> +        items:
> +          - const: firefly,core-px30-jd4
> +          - const: rockchip,px30

Not having individual compatibles for the carrier and som seems odd to,
given there's no requirement to use the som with this particular
carrier.

> +
>        - description: Firefly Firefly-RK3288
>          items:
>            - enum:
> 
> -- 
> 2.45.2
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]