devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 0/2] Add Add elan-ekth6a12nay on the basis of elan-ekth6915
@ 2024-07-16  8:28 Zhaoxiong Lv
  2024-07-16  8:28 ` [PATCH v3 1/2] dt-bindings: HID: i2c-hid: elan: Introduce Elan ekth6a12nay Zhaoxiong Lv
  2024-07-16  8:28 ` [PATCH v3 2/2] HID: i2c-hid: elan: Add elan-ekth6a12nay timing Zhaoxiong Lv
  0 siblings, 2 replies; 4+ messages in thread
From: Zhaoxiong Lv @ 2024-07-16  8:28 UTC (permalink / raw)
  To: dmitry.torokhov, robh, krzysztof.kozlowski+dt, conor+dt, jikos,
	bentiss, linus.walleij, dianders, hsinyi
  Cc: dri-devel, devicetree, linux-kernel, Zhaoxiong Lv

Elan-ekth6a12nay requires reset to pull down time greater than 10ms,
so the configuration post_power_delay_ms is 10, and the chipset
initial time is required to be greater than 300ms, so the 
post_gpio_reset_on_delay_ms is set to 300.

The Elan-ekth6a12nay touch screen chip same as Elan-eKTH6915 controller
has a reset gpio. The difference is that they have different
post_power_delay_ms.

Changes between V3 and V2:
- PATCH 1/2: Respin the series on top of v6.10.
- PATCH 2/2: No changes.
- Link to v1: https://lore.kernel.org/all/20240715073159.25064-1-lvzhaoxiong@huaqin.corp-partner.google.com/

Changes between V2 and V1:
- PATCH 1/2: Respin the series on top of v6.10.
- PATCH 2/2: No changes.
- Link to v1: https://lore.kernel.org/all/20240704085555.11204-1-lvzhaoxiong@huaqin.corp-partner.google.com/

Zhaoxiong Lv (2):
  dt-bindings: HID: i2c-hid: elan: Introduce Elan ekth6a12nay
  HID: i2c-hid: elan: Add elan-ekth6a12nay timing

 .../devicetree/bindings/input/elan,ekth6915.yaml          | 1 +
 drivers/hid/i2c-hid/i2c-hid-of-elan.c                     | 8 ++++++++
 2 files changed, 9 insertions(+)

-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v3 1/2] dt-bindings: HID: i2c-hid: elan: Introduce Elan ekth6a12nay
  2024-07-16  8:28 [PATCH v3 0/2] Add Add elan-ekth6a12nay on the basis of elan-ekth6915 Zhaoxiong Lv
@ 2024-07-16  8:28 ` Zhaoxiong Lv
  2024-07-16 13:49   ` Rob Herring
  2024-07-16  8:28 ` [PATCH v3 2/2] HID: i2c-hid: elan: Add elan-ekth6a12nay timing Zhaoxiong Lv
  1 sibling, 1 reply; 4+ messages in thread
From: Zhaoxiong Lv @ 2024-07-16  8:28 UTC (permalink / raw)
  To: dmitry.torokhov, robh, krzysztof.kozlowski+dt, conor+dt, jikos,
	bentiss, linus.walleij, dianders, hsinyi
  Cc: dri-devel, devicetree, linux-kernel, Zhaoxiong Lv

The Elan ekth6a12nay touch screen chip same as Elan eKTH6915 controller
has a reset gpio. The difference is that they have different
post_power_delay_ms.

Signed-off-by: Zhaoxiong Lv <lvzhaoxiong@huaqin.corp-partner.google.com>
---
Changes between V3 and V2:
-  1.  "ekth6915" isn't a fallback, modify it.
v2: https://lore.kernel.org/all/20240715073159.25064-2-lvzhaoxiong@huaqin.corp-partner.google.com/

Changes between V2 and V1:
-  1.  Respin the series on top of v6.10.
v1: https://lore.kernel.org/all/20240704085555.11204-2-lvzhaoxiong@huaqin.corp-partner.google.com/
---
 Documentation/devicetree/bindings/input/elan,ekth6915.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml
index a62916d07a08..f683048fd0c4 100644
--- a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml
+++ b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml
@@ -24,6 +24,7 @@ properties:
               - elan,ekth5015m
           - const: elan,ekth6915
       - const: elan,ekth6915
+      - const: elan,ekth6a12nay
 
   reg:
     const: 0x10
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v3 2/2] HID: i2c-hid: elan: Add elan-ekth6a12nay timing
  2024-07-16  8:28 [PATCH v3 0/2] Add Add elan-ekth6a12nay on the basis of elan-ekth6915 Zhaoxiong Lv
  2024-07-16  8:28 ` [PATCH v3 1/2] dt-bindings: HID: i2c-hid: elan: Introduce Elan ekth6a12nay Zhaoxiong Lv
@ 2024-07-16  8:28 ` Zhaoxiong Lv
  1 sibling, 0 replies; 4+ messages in thread
From: Zhaoxiong Lv @ 2024-07-16  8:28 UTC (permalink / raw)
  To: dmitry.torokhov, robh, krzysztof.kozlowski+dt, conor+dt, jikos,
	bentiss, linus.walleij, dianders, hsinyi
  Cc: dri-devel, devicetree, linux-kernel, Zhaoxiong Lv

Elan-ekth6a12nay requires reset to pull down time greater than 10ms,
so the configuration post_power_delay_ms is 10, and the chipset
initial time is required to be greater than 300ms,
so the post_gpio_reset_on_delay_ms is set to 300.

Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Zhaoxiong Lv <lvzhaoxiong@huaqin.corp-partner.google.com>
---
Changes between V3 and V2:
-  2. No changes.
v2: https://lore.kernel.org/all/20240715073159.25064-3-lvzhaoxiong@huaqin.corp-partner.google.com/

Changes between V2 and V1:
-  1. No changes.
v1: https://lore.kernel.org/all/20240704085555.11204-3-lvzhaoxiong@huaqin.corp-partner.google.com/
---
 drivers/hid/i2c-hid/i2c-hid-of-elan.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/hid/i2c-hid/i2c-hid-of-elan.c b/drivers/hid/i2c-hid/i2c-hid-of-elan.c
index 091e37933225..3fcff6daa0d3 100644
--- a/drivers/hid/i2c-hid/i2c-hid-of-elan.c
+++ b/drivers/hid/i2c-hid/i2c-hid-of-elan.c
@@ -152,6 +152,13 @@ static const struct elan_i2c_hid_chip_data elan_ekth6915_chip_data = {
 	.main_supply_name = "vcc33",
 };
 
+static const struct elan_i2c_hid_chip_data elan_ekth6a12nay_chip_data = {
+	.post_power_delay_ms = 10,
+	.post_gpio_reset_on_delay_ms = 300,
+	.hid_descriptor_address = 0x0001,
+	.main_supply_name = "vcc33",
+};
+
 static const struct elan_i2c_hid_chip_data ilitek_ili9882t_chip_data = {
 	.post_power_delay_ms = 1,
 	.post_gpio_reset_on_delay_ms = 200,
@@ -174,6 +181,7 @@ static const struct elan_i2c_hid_chip_data ilitek_ili2901_chip_data = {
 
 static const struct of_device_id elan_i2c_hid_of_match[] = {
 	{ .compatible = "elan,ekth6915", .data = &elan_ekth6915_chip_data },
+	{ .compatible = "elan,ekth6a12nay", .data = &elan_ekth6a12nay_chip_data },
 	{ .compatible = "ilitek,ili9882t", .data = &ilitek_ili9882t_chip_data },
 	{ .compatible = "ilitek,ili2901", .data = &ilitek_ili2901_chip_data },
 	{ }
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v3 1/2] dt-bindings: HID: i2c-hid: elan: Introduce Elan ekth6a12nay
  2024-07-16  8:28 ` [PATCH v3 1/2] dt-bindings: HID: i2c-hid: elan: Introduce Elan ekth6a12nay Zhaoxiong Lv
@ 2024-07-16 13:49   ` Rob Herring
  0 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2024-07-16 13:49 UTC (permalink / raw)
  To: Zhaoxiong Lv
  Cc: dmitry.torokhov, krzysztof.kozlowski+dt, conor+dt, jikos, bentiss,
	linus.walleij, dianders, hsinyi, dri-devel, devicetree,
	linux-kernel

On Tue, Jul 16, 2024 at 04:28:50PM +0800, Zhaoxiong Lv wrote:
> The Elan ekth6a12nay touch screen chip same as Elan eKTH6915 controller
> has a reset gpio. The difference is that they have different
> post_power_delay_ms.
> 
> Signed-off-by: Zhaoxiong Lv <lvzhaoxiong@huaqin.corp-partner.google.com>
> ---
> Changes between V3 and V2:
> -  1.  "ekth6915" isn't a fallback, modify it.
> v2: https://lore.kernel.org/all/20240715073159.25064-2-lvzhaoxiong@huaqin.corp-partner.google.com/
> 
> Changes between V2 and V1:
> -  1.  Respin the series on top of v6.10.
> v1: https://lore.kernel.org/all/20240704085555.11204-2-lvzhaoxiong@huaqin.corp-partner.google.com/
> ---
>  Documentation/devicetree/bindings/input/elan,ekth6915.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml
> index a62916d07a08..f683048fd0c4 100644
> --- a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml
> +++ b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml
> @@ -24,6 +24,7 @@ properties:
>                - elan,ekth5015m
>            - const: elan,ekth6915
>        - const: elan,ekth6915
> +      - const: elan,ekth6a12nay

Combine the 2 const into an enum.

With that,

Acked-by: Rob Herring (Arm) <robh@kernel.org>

>  
>    reg:
>      const: 0x10
> -- 
> 2.17.1
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-07-16 13:49 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-16  8:28 [PATCH v3 0/2] Add Add elan-ekth6a12nay on the basis of elan-ekth6915 Zhaoxiong Lv
2024-07-16  8:28 ` [PATCH v3 1/2] dt-bindings: HID: i2c-hid: elan: Introduce Elan ekth6a12nay Zhaoxiong Lv
2024-07-16 13:49   ` Rob Herring
2024-07-16  8:28 ` [PATCH v3 2/2] HID: i2c-hid: elan: Add elan-ekth6a12nay timing Zhaoxiong Lv

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).