devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Bjorn Andersson <andersson@kernel.org>,
	 Michael Turquette <mturquette@baylibre.com>,
	 Stephen Boyd <sboyd@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	 Konrad Dybcio <konrad.dybcio@linaro.org>,
	Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	 linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: [PATCH v2 1/7] clk: qcom: dispcc-sm8550: fix several supposed typos
Date: Wed, 17 Jul 2024 13:04:28 +0300	[thread overview]
Message-ID: <20240717-dispcc-sm8550-fixes-v2-1-5c4a3128c40b@linaro.org> (raw)
In-Reply-To: <20240717-dispcc-sm8550-fixes-v2-0-5c4a3128c40b@linaro.org>

Fix seveal odd-looking places in SM8550's dispcc driver:

- duplicate entries in disp_cc_parent_map_4 and disp_cc_parent_map_5
- using &disp_cc_mdss_dptx0_link_div_clk_src as a source for
  disp_cc_mdss_dptx1_usb_router_link_intf_clk

The SM8650 driver has been used as a reference.

Fixes: 90114ca11476 ("clk: qcom: add SM8550 DISPCC driver")
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 drivers/clk/qcom/dispcc-sm8550.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/qcom/dispcc-sm8550.c b/drivers/clk/qcom/dispcc-sm8550.c
index 31ae46f180a5..954b0f6fcea2 100644
--- a/drivers/clk/qcom/dispcc-sm8550.c
+++ b/drivers/clk/qcom/dispcc-sm8550.c
@@ -196,7 +196,7 @@ static const struct clk_parent_data disp_cc_parent_data_3[] = {
 static const struct parent_map disp_cc_parent_map_4[] = {
 	{ P_BI_TCXO, 0 },
 	{ P_DP0_PHY_PLL_LINK_CLK, 1 },
-	{ P_DP1_PHY_PLL_VCO_DIV_CLK, 2 },
+	{ P_DP0_PHY_PLL_VCO_DIV_CLK, 2 },
 	{ P_DP3_PHY_PLL_VCO_DIV_CLK, 3 },
 	{ P_DP1_PHY_PLL_VCO_DIV_CLK, 4 },
 	{ P_DP2_PHY_PLL_VCO_DIV_CLK, 6 },
@@ -213,7 +213,7 @@ static const struct clk_parent_data disp_cc_parent_data_4[] = {
 
 static const struct parent_map disp_cc_parent_map_5[] = {
 	{ P_BI_TCXO, 0 },
-	{ P_DSI0_PHY_PLL_OUT_BYTECLK, 4 },
+	{ P_DSI0_PHY_PLL_OUT_BYTECLK, 2 },
 	{ P_DSI1_PHY_PLL_OUT_BYTECLK, 4 },
 };
 

-- 
2.39.2


  reply	other threads:[~2024-07-17 10:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-17 10:04 [PATCH v2 0/7] clk: qcom: merge SM8550 and SM8650 display clock controller drivers Dmitry Baryshkov
2024-07-17 10:04 ` Dmitry Baryshkov [this message]
2024-07-17 11:49   ` [PATCH v2 1/7] clk: qcom: dispcc-sm8550: fix several supposed typos Neil Armstrong
2024-07-17 10:04 ` [PATCH v2 2/7] clk: qcom: dispcc-sm8550: use rcg2_ops for mdss_dptx1_aux_clk_src Dmitry Baryshkov
2024-07-17 11:49   ` Neil Armstrong
2024-07-17 10:04 ` [PATCH v2 3/7] clk: qcom: dispcc-sm8550: make struct clk_init_data const Dmitry Baryshkov
2024-07-17 11:50   ` Neil Armstrong
2024-07-17 10:04 ` [PATCH v2 4/7] clk: qcom: dispcc-sm8650: Update the GDSC flags Dmitry Baryshkov
2024-07-17 11:50   ` Neil Armstrong
2024-07-17 10:04 ` [PATCH v2 5/7] clk: qcom: dispcc-sm8550: use rcg2_shared_ops for ESC RCGs Dmitry Baryshkov
2024-07-17 11:50   ` Neil Armstrong
2024-07-17 10:04 ` [PATCH v2 6/7] clk: qcom: fold dispcc-sm8650 info dispcc-sm8550 Dmitry Baryshkov
2024-07-17 10:12   ` Konrad Dybcio
2024-07-17 11:50   ` Neil Armstrong
2024-07-17 10:04 ` [PATCH v2 7/7] dt-bindings: clock: qcom,sm8650-dispcc: replace with symlink Dmitry Baryshkov
2024-07-17 11:51   ` Neil Armstrong
2024-07-18  6:33   ` Krzysztof Kozlowski
2024-08-01  3:19 ` (subset) [PATCH v2 0/7] clk: qcom: merge SM8550 and SM8650 display clock controller drivers Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240717-dispcc-sm8550-fixes-v2-1-5c4a3128c40b@linaro.org \
    --to=dmitry.baryshkov@linaro.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=neil.armstrong@linaro.org \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).