[PATCH v1 0/3] Fix incorrect bh2228fv compatible

[PATCH v1 0/3] Fix incorrect bh2228fv compatible

[Conor Dooley]

From: Conor Dooley <conor.dooley@microchip.com>

Maxime made a typo when adding this device to the kernel all the way
back in 2012, fix the spelling mistake.

Really this device should not be in trivial-devices.yaml, but I'm
leaving the creation of a dedicated binding for when I get my hands on a
device :smiling_imp:

Cheers,
Conor.

CC: Rob Herring <robh@kernel.org>
CC: Krzysztof Kozlowski <krzk+dt@kernel.org>
CC: Conor Dooley <conor+dt@kernel.org>
CC: Shawn Guo <shawnguo@kernel.org>
CC: Sascha Hauer <s.hauer@pengutronix.de>
CC: Pengutronix Kernel Team <kernel@pengutronix.de>
CC: Fabio Estevam <festevam@gmail.com>
CC: Mark Brown <broonie@kernel.org>
CC: Maxime Ripard <mripard@kernel.org> (blamed_fixes:1/1=100%)
CC: devicetree@vger.kernel.org
CC: linux-kernel@vger.kernel.org
CC: imx@lists.linux.dev
CC: linux-arm-kernel@lists.infradead.org
CC: linux-spi@vger.kernel.org

Conor Dooley (3):
  dt-bindings: trivial-devices: fix Rohm BH2228FV compatible string
  spi: spidev: add correct compatible for Rohm BH2228FV
  ARM: dts: nxp: correct DAC compatible on Crystalfontz's CFA10049

 Documentation/devicetree/bindings/trivial-devices.yaml | 4 +++-
 arch/arm/boot/dts/nxp/mxs/imx28-cfa10049.dts           | 2 +-
 drivers/spi/spidev.c                                   | 1 +
 3 files changed, 5 insertions(+), 2 deletions(-)

-- 
2.43.0

[PATCH v1 1/3] dt-bindings: trivial-devices: fix Rohm BH2228FV compatible string

[Conor Dooley]

From: Conor Dooley <conor.dooley@microchip.com>

When Maxime originally added the BH2228FV to the spidev driver, he spelt
it incorrectly - the d should have been a b. That spelling was then
propagated to the binding when written by Krzysztof. Add a new, correctly
spelt compatible and advise against using the incorrectly spelling.

Fixes: 025aea27732d ("dt-bindings: trivial-devices: document SPI dev compatibles")
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
 Documentation/devicetree/bindings/trivial-devices.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index 5d3dc952770d..7913ca9b6b54 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -328,7 +328,9 @@ properties:
           - renesas,hs3001
             # Renesas ISL29501 time-of-flight sensor
           - renesas,isl29501
-            # Rohm DH2228FV
+            # Rohm BH2228FV 8 channel DAC
+          - rohm,bh2228fv
+            # Rohm DH2228FV - This device does not exist, use rohm,bh2228fv instead.
           - rohm,dh2228fv
             # S524AD0XF1 (128K/256K-bit Serial EEPROM for Low Power)
           - samsung,24ad0xd1
-- 
2.43.0

[PATCH v1 2/3] spi: spidev: add correct compatible for Rohm BH2228FV

[Conor Dooley]

From: Conor Dooley <conor.dooley@microchip.com>

When Maxime originally added the BH2228FV to the spidev driver, he spelt
it incorrectly - the d should have been a b. Add the correctly spelt
compatible to the driver. Although the majority of users of this
compatible are abusers, there is at least one board that validly uses
the incorrect spelt compatible, so keep it in the driver to avoid
breaking the few real users it has.

Fixes: 8fad805bdc52 ("spi: spidev: Add Rohm DH2228FV DAC compatible string")
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
 drivers/spi/spidev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c
index 95fb5f1c91c1..05e6d007f9a7 100644
--- a/drivers/spi/spidev.c
+++ b/drivers/spi/spidev.c
@@ -734,6 +734,7 @@ static const struct of_device_id spidev_dt_ids[] = {
 	{ .compatible = "lwn,bk4", .data = &spidev_of_check },
 	{ .compatible = "menlo,m53cpld", .data = &spidev_of_check },
 	{ .compatible = "micron,spi-authenta", .data = &spidev_of_check },
+	{ .compatible = "rohm,bh2228fv", .data = &spidev_of_check },
 	{ .compatible = "rohm,dh2228fv", .data = &spidev_of_check },
 	{ .compatible = "semtech,sx1301", .data = &spidev_of_check },
 	{ .compatible = "silabs,em3581", .data = &spidev_of_check },
-- 
2.43.0

[PATCH v1 3/3] ARM: dts: nxp: correct DAC compatible on Crystalfontz's CFA10049

[Conor Dooley]

From: Conor Dooley <conor.dooley@microchip.com>

When Maxime originally added the BH2228FV to the kernel, he spelt it
incorrectly - the d should have been a b. Correct the compatible used in
the devicetree.

Fixes: db7a8946dc40 ("ARM: dts: cfa10049: Add the DH2228FV DAC to the DTS")
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
 arch/arm/boot/dts/nxp/mxs/imx28-cfa10049.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/nxp/mxs/imx28-cfa10049.dts b/arch/arm/boot/dts/nxp/mxs/imx28-cfa10049.dts
index f0ce897b9d5c..3cd2acbd8931 100644
--- a/arch/arm/boot/dts/nxp/mxs/imx28-cfa10049.dts
+++ b/arch/arm/boot/dts/nxp/mxs/imx28-cfa10049.dts
@@ -143,7 +143,7 @@ gpio6: gpio6@1 {
 		};
 
 		dac0: dh2228@2 {
-			compatible = "rohm,dh2228fv";
+			compatible = "rohm,bh2228fv";
 			reg = <2>;
 			spi-max-frequency = <100000>;
 		};
-- 
2.43.0

Re: [PATCH v1 3/3] ARM: dts: nxp: correct DAC compatible on Crystalfontz's CFA10049

[Krzysztof Kozlowski]

On 17/07/2024 11:59, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
> 
> When Maxime originally added the BH2228FV to the kernel, he spelt it
> incorrectly - the d should have been a b. Correct the compatible used in
> the devicetree.
> 
> Fixes: db7a8946dc40 ("ARM: dts: cfa10049: Add the DH2228FV DAC to the DTS")
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH v1 0/3] Fix incorrect bh2228fv compatible

[Maxime Ripard]

On Wed, 17 Jul 2024 10:59:47 +0100, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
> 
> Maxime made a typo when adding this device to the kernel all the way
> back in 2012, fix the spelling mistake.
> 
> 
> [ ... ]

Acked-by: Maxime Ripard <mripard@kernel.org>

Thanks!
Maxime

Re: (subset) [PATCH v1 0/3] Fix incorrect bh2228fv compatible

[Mark Brown]

On Wed, 17 Jul 2024 10:59:47 +0100, Conor Dooley wrote:
> Maxime made a typo when adding this device to the kernel all the way
> back in 2012, fix the spelling mistake.
> 
> Really this device should not be in trivial-devices.yaml, but I'm
> leaving the creation of a dedicated binding for when I get my hands on a
> device :smiling_imp:
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/3] dt-bindings: trivial-devices: fix Rohm BH2228FV compatible string
      commit: 5170dae5591036dba7daa519ea3126169300e275
[2/3] spi: spidev: add correct compatible for Rohm BH2228FV
      commit: fc28d1c1fe3b3e2fbc50834c8f73dda72f6af9fc

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark