From: Conor Dooley <conor@kernel.org>
To: Yuntao Dai <d1581209858@live.com>
Cc: Inochi Amaoto <inochiama@outlook.com>,
jassisinghbrar@gmail.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, unicorn_wang@outlook.com,
paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v2 1/3] dt-bindings: mailbox: add Sophgo cv18x SoCs mailbox
Date: Wed, 17 Jul 2024 18:12:26 +0100 [thread overview]
Message-ID: <20240717-flail-revisable-8f232da8f1c5@spud> (raw)
In-Reply-To: <SYBP282MB2238C5F2D4B10061FA241CCFC4A32@SYBP282MB2238.AUSP282.PROD.OUTLOOK.COM>
[-- Attachment #1: Type: text/plain, Size: 850 bytes --]
On Thu, Jul 18, 2024 at 01:06:46AM +0800, Yuntao Dai wrote:
> > > > +examples:
> > > > + - |
> > > > + #include <dt-bindings/interrupt-controller/irq.h>
> > > > +
> > > > + mailbox: mailbox@1900000 {
> >
> > And while you're fixing the things Inochi pointed out, drop the
> > "mailbox:" label, you've got no references to it.
> >
>
> Yes, in this patch there is no references to it, but mailbox client node
> will need it.
> I tested this patch using mailbox-test as the client, like:
> "
> mailbox-test {
> compatible = "mailbox-test";
> mbox-names = "rx", "tx";
> mboxes = <&mailbox 0 1 &mailbox 1 2>;
> };
> "
>
> If you think it is better to drop the label in this patch, I will drop it.
Just drop it from the example, you can keep it in the actual dts. We try
to keep these examples to a minimum.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-07-17 17:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-14 16:28 [PATCH v2 0/3] riscv: sophgo: add mailbox support for cv18x SoCs Yuntao Dai
2024-07-14 16:36 ` [PATCH v2 1/3] dt-bindings: mailbox: add Sophgo cv18x SoCs mailbox Yuntao Dai
2024-07-15 2:56 ` Inochi Amaoto
2024-07-15 16:15 ` Conor Dooley
2024-07-17 17:06 ` Yuntao Dai
2024-07-17 17:12 ` Conor Dooley [this message]
[not found] ` <IA1PR20MB49537F9F04E601413EA1C86FBBA12@IA1PR20MB4953.namprd20.prod.outlook.c om>
2024-07-17 17:02 ` Yuntao Dai
2024-07-14 16:36 ` [PATCH v2 2/3] riscv: dts: add mailbox for Sophgo cv18x SoCs Yuntao Dai
2024-07-15 2:53 ` Inochi Amaoto
2024-07-19 1:19 ` Samuel Holland
2024-07-14 16:36 ` [PATCH v2 3/3] mailbox: sophgo: add mailbox driver for " Yuntao Dai
2024-07-15 1:59 ` kernel test robot
2024-07-15 9:09 ` kernel test robot
2024-07-19 1:35 ` Samuel Holland
2024-07-22 17:02 ` Yuntao Dai
2024-07-16 12:55 ` [PATCH v2 0/3] riscv: sophgo: add mailbox support " Chen Wang
[not found] ` <MA0P287MB282276F453744C2ACC2FF627FEA22@MA0P287MB2822.INDP287.PROD.OUTLOOK.CO M>
2024-07-17 17:07 ` Yuntao Dai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240717-flail-revisable-8f232da8f1c5@spud \
--to=conor@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=d1581209858@live.com \
--cc=devicetree@vger.kernel.org \
--cc=inochiama@outlook.com \
--cc=jassisinghbrar@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=unicorn_wang@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox