Re: [PATCH v1 2/4] ARM: dts: rockchip: remove unlikly-to-exist DAC from elgin-r1

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1079 bytes --]

On Wed, Jul 17, 2024 at 12:34:03PM -0300, Fabio Estevam wrote:
> On Wed, Jul 17, 2024 at 11:38 AM Otavio Salvador
> <otavio.salvador@ossystems.com.br> wrote:
> 
> > @Fabio Estevam can you check this patch?
> 
> Correct, the rv1108-elgin-r1.dts board does not contain the DAC.
> 
> There is an LCD controlled via spidev though.
> 
> Conor,
> 
> If spidev is needed, what is the recommended way to describe it in the
> devicetree?

Describe the device you actually have in a binding, and add that
compatible to the spidev driver. In this case, given there's a
particular LCD there, that'll work. There's nothing wrong with using
spidev, it's just lying about what hardware that is there that's
problematic.

Otherwise, when it is an open connector where you can put anything, it's
a wee bit messier... A connector binding is required then, something
like the WIP mikrobus stuff that the beagle lads are working on. That's
far from ready, at least on the devicetree side of things, though so
you need to apply an overlay in your bootloader in that case.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]