Re: [PATCH v7 4/6] dt-bindings: iio: dac: Add adi,ltc2664.yaml

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2980 bytes --]

On Wed, Jul 17, 2024 at 01:07:31AM +0000, Paller, Kim Seer wrote:
> 
> 
> > -----Original Message-----
> > From: Conor Dooley <conor@kernel.org>
> > Sent: Tuesday, July 16, 2024 11:58 PM
> > To: Paller, Kim Seer <KimSeer.Paller@analog.com>
> > Cc: linux-kernel@vger.kernel.org; linux-iio@vger.kernel.org;
> > devicetree@vger.kernel.org; Jonathan Cameron <jic23@kernel.org>; David
> > Lechner <dlechner@baylibre.com>; Lars-Peter Clausen <lars@metafoo.de>;
> > Liam Girdwood <lgirdwood@gmail.com>; Mark Brown <broonie@kernel.org>;
> > Dimitri Fedrau <dima.fedrau@gmail.com>; Krzysztof Kozlowski
> > <krzk+dt@kernel.org>; Rob Herring <robh@kernel.org>; Conor Dooley
> > <conor+dt@kernel.org>; Hennerich, Michael
> > <Michael.Hennerich@analog.com>; Nuno Sá <noname.nuno@gmail.com>
> > Subject: Re: [PATCH v7 4/6] dt-bindings: iio: dac: Add adi,ltc2664.yaml
> > 
> > [External]
> > 
> > On Tue, Jul 16, 2024 at 01:50:23AM +0000, Paller, Kim Seer wrote:
> > >
> > >
> > > > -----Original Message-----
> > > > From: Conor Dooley <conor@kernel.org>
> > > > Sent: Tuesday, July 16, 2024 12:18 AM
> > > > To: Paller, Kim Seer <KimSeer.Paller@analog.com>
> > > > Cc: linux-kernel@vger.kernel.org; linux-iio@vger.kernel.org;
> > > > devicetree@vger.kernel.org; Jonathan Cameron <jic23@kernel.org>; David
> > > > Lechner <dlechner@baylibre.com>; Lars-Peter Clausen <lars@metafoo.de>;
> > > > Liam Girdwood <lgirdwood@gmail.com>; Mark Brown
> > <broonie@kernel.org>;
> > > > Dimitri Fedrau <dima.fedrau@gmail.com>; Krzysztof Kozlowski
> > > > <krzk+dt@kernel.org>; Rob Herring <robh@kernel.org>; Conor Dooley
> > > > <conor+dt@kernel.org>; Hennerich, Michael
> > > > <Michael.Hennerich@analog.com>; Nuno Sá <noname.nuno@gmail.com>
> > > > Subject: Re: [PATCH v7 4/6] dt-bindings: iio: dac: Add adi,ltc2664.yaml
> > > >
> > > > [External]
> > > >
> > > > On Sun, Jul 14, 2024 at 09:29:58PM +0800, Kim Seer Paller wrote:
> > > > > Add documentation for ltc2664.
> > > > >
> > > > > Co-developed-by: Michael Hennerich <michael.hennerich@analog.com>
> > > > > Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
> > > > > Signed-off-by: Kim Seer Paller <kimseer.paller@analog.com>
> > > >
> > > > IIRC I gave you a reviewed-by on v5, was there a particular reason you
> > didn't
> > > > add it?
> > >
> > > I made changes to the 'output-range-microvolt' logic in v6, which I thought
> > > might require a new review. If your 'Reviewed-by' tag still applies, please let
> > me know.
> > 
> > IIRC what I said was along the lines of "with the logic from the
> > previous version, Reviewed-by: Conor Dooley <conor.dooley@microchip.com>".
> > Is that what you did?
> 
> Yes. Additionally, considering Krzysztof's recent comment about the mixed 
> indentation in the example section, should I send a new patch version that
> includes this indentation fix along with adding your Reviewed-by tag?

Seems reasonable to me, thanks.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]