From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A009F2CCA3; Thu, 18 Jul 2024 06:57:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.198 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721285833; cv=none; b=fNmUaH5/hDAeWsLLvkppIIirgmi1HtbJnuKnYqml9XcyWghm6dQ0du5cbbl9lGMp/uVT21LNCzIcGIFrEPxbQY+muuwMfwitKnnkwLQvTCyb6xuhA0REMgSsgoInLb+0Mq0qvqXOq9oC95A5W0TTZAbZj/VzxzslgLsYebixoxk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721285833; c=relaxed/simple; bh=z+aCMhKYfdvSH3LqcS7QRiHX5Ygt46joT7nhNjNOLXA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=R6V6ocq6oikBjxhzj8+vNfcMiWTu45ZEzHbhFgRHS4+nC6GeFhk81jBnyENm1YSo++iXzaZ1tfBJdxX+Dx2IpYBffxq1vvSDPIikQ1n9+bjxTEe0xWaT6Q7Ooc3L/Myt/6rFktvb5dlU/5RMviYmnc0bsfk8t91KKzRBpzY/tRg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=OlB6nsD5; arc=none smtp.client-ip=217.70.183.198 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="OlB6nsD5" Received: by mail.gandi.net (Postfix) with ESMTPSA id 66B00C0011; Thu, 18 Jul 2024 06:56:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1721285821; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TgZHkXL2FGs1/bjZPDSboGR72yBe//NfgloPvNTjUQ0=; b=OlB6nsD5RtGZmYjd7bhjEoZx7QMkbbOT8V45YhxxCFz4y2iiCJe+cf2PVPl+VsXD6UUMqk Yc28bGhZQ13OubzP5CW/pjPqqFo91MRM0eVoREVGLvn0MLgNZy6pPxquFKWhNBkv4SbFT2 sax9ioW5vC5M5bokQz4XncM9ZdU0GCDemzBwA+l1XJdTnXTEUKHI48dxPqMAjv00+G3aQG rBXI5/ojqb79XSjovNP74Rn6wSf1My85vfzfK9OmlUEoc3d8vGPg+knHhqSD5yHTRQLUcZ BDxiKiWHxBRawYhcLiwX+N2Krj0xmgk4IRTokaqbJaztXMntEG+p6mo1v3ON7A== Date: Thu, 18 Jul 2024 08:56:51 +0200 From: Luca Ceresoli To: Stephen Boyd Cc: Aaro Koskinen , Alexandre Belloni , Alim Akhtar , Andreas Kemnade , Bartosz Golaszewski , Bjorn Andersson , Broadcom internal kernel review list , Chen-Yu Tsai , Chester Lin , Christophe Leroy , Claudiu Beznea , Damien Le Moal , Daniel Lezcano , Dong Aisheng , Doug Berger , Emilio =?UTF-8?Q?L=C3=B3pez?= , Fabio Estevam , Florian Fainelli , Ghennadi Procopciuc , Greg Kroah-Hartman , Jacky Bai , Jaroslav Kysela , Jernej Skrabec , Jiri Slaby , Jonathan Cameron , Kevin Hilman , Krzysztof Kozlowski , Lars-Peter Clausen , Lee Jones , Liam Girdwood , Linus Walleij , Mark Brown , Matthias Brugger , Michael Ellerman , Michael Turquette , Miguel Ojeda , Nathan Chancellor , "Naveen N. Rao" , Nicholas Piggin , Nicolas Ferre , Pengutronix Kernel Team , Richard Leitner , Rob Herring , Roger Quadros , Samuel Holland , Saravana Kannan , Shawn Guo , Takashi Iwai , Thomas Gleixner , Tony Lindgren , Uwe =?UTF-8?Q?Kleine-K=C3=B6nig?= , "Peng Fan (OSS)" , Thomas Petazzoni , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, llvm@lists.linux.dev, linux-clk@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-iio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, Andre Przywara , Bartosz Golaszewski , Jonathan Cameron , Uwe =?UTF-8?Q?Kleine-K=C3=B6nig?= , Richard Fitzgerald Subject: Re: [PATCH v2] of: remove internal arguments from of_property_for_each_u32() Message-ID: <20240718085651.63ddfb20@booty> In-Reply-To: <1e36b1ba8af3584128550822a70cb072.sboyd@kernel.org> References: <20240717-of_property_for_each_u32-v2-1-4060990f49c9@bootlin.com> <1e36b1ba8af3584128550822a70cb072.sboyd@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-GND-Sasl: luca.ceresoli@bootlin.com Hello Stephen, On Wed, 17 Jul 2024 16:33:34 -0700 Stephen Boyd wrote: > > @@ -1191,20 +1191,24 @@ static int si5351_dt_parse(struct i2c_client *client, > > * property silabs,pll-source : , [<..>] > > * allow to selectively set pll source > > */ > > - of_property_for_each_u32(np, "silabs,pll-source", prop, p, num) { > > + sz = of_property_read_variable_u32_array(np, "silabs,pll-source", array, 2, 4); > > + sz = (sz == -EINVAL) ? 0 : sz; /* Missing property is OK */ > > + if (sz < 0) > > + return dev_err_probe(&client->dev, sz, "invalid pll-source"); > > Needs a newline on the printk message. Ouch! Fix queued for v3. Thanks, Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com