[PATCH 1/3] dt-bindings: trivial-devices: Document elgin,spi-lcd

[PATCH 1/3] dt-bindings: trivial-devices: Document elgin,spi-lcd

[Fabio Estevam]

The rv1108-elgin-r1 board has an LCD controlled via SPI in userspace.

Add an entry for the "elgin,spi-lcd" compatible string.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index 7913ca9b6b54..49dee2a1f6b4 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -110,6 +110,8 @@ properties:
           - domintech,dmard09
             # DMARD10: 3-axis Accelerometer
           - domintech,dmard10
+            # Elgin SPI-controlled LCD
+          - elgin,spi-lcd
             # MMA7660FC: 3-Axis Orientation/Motion Detection Sensor
           - fsl,mma7660
             # MMA8450Q: Xtrinsic Low-power, 3-axis Xtrinsic Accelerometer
-- 
2.34.1

[PATCH 2/3] spi: spidev: Add an entry for "elgin,spi-lcd"

[Fabio Estevam]

The rv1108-elgin-r1 board has an LCD controlled via SPI in userspace.

Add the "elgin,spi-lcd" compatible string.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 drivers/spi/spidev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c
index 05e6d007f9a7..316ed3664cb2 100644
--- a/drivers/spi/spidev.c
+++ b/drivers/spi/spidev.c
@@ -730,6 +730,7 @@ static int spidev_of_check(struct device *dev)
 static const struct of_device_id spidev_dt_ids[] = {
 	{ .compatible = "cisco,spi-petra", .data = &spidev_of_check },
 	{ .compatible = "dh,dhcom-board", .data = &spidev_of_check },
+	{ .compatible = "elgin,spi-lcd", .data = &spidev_of_check },
 	{ .compatible = "lineartechnology,ltc2488", .data = &spidev_of_check },
 	{ .compatible = "lwn,bk4", .data = &spidev_of_check },
 	{ .compatible = "menlo,m53cpld", .data = &spidev_of_check },
-- 
2.34.1

[PATCH 3/3] ARM: dts: rockchip: rv1108-elgin-r1: Do not describe unexisting DAC device

[Fabio Estevam]

There is no DAC connected to the SPI bus of the Elgin RV1108 R1 board.

There is an LCD controlled via SPI though.

Properly describe it by adding the "elgin,spi-lcd" compatible
string.

Reported-by: Conor Dooley <conor.dooley@microchip.com>
Closes: https://lore.kernel.org/linux-arm-kernel/20240717-parrot-malt-83cc04bf6b36@spud/
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
Hi Heiko,

Conor sent a patch removing the rohm,dh2228fv entry from rv1108-elgin-r1.dts:

https://lore.kernel.org/linux-arm-kernel/20240717-parrot-malt-83cc04bf6b36@spud/

If you prefer, I can send a patch on top of his.

Or you can apply this one instead.

 arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts b/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts
index 2d9994379eb2..971bb617e845 100644
--- a/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts
+++ b/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts
@@ -168,8 +168,8 @@ &spi {
 	pinctrl-0 = <&spim1_clk &spim1_cs0 &spim1_tx &spim1_rx>;
 	status = "okay";
 
-	dh2228fv: dac@0 {
-		compatible = "rohm,dh2228fv";
+	display: display@0 {
+		compatible = "elgin,spi-lcd";
 		reg = <0>;
 		spi-max-frequency = <24000000>;
 		spi-cpha;
-- 
2.34.1

Re: [PATCH 3/3] ARM: dts: rockchip: rv1108-elgin-r1: Do not describe unexisting DAC device

[Heiko Stübner]

Hi Fabio,

Am Donnerstag, 18. Juli 2024, 22:05:40 CEST schrieb Fabio Estevam:
> There is no DAC connected to the SPI bus of the Elgin RV1108 R1 board.
> 
> There is an LCD controlled via SPI though.
> 
> Properly describe it by adding the "elgin,spi-lcd" compatible
> string.
> 
> Reported-by: Conor Dooley <conor.dooley@microchip.com>
> Closes: https://lore.kernel.org/linux-arm-kernel/20240717-parrot-malt-83cc04bf6b36@spud/
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> Hi Heiko,
> 
> Conor sent a patch removing the rohm,dh2228fv entry from rv1108-elgin-r1.dts:
> 
> https://lore.kernel.org/linux-arm-kernel/20240717-parrot-malt-83cc04bf6b36@spud/
> 
> If you prefer, I can send a patch on top of his.

The decision is interesting, one less patch vs. keeping Conor's separate
patch history. Maybe Conor voices his opinion while we're still in the merge
window :-) .


Heiko
> Or you can apply this one instead.
> 
>  arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts b/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts
> index 2d9994379eb2..971bb617e845 100644
> --- a/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts
> +++ b/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dts
> @@ -168,8 +168,8 @@ &spi {
>  	pinctrl-0 = <&spim1_clk &spim1_cs0 &spim1_tx &spim1_rx>;
>  	status = "okay";
>  
> -	dh2228fv: dac@0 {
> -		compatible = "rohm,dh2228fv";
> +	display: display@0 {
> +		compatible = "elgin,spi-lcd";
>  		reg = <0>;
>  		spi-max-frequency = <24000000>;
>  		spi-cpha;
> 

Re: [PATCH 3/3] ARM: dts: rockchip: rv1108-elgin-r1: Do not describe unexisting DAC device

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1227 bytes --]

On Fri, Jul 19, 2024 at 10:02:56AM +0200, Heiko Stübner wrote:
> Am Donnerstag, 18. Juli 2024, 22:05:40 CEST schrieb Fabio Estevam:
> > There is no DAC connected to the SPI bus of the Elgin RV1108 R1 board.
> > 
> > There is an LCD controlled via SPI though.
> > 
> > Properly describe it by adding the "elgin,spi-lcd" compatible
> > string.
> > 
> > Reported-by: Conor Dooley <conor.dooley@microchip.com>
> > Closes: https://lore.kernel.org/linux-arm-kernel/20240717-parrot-malt-83cc04bf6b36@spud/
> > Signed-off-by: Fabio Estevam <festevam@gmail.com>
> > ---
> > Hi Heiko,
> > 
> > Conor sent a patch removing the rohm,dh2228fv entry from rv1108-elgin-r1.dts:
> > 
> > https://lore.kernel.org/linux-arm-kernel/20240717-parrot-malt-83cc04bf6b36@spud/
> > 
> > If you prefer, I can send a patch on top of his.
> 
> The decision is interesting, one less patch vs. keeping Conor's separate
> patch history. Maybe Conor voices his opinion while we're still in the merge
> window :-) .

Adding the correct device is an improvement over my patch, I don't see a
reason (other than vanity) for applying both. However, I don't think
that "elgin,spi-lcd" is a suitable compatible as it is far too generic.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 1/3] dt-bindings: trivial-devices: Document elgin,spi-lcd

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1315 bytes --]

On Thu, Jul 18, 2024 at 05:05:38PM -0300, Fabio Estevam wrote:
> The rv1108-elgin-r1 board has an LCD controlled via SPI in userspace.
> 
> Add an entry for the "elgin,spi-lcd" compatible string.
> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 7913ca9b6b54..49dee2a1f6b4 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -110,6 +110,8 @@ properties:
>            - domintech,dmard09
>              # DMARD10: 3-axis Accelerometer
>            - domintech,dmard10
> +            # Elgin SPI-controlled LCD
> +          - elgin,spi-lcd

As mentioned on the dts patch, this needs to be far more specific. Are
there no markings etc on the panel?
I still can't find any information online about this board, other than
linux/u-boot lists or related repos.

>              # MMA7660FC: 3-Axis Orientation/Motion Detection Sensor
>            - fsl,mma7660
>              # MMA8450Q: Xtrinsic Low-power, 3-axis Xtrinsic Accelerometer
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 1/3] dt-bindings: trivial-devices: Document elgin,spi-lcd

[Fabio Estevam]

Hi Conor,

On Fri, Jul 19, 2024 at 5:42 AM Conor Dooley <conor@kernel.org> wrote:

> As mentioned on the dts patch, this needs to be far more specific. Are
> there no markings etc on the panel?

I submitted v2 with a more specific compatible string containing the
markings on the panel.

Thanks