From: Conor Dooley <conor@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: broonie@kernel.org, linux-spi@vger.kernel.org,
otavio.salvador@ossystems.com.br, heiko@sntech.de,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: trivial-devices: Document elgin,spi-lcd
Date: Fri, 19 Jul 2024 09:42:32 +0100 [thread overview]
Message-ID: <20240719-clunky-skintight-7dde4efd7cb7@spud> (raw)
In-Reply-To: <20240718200540.955370-1-festevam@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1315 bytes --]
On Thu, Jul 18, 2024 at 05:05:38PM -0300, Fabio Estevam wrote:
> The rv1108-elgin-r1 board has an LCD controlled via SPI in userspace.
>
> Add an entry for the "elgin,spi-lcd" compatible string.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 7913ca9b6b54..49dee2a1f6b4 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -110,6 +110,8 @@ properties:
> - domintech,dmard09
> # DMARD10: 3-axis Accelerometer
> - domintech,dmard10
> + # Elgin SPI-controlled LCD
> + - elgin,spi-lcd
As mentioned on the dts patch, this needs to be far more specific. Are
there no markings etc on the panel?
I still can't find any information online about this board, other than
linux/u-boot lists or related repos.
> # MMA7660FC: 3-Axis Orientation/Motion Detection Sensor
> - fsl,mma7660
> # MMA8450Q: Xtrinsic Low-power, 3-axis Xtrinsic Accelerometer
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-07-19 8:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-18 20:05 [PATCH 1/3] dt-bindings: trivial-devices: Document elgin,spi-lcd Fabio Estevam
2024-07-18 20:05 ` [PATCH 2/3] spi: spidev: Add an entry for "elgin,spi-lcd" Fabio Estevam
2024-07-18 20:05 ` [PATCH 3/3] ARM: dts: rockchip: rv1108-elgin-r1: Do not describe unexisting DAC device Fabio Estevam
2024-07-19 8:02 ` Heiko Stübner
2024-07-19 8:30 ` Conor Dooley
2024-07-19 8:42 ` Conor Dooley [this message]
2024-07-19 14:38 ` [PATCH 1/3] dt-bindings: trivial-devices: Document elgin,spi-lcd Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240719-clunky-skintight-7dde4efd7cb7@spud \
--to=conor@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=otavio.salvador@ossystems.com.br \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).