Re: [PATCH 3/3] ARM: dts: rockchip: rv1108-elgin-r1: Do not describe unexisting DAC device

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1227 bytes --]

On Fri, Jul 19, 2024 at 10:02:56AM +0200, Heiko Stübner wrote:
> Am Donnerstag, 18. Juli 2024, 22:05:40 CEST schrieb Fabio Estevam:
> > There is no DAC connected to the SPI bus of the Elgin RV1108 R1 board.
> > 
> > There is an LCD controlled via SPI though.
> > 
> > Properly describe it by adding the "elgin,spi-lcd" compatible
> > string.
> > 
> > Reported-by: Conor Dooley <conor.dooley@microchip.com>
> > Closes: https://lore.kernel.org/linux-arm-kernel/20240717-parrot-malt-83cc04bf6b36@spud/
> > Signed-off-by: Fabio Estevam <festevam@gmail.com>
> > ---
> > Hi Heiko,
> > 
> > Conor sent a patch removing the rohm,dh2228fv entry from rv1108-elgin-r1.dts:
> > 
> > https://lore.kernel.org/linux-arm-kernel/20240717-parrot-malt-83cc04bf6b36@spud/
> > 
> > If you prefer, I can send a patch on top of his.
> 
> The decision is interesting, one less patch vs. keeping Conor's separate
> patch history. Maybe Conor voices his opinion while we're still in the merge
> window :-) .

Adding the correct device is an improvement over my patch, I don't see a
reason (other than vanity) for applying both. However, I don't think
that "elgin,spi-lcd" is a suitable compatible as it is far too generic.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]