* [PATCH 1/4] arm64: dts: qcom: sc8280xp-crd: disable PCIe perst pull downs
2024-07-19 13:25 [PATCH 0/4] arm64: dts: qcom: sc8280xp: disable PCIe perst pull downs Johan Hovold
@ 2024-07-19 13:25 ` Johan Hovold
2024-07-19 18:40 ` Konrad Dybcio
2024-07-19 13:25 ` [PATCH 2/4] arm64: dts: qcom: sc8280xp-crd: clean up PCIe2a pinctrl node Johan Hovold
` (3 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Johan Hovold @ 2024-07-19 13:25 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
devicetree, linux-kernel, Johan Hovold
Disable the PCIe perst pull-down resistors to save some power.
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
index 2897dff8e3bb..4c8ae13d25b9 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
+++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
@@ -885,7 +885,7 @@ perst-n-pins {
pins = "gpio143";
function = "gpio";
drive-strength = <2>;
- bias-pull-down;
+ bias-disable;
};
wake-n-pins {
@@ -908,7 +908,7 @@ perst-n-pins {
pins = "gpio151";
function = "gpio";
drive-strength = <2>;
- bias-pull-down;
+ bias-disable;
};
wake-n-pins {
@@ -931,7 +931,7 @@ perst-n-pins {
pins = "gpio141";
function = "gpio";
drive-strength = <2>;
- bias-pull-down;
+ bias-disable;
};
wake-n-pins {
--
2.44.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 2/4] arm64: dts: qcom: sc8280xp-crd: clean up PCIe2a pinctrl node
2024-07-19 13:25 [PATCH 0/4] arm64: dts: qcom: sc8280xp: disable PCIe perst pull downs Johan Hovold
2024-07-19 13:25 ` [PATCH 1/4] arm64: dts: qcom: sc8280xp-crd: " Johan Hovold
@ 2024-07-19 13:25 ` Johan Hovold
2024-07-19 18:40 ` Konrad Dybcio
2024-07-19 13:25 ` [PATCH 3/4] arm64: dts: qcom: sc8280xp-x13s: disable PCIe perst pull downs Johan Hovold
` (2 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Johan Hovold @ 2024-07-19 13:25 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
devicetree, linux-kernel, Johan Hovold
Clean up the PCIe2a pinctrl node indentation which should use tabs only.
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
index 4c8ae13d25b9..97bc717279a2 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
+++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
@@ -889,11 +889,11 @@ perst-n-pins {
};
wake-n-pins {
- pins = "gpio145";
- function = "gpio";
- drive-strength = <2>;
- bias-pull-up;
- };
+ pins = "gpio145";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-pull-up;
+ };
};
pcie3a_default: pcie3a-default-state {
--
2.44.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 3/4] arm64: dts: qcom: sc8280xp-x13s: disable PCIe perst pull downs
2024-07-19 13:25 [PATCH 0/4] arm64: dts: qcom: sc8280xp: disable PCIe perst pull downs Johan Hovold
2024-07-19 13:25 ` [PATCH 1/4] arm64: dts: qcom: sc8280xp-crd: " Johan Hovold
2024-07-19 13:25 ` [PATCH 2/4] arm64: dts: qcom: sc8280xp-crd: clean up PCIe2a pinctrl node Johan Hovold
@ 2024-07-19 13:25 ` Johan Hovold
2024-07-19 18:41 ` Konrad Dybcio
2024-07-19 13:25 ` [PATCH 4/4] arm64: dts: qcom: sc8280xp-x13s: clean up PCIe2a pinctrl node Johan Hovold
2024-07-29 3:58 ` [PATCH 0/4] arm64: dts: qcom: sc8280xp: disable PCIe perst pull downs Bjorn Andersson
4 siblings, 1 reply; 10+ messages in thread
From: Johan Hovold @ 2024-07-19 13:25 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
devicetree, linux-kernel, Johan Hovold
Disable the PCIe perst pull-down resistors to save some power.
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
index a1baf30b023c..5e5fdb085b88 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
+++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
@@ -1617,7 +1617,7 @@ perst-n-pins {
pins = "gpio143";
function = "gpio";
drive-strength = <2>;
- bias-pull-down;
+ bias-disable;
};
wake-n-pins {
@@ -1640,7 +1640,7 @@ perst-n-pins {
pins = "gpio151";
function = "gpio";
drive-strength = <2>;
- bias-pull-down;
+ bias-disable;
};
wake-n-pins {
@@ -1663,7 +1663,7 @@ perst-n-pins {
pins = "gpio141";
function = "gpio";
drive-strength = <2>;
- bias-pull-down;
+ bias-disable;
};
wake-n-pins {
--
2.44.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 4/4] arm64: dts: qcom: sc8280xp-x13s: clean up PCIe2a pinctrl node
2024-07-19 13:25 [PATCH 0/4] arm64: dts: qcom: sc8280xp: disable PCIe perst pull downs Johan Hovold
` (2 preceding siblings ...)
2024-07-19 13:25 ` [PATCH 3/4] arm64: dts: qcom: sc8280xp-x13s: disable PCIe perst pull downs Johan Hovold
@ 2024-07-19 13:25 ` Johan Hovold
2024-07-19 18:41 ` Konrad Dybcio
2024-07-29 3:58 ` [PATCH 0/4] arm64: dts: qcom: sc8280xp: disable PCIe perst pull downs Bjorn Andersson
4 siblings, 1 reply; 10+ messages in thread
From: Johan Hovold @ 2024-07-19 13:25 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
devicetree, linux-kernel, Johan Hovold
Clean up the PCIe2a pinctrl node indentation which should use tabs only.
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
.../boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
index 5e5fdb085b88..888f42ca230f 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
+++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
@@ -1621,11 +1621,11 @@ perst-n-pins {
};
wake-n-pins {
- pins = "gpio145";
- function = "gpio";
- drive-strength = <2>;
- bias-pull-up;
- };
+ pins = "gpio145";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-pull-up;
+ };
};
pcie3a_default: pcie3a-default-state {
--
2.44.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 0/4] arm64: dts: qcom: sc8280xp: disable PCIe perst pull downs
2024-07-19 13:25 [PATCH 0/4] arm64: dts: qcom: sc8280xp: disable PCIe perst pull downs Johan Hovold
` (3 preceding siblings ...)
2024-07-19 13:25 ` [PATCH 4/4] arm64: dts: qcom: sc8280xp-x13s: clean up PCIe2a pinctrl node Johan Hovold
@ 2024-07-29 3:58 ` Bjorn Andersson
4 siblings, 0 replies; 10+ messages in thread
From: Bjorn Andersson @ 2024-07-29 3:58 UTC (permalink / raw)
To: Konrad Dybcio, Johan Hovold
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm,
devicetree, linux-kernel
On Fri, 19 Jul 2024 15:25:18 +0200, Johan Hovold wrote:
> I noticed that these issues had been reproduced in x1e80100-crd. Ideally
> these should go into 6.11 as well.
>
> Johan
>
>
> Johan Hovold (4):
> arm64: dts: qcom: sc8280xp-crd: disable PCIe perst pull downs
> arm64: dts: qcom: sc8280xp-crd: clean up PCIe2a pinctrl node
> arm64: dts: qcom: sc8280xp-x13s: disable PCIe perst pull downs
> arm64: dts: qcom: sc8280xp-x13s: clean up PCIe2a pinctrl node
>
> [...]
Applied, thanks!
[1/4] arm64: dts: qcom: sc8280xp-crd: disable PCIe perst pull downs
commit: 7313361396d1db9c4d5a485ec5cf904792f5bd62
[2/4] arm64: dts: qcom: sc8280xp-crd: clean up PCIe2a pinctrl node
commit: 60a99c4c10d41f4bbb54ec8a70dbdbc98eff18eb
[3/4] arm64: dts: qcom: sc8280xp-x13s: disable PCIe perst pull downs
commit: a59e55237c477c7003f06c0297a80510434b3fe6
[4/4] arm64: dts: qcom: sc8280xp-x13s: clean up PCIe2a pinctrl node
commit: dfd06c0e7ff7af10b34fbd6526a08e078a1e876b
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 10+ messages in thread