devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Kaustabh Chakraborty <kauschluss@disroot.org>
Cc: Jonathan Cameron <jic23@kernel.org>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 3/3] dt-bindings: iio: light: stk33xx: add compatible for stk3013
Date: Mon, 22 Jul 2024 18:05:01 +0100	[thread overview]
Message-ID: <20240722-affection-abstract-57fb331782e3@spud> (raw)
In-Reply-To: <20240721-stk3310-v3-3-98fcb6f551a1@disroot.org>

[-- Attachment #1: Type: text/plain, Size: 1874 bytes --]

On Sun, Jul 21, 2024 at 03:44:31PM +0530, Kaustabh Chakraborty wrote:
> STK3013 is a proximity sensor by Sensortek, bearing chipid of 0x31. Despite
> being marketed as a proximity sensor, it also appears to have ambient
> light sensing capabilities.
> 
> The part is fully compatible with the existing implementation of the
> device driver. Add the compatible string of stk3013 to the existing
> list, with a fallback of stk3310.
> 
> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
> ---
>  Documentation/devicetree/bindings/iio/light/stk33xx.yaml | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/light/stk33xx.yaml b/Documentation/devicetree/bindings/iio/light/stk33xx.yaml
> index f6e22dc9814a..d5f6b622c8da 100644
> --- a/Documentation/devicetree/bindings/iio/light/stk33xx.yaml
> +++ b/Documentation/devicetree/bindings/iio/light/stk33xx.yaml
> @@ -18,10 +18,15 @@ allOf:
>  
>  properties:
>    compatible:
> -    enum:
> -      - sensortek,stk3310
> -      - sensortek,stk3311
> -      - sensortek,stk3335
> +    oneOf:
> +      - enum:
> +        - sensortek,stk3310
> +        - sensortek,stk3311
> +        - sensortek,stk3335
> +      - items:
> +        - enum:
> +          - sensortek,stk3013
> +        - const: sensortek,stk3310
>  

./Documentation/devicetree/bindings/iio/light/stk33xx.yaml:23:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
./Documentation/devicetree/bindings/iio/light/stk33xx.yaml:27:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
./Documentation/devicetree/bindings/iio/light/stk33xx.yaml:28:11: [warning] wrong indentation: expected 12 but found 10 (indentation)

From dt_binding_check, please fix.

>    reg:
>      maxItems: 1
> 
> -- 
> 2.45.2
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2024-07-22 17:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-21 10:14 [PATCH v3 0/3] iio: light: stk3310: stk3013 support Kaustabh Chakraborty
2024-07-21 10:14 ` [PATCH v3 1/3] iio: light: stk3310: relax chipid check warning Kaustabh Chakraborty
2024-07-21 10:14 ` [PATCH v3 2/3] iio: light: stk3310: add support for stk3013 Kaustabh Chakraborty
2024-07-21 10:14 ` [PATCH v3 3/3] dt-bindings: iio: light: stk33xx: add compatible " Kaustabh Chakraborty
2024-07-22 17:05   ` Conor Dooley [this message]
2024-07-26 18:52     ` Kaustabh Chakraborty
2024-07-22 18:41   ` Rob Herring (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240722-affection-abstract-57fb331782e3@spud \
    --to=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=kauschluss@disroot.org \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).