[PATCH v2 0/5] arm64: dts: qcom: improve Lenovo Miix 630 support

[PATCH v2 0/5] arm64: dts: qcom: improve Lenovo Miix 630 support

[Dmitry Baryshkov]

Enable some low-hanging fruits growing on the Lenovo Miix 630 laptop,
but not being enabled for some reason.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
Changes in v2:
- Fixed touchscreen node name (Konrad)
- Dropped unused label (Konrad)
- Dropped wakeup-source for now (Konrad)
- Dropped extra empty line in pinconf (Konrad)
- Added debounce-interval to VolUp (Konrad)
- Fixed pinctrl properties order (Konrad)
- Added empty lines before status properties (Konrad)
- Added linux,can-disable to VolUp
- Added wifi calibration variant
- Link to v1: https://lore.kernel.org/r/20240722-miix630-support-v1-0-a6483cfe8674@linaro.org

---
Dmitry Baryshkov (5):
      arm64: dts: qcom: msm8998-lenovo-miix-630: enable touchscreen
      arm64: dts: qcom: msm8998-lenovo-miix-630: enable aDSP and SLPI
      arm64: dts: qcom: msm8998-lenovo-miix-630: enable VolumeUp button
      arm64: dts: qcom: msm8998-clamshell: enable resin/VolDown
      arm64: dts: qcom: msm8998-lenovo-miix-630: add WiFi calibration variant

 arch/arm64/boot/dts/qcom/msm8998-clamshell.dtsi    |  6 ++
 .../boot/dts/qcom/msm8998-lenovo-miix-630.dts      | 68 ++++++++++++++++++++++
 2 files changed, 74 insertions(+)
---
base-commit: 797012914d2d031430268fe512af0ccd7d8e46ef
change-id: 20240722-miix630-support-33b3acc3a396

Best regards,
-- 
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

[PATCH v2 1/5] arm64: dts: qcom: msm8998-lenovo-miix-630: enable touchscreen

[Dmitry Baryshkov]

There is no point in keeping touchscreen disabled, enable corresponding
i2c-hid device.

04F3:2608 Touchscreen as /devices/platform/soc@0/c179000.i2c/i2c-0/0-0010/0018:04F3:2608.0001/input/input1
04F3:2608 as /devices/platform/soc@0/c179000.i2c/i2c-0/0-0010/0018:04F3:2608.0001/input/input2
04F3:2608 as /devices/platform/soc@0/c179000.i2c/i2c-0/0-0010/0018:04F3:2608.0001/input/input3
04F3:2608 Stylus as /devices/platform/soc@0/c179000.i2c/i2c-0/0-0010/0018:04F3:2608.0001/input/input4

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 .../boot/dts/qcom/msm8998-lenovo-miix-630.dts      | 25 ++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts b/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts
index a105143bee4a..133999a7ed2a 100644
--- a/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts
+++ b/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts
@@ -11,6 +11,22 @@ / {
 	chassis-type = "convertible";
 };
 
+&blsp1_i2c5 {
+	clock-frequency = <400000>;
+	status = "okay";
+
+	touchscreen@10 {
+		compatible = "hid-over-i2c";
+		reg = <0x10>;
+		hid-descr-addr = <0x1>;
+
+		interrupts-extended = <&tlmm 125 IRQ_TYPE_LEVEL_LOW>;
+
+		pinctrl-0 = <&i2c5_hid_active>;
+		pinctrl-names = "default";
+	};
+};
+
 &blsp1_i2c6 {
 	status = "okay";
 
@@ -35,3 +51,12 @@ &remoteproc_mss {
 &sdhc2 {
 	cd-gpios = <&tlmm 95 GPIO_ACTIVE_HIGH>;
 };
+
+&tlmm {
+	i2c5_hid_active: i2c5-hid-active-state {
+		pins = "gpio125";
+		function = "gpio";
+		bias-pull-up;
+		drive-strength = <2>;
+	};
+};

-- 
2.39.2

Re: [PATCH v2 1/5] arm64: dts: qcom: msm8998-lenovo-miix-630: enable touchscreen

[Jeffrey Hugo]

On 7/23/2024 5:28 AM, Dmitry Baryshkov wrote:
> There is no point in keeping touchscreen disabled, enable corresponding
> i2c-hid device.
> 
> 04F3:2608 Touchscreen as /devices/platform/soc@0/c179000.i2c/i2c-0/0-0010/0018:04F3:2608.0001/input/input1
> 04F3:2608 as /devices/platform/soc@0/c179000.i2c/i2c-0/0-0010/0018:04F3:2608.0001/input/input2
> 04F3:2608 as /devices/platform/soc@0/c179000.i2c/i2c-0/0-0010/0018:04F3:2608.0001/input/input3
> 04F3:2608 Stylus as /devices/platform/soc@0/c179000.i2c/i2c-0/0-0010/0018:04F3:2608.0001/input/input4
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>

[PATCH v2 2/5] arm64: dts: qcom: msm8998-lenovo-miix-630: enable aDSP and SLPI

[Dmitry Baryshkov]

Enable two other DSP instances on this platofm, aDSP and SLPI.

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts b/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts
index 133999a7ed2a..2430f17b2356 100644
--- a/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts
+++ b/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts
@@ -43,11 +43,23 @@ keyboard@3a {
 	};
 };
 
+&remoteproc_adsp {
+	firmware-name = "qcom/msm8998/LENOVO/81F1/qcadsp8998.mbn";
+
+	status = "okay";
+};
+
 &remoteproc_mss {
 	firmware-name = "qcom/msm8998/LENOVO/81F1/qcdsp1v28998.mbn",
 			"qcom/msm8998/LENOVO/81F1/qcdsp28998.mbn";
 };
 
+&remoteproc_slpi {
+	firmware-name = "qcom/msm8998/LENOVO/81F1/qcslpi8998.mbn";
+
+	status = "okay";
+};
+
 &sdhc2 {
 	cd-gpios = <&tlmm 95 GPIO_ACTIVE_HIGH>;
 };

-- 
2.39.2

Re: [PATCH v2 2/5] arm64: dts: qcom: msm8998-lenovo-miix-630: enable aDSP and SLPI

[Jeffrey Hugo]

On 7/23/2024 5:28 AM, Dmitry Baryshkov wrote:
> Enable two other DSP instances on this platofm, aDSP and SLPI.
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>

[PATCH v2 3/5] arm64: dts: qcom: msm8998-lenovo-miix-630: enable VolumeUp button

[Dmitry Baryshkov]

Add gpio-keys device, responsible for a single button: Volume Up.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 .../boot/dts/qcom/msm8998-lenovo-miix-630.dts      | 27 ++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts b/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts
index 2430f17b2356..fad5f390171a 100644
--- a/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts
+++ b/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts
@@ -3,12 +3,29 @@
 
 /dts-v1/;
 
+#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
 #include "msm8998-clamshell.dtsi"
 
 / {
 	model = "Lenovo Miix 630";
 	compatible = "lenovo,miix-630", "qcom,msm8998";
 	chassis-type = "convertible";
+
+	gpio-keys {
+		compatible = "gpio-keys";
+		autorepeat;
+
+		pinctrl-0 = <&vol_up_pin_a>;
+		pinctrl-names = "default";
+
+		key-vol-up {
+			label = "Volume Up";
+			gpios = <&pm8998_gpios 6 GPIO_ACTIVE_LOW>;
+			linux,code = <KEY_VOLUMEUP>;
+			debounce-interval = <15>;
+			linux,can-disable;
+		};
+	};
 };
 
 &blsp1_i2c5 {
@@ -43,6 +60,16 @@ keyboard@3a {
 	};
 };
 
+&pm8998_gpios {
+	vol_up_pin_a: vol-up-active-state {
+		pins = "gpio6";
+		function = "normal";
+		input-enable;
+		bias-pull-up;
+		qcom,drive-strength = <PMIC_GPIO_STRENGTH_NO>;
+	};
+};
+
 &remoteproc_adsp {
 	firmware-name = "qcom/msm8998/LENOVO/81F1/qcadsp8998.mbn";
 

-- 
2.39.2

Re: [PATCH v2 3/5] arm64: dts: qcom: msm8998-lenovo-miix-630: enable VolumeUp button

[Konrad Dybcio]

On 23.07.2024 1:28 PM, Dmitry Baryshkov wrote:
> Add gpio-keys device, responsible for a single button: Volume Up.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---


Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad

Re: [PATCH v2 3/5] arm64: dts: qcom: msm8998-lenovo-miix-630: enable VolumeUp button

[Jeffrey Hugo]

On 7/23/2024 5:28 AM, Dmitry Baryshkov wrote:
> Add gpio-keys device, responsible for a single button: Volume Up.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>

[PATCH v2 4/5] arm64: dts: qcom: msm8998-clamshell: enable resin/VolDown

[Dmitry Baryshkov]

Let resin device generate the VolumeDown key.

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 arch/arm64/boot/dts/qcom/msm8998-clamshell.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/msm8998-clamshell.dtsi b/arch/arm64/boot/dts/qcom/msm8998-clamshell.dtsi
index 3b7172aa4037..9a3fe610c937 100644
--- a/arch/arm64/boot/dts/qcom/msm8998-clamshell.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8998-clamshell.dtsi
@@ -128,6 +128,12 @@ pm8005_s1: s1 { /* VDD_GFX supply */
 	};
 };
 
+&pm8998_resin {
+	linux,code = <KEY_VOLUMEDOWN>;
+
+	status = "okay";
+};
+
 &qusb2phy {
 	status = "okay";
 

-- 
2.39.2

Re: [PATCH v2 4/5] arm64: dts: qcom: msm8998-clamshell: enable resin/VolDown

[Jeffrey Hugo]

On 7/23/2024 5:28 AM, Dmitry Baryshkov wrote:
> Let resin device generate the VolumeDown key.
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>

[PATCH v2 5/5] arm64: dts: qcom: msm8998-lenovo-miix-630: add WiFi calibration variant

[Dmitry Baryshkov]

As most other board Miix uses board-id = 0xff, so define calibration
variant to distinguish it from other devices with the same chip_id.

qmi chip_id 0x30214 chip_family 0x4001 board_id 0xff soc_id 0x40010002

Cc: Kalle Valo <kvalo@kernel.org>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts b/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts
index fad5f390171a..901f6ac0084d 100644
--- a/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts
+++ b/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts
@@ -99,3 +99,7 @@ i2c5_hid_active: i2c5-hid-active-state {
 		drive-strength = <2>;
 	};
 };
+
+&wifi {
+	qcom,ath10k-calibration-variant = "Lenovo_Miix630";
+};

-- 
2.39.2

Re: [PATCH v2 5/5] arm64: dts: qcom: msm8998-lenovo-miix-630: add WiFi calibration variant

[Konrad Dybcio]

On 23.07.2024 1:28 PM, Dmitry Baryshkov wrote:
> As most other board Miix uses board-id = 0xff, so define calibration
> variant to distinguish it from other devices with the same chip_id.
> 
> qmi chip_id 0x30214 chip_family 0x4001 board_id 0xff soc_id 0x40010002
> 
> Cc: Kalle Valo <kvalo@kernel.org>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad

Re: [PATCH v2 5/5] arm64: dts: qcom: msm8998-lenovo-miix-630: add WiFi calibration variant

[Jeffrey Hugo]

On 7/23/2024 5:28 AM, Dmitry Baryshkov wrote:
> As most other board Miix uses board-id = 0xff, so define calibration
> variant to distinguish it from other devices with the same chip_id.
> 
> qmi chip_id 0x30214 chip_family 0x4001 board_id 0xff soc_id 0x40010002
> 
> Cc: Kalle Valo <kvalo@kernel.org>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>

Re: [PATCH v2 0/5] arm64: dts: qcom: improve Lenovo Miix 630 support

[Bjorn Andersson]

On Tue, 23 Jul 2024 14:28:27 +0300, Dmitry Baryshkov wrote:
> Enable some low-hanging fruits growing on the Lenovo Miix 630 laptop,
> but not being enabled for some reason.
> 
> 

Applied, thanks!

[1/5] arm64: dts: qcom: msm8998-lenovo-miix-630: enable touchscreen
      commit: 50b2a9c39661e57d9bbdaedd10890279d3cc17d1
[2/5] arm64: dts: qcom: msm8998-lenovo-miix-630: enable aDSP and SLPI
      commit: 08cc19ba96b54ee741d67698bbeccd5ad1732043
[3/5] arm64: dts: qcom: msm8998-lenovo-miix-630: enable VolumeUp button
      commit: 31a31cd74de6a2408d907630a7294cadc7e32049
[4/5] arm64: dts: qcom: msm8998-clamshell: enable resin/VolDown
      commit: ac6adde8d540c5db12f903c9cb439921df4f4966
[5/5] arm64: dts: qcom: msm8998-lenovo-miix-630: add WiFi calibration variant
      commit: 1a24c290a593f65954df3c7d9ea1d5410f2f1544

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>