* [PATCH] arm64: dts: qcom: msm8916-samsung-fortuna: Enable the touchkeys
@ 2024-07-23 13:12 Raymond Hackley
2024-07-23 13:13 ` Konrad Dybcio
0 siblings, 1 reply; 5+ messages in thread
From: Raymond Hackley @ 2024-07-23 13:12 UTC (permalink / raw)
To: linux-kernel
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Stephan Gerhold, Nikita Travkin, linux-arm-msm,
devicetree, phone-devel, ~postmarketos/upstreaming
The phone needs the touchkeys to be enabled so the sense lines of the
touch controller are mapped properly. Otherwise the touchscreen is not
mapped to the display properly.
Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
---
arch/arm64/boot/dts/qcom/msm8916-samsung-fortuna-common.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-fortuna-common.dtsi b/arch/arm64/boot/dts/qcom/msm8916-samsung-fortuna-common.dtsi
index 81b3e0760154..7a7e99b015d9 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-samsung-fortuna-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-fortuna-common.dtsi
@@ -262,6 +262,8 @@ touchscreen: touchscreen@20 {
pinctrl-0 = <&tsp_int_default>;
pinctrl-names = "default";
+
+ linux,keycodes = <KEY_APPSELECT KEY_BACK>;
};
};
--
2.39.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: msm8916-samsung-fortuna: Enable the touchkeys
2024-07-23 13:12 [PATCH] arm64: dts: qcom: msm8916-samsung-fortuna: Enable the touchkeys Raymond Hackley
@ 2024-07-23 13:13 ` Konrad Dybcio
2024-07-23 13:39 ` Raymond Hackley
0 siblings, 1 reply; 5+ messages in thread
From: Konrad Dybcio @ 2024-07-23 13:13 UTC (permalink / raw)
To: Raymond Hackley, linux-kernel
Cc: Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Stephan Gerhold, Nikita Travkin, linux-arm-msm, devicetree,
phone-devel, ~postmarketos/upstreaming
On 23.07.2024 3:12 PM, Raymond Hackley wrote:
> The phone needs the touchkeys to be enabled so the sense lines of the
> touch controller are mapped properly. Otherwise the touchscreen is not
> mapped to the display properly.
>
> Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
> ---
Fixes?
Konrad
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: msm8916-samsung-fortuna: Enable the touchkeys
2024-07-23 13:13 ` Konrad Dybcio
@ 2024-07-23 13:39 ` Raymond Hackley
2024-07-23 13:42 ` Konrad Dybcio
0 siblings, 1 reply; 5+ messages in thread
From: Raymond Hackley @ 2024-07-23 13:39 UTC (permalink / raw)
To: konrad.dybcio
Cc: andersson, conor+dt, devicetree, krzysztof.kozlowski+dt,
linux-arm-msm, linux-kernel, nikita, phone-devel, raymondhackley,
robh+dt, stephan, ~postmarketos/upstreaming
> Fixes?
>
> Konrad
Hi Konrad,
the issue is not reported or discussed on lkml, so there is no thread to fix?
Regards,
Raymond
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: msm8916-samsung-fortuna: Enable the touchkeys
2024-07-23 13:39 ` Raymond Hackley
@ 2024-07-23 13:42 ` Konrad Dybcio
2024-07-24 14:26 ` Raymond Hackley
0 siblings, 1 reply; 5+ messages in thread
From: Konrad Dybcio @ 2024-07-23 13:42 UTC (permalink / raw)
To: Raymond Hackley
Cc: andersson, conor+dt, devicetree, krzysztof.kozlowski+dt,
linux-arm-msm, linux-kernel, nikita, phone-devel, robh+dt,
stephan, ~postmarketos/upstreaming
On 23.07.2024 3:39 PM, Raymond Hackley wrote:
>> Fixes?
>>
>> Konrad
>
> Hi Konrad,
>
> the issue is not reported or discussed on lkml, so there is no thread to fix?
See the "In case your patch fixes a bug.." paragraph in:
https://docs.kernel.org/process/submitting-patches.html
>
> Regards,
> Raymond
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: msm8916-samsung-fortuna: Enable the touchkeys
2024-07-23 13:42 ` Konrad Dybcio
@ 2024-07-24 14:26 ` Raymond Hackley
0 siblings, 0 replies; 5+ messages in thread
From: Raymond Hackley @ 2024-07-24 14:26 UTC (permalink / raw)
To: konrad.dybcio
Cc: andersson, conor+dt, devicetree, krzysztof.kozlowski+dt,
linux-arm-msm, linux-kernel, nikita, phone-devel, raymondhackley,
robh+dt, stephan, ~postmarketos/upstreaming
> See the "In case your patch fixes a bug.." paragraph in:
>
> https://docs.kernel.org/process/submitting-patches.html
Hi Konrad,
the point is not to fix a bug, but to add touchkeys support instead.
I will reword the patch when it's confusing.
Regards,
Raymond
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-07-24 14:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-23 13:12 [PATCH] arm64: dts: qcom: msm8916-samsung-fortuna: Enable the touchkeys Raymond Hackley
2024-07-23 13:13 ` Konrad Dybcio
2024-07-23 13:39 ` Raymond Hackley
2024-07-23 13:42 ` Konrad Dybcio
2024-07-24 14:26 ` Raymond Hackley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).