* [PATCH] dt-bindings: iio: adc: ad7192: Fix 'single-channel' constraints
@ 2024-07-23 23:09 Rob Herring (Arm)
2024-07-24 16:42 ` Conor Dooley
2024-07-26 18:52 ` Rob Herring (Arm)
0 siblings, 2 replies; 4+ messages in thread
From: Rob Herring (Arm) @ 2024-07-23 23:09 UTC (permalink / raw)
To: Lars-Peter Clausen, Michael Hennerich, Alisa-Dariana Roman,
Jonathan Cameron, Krzysztof Kozlowski, Conor Dooley
Cc: Michael Hennerich, Alisa-Dariana Roman, Conor Dooley,
Jonathan Cameron, linux-iio, devicetree, linux-kernel
The 'single-channel' property is an uint32, not an array, so 'items' is
an incorrect constraint. This didn't matter until dtschema recently
changed how properties are decoded. This results in this warning:
Documentation/devicetree/bindings/iio/adc/adi,ad7192.example.dtb: adc@0: \
channel@1:single-channel: 1 is not of type 'array'
Fixes: caf7b7632b8d ("dt-bindings: iio: adc: ad7192: Add AD7194 support")
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml
index a03da9489ed9..190889c7b62a 100644
--- a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml
@@ -120,9 +120,8 @@ patternProperties:
description:
Positive input can be connected to pins AIN1 to AIN16 by choosing the
appropriate value from 1 to 16. Negative input is connected to AINCOM.
- items:
- minimum: 1
- maximum: 16
+ minimum: 1
+ maximum: 16
oneOf:
- required:
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: iio: adc: ad7192: Fix 'single-channel' constraints
2024-07-23 23:09 [PATCH] dt-bindings: iio: adc: ad7192: Fix 'single-channel' constraints Rob Herring (Arm)
@ 2024-07-24 16:42 ` Conor Dooley
2024-07-26 18:52 ` Rob Herring (Arm)
1 sibling, 0 replies; 4+ messages in thread
From: Conor Dooley @ 2024-07-24 16:42 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: Lars-Peter Clausen, Michael Hennerich, Alisa-Dariana Roman,
Jonathan Cameron, Krzysztof Kozlowski, Conor Dooley,
Alisa-Dariana Roman, Conor Dooley, Jonathan Cameron, linux-iio,
devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1478 bytes --]
On Tue, Jul 23, 2024 at 06:09:03PM -0500, Rob Herring (Arm) wrote:
> The 'single-channel' property is an uint32, not an array, so 'items' is
> an incorrect constraint. This didn't matter until dtschema recently
> changed how properties are decoded. This results in this warning:
>
> Documentation/devicetree/bindings/iio/adc/adi,ad7192.example.dtb: adc@0: \
> channel@1:single-channel: 1 is not of type 'array'
>
> Fixes: caf7b7632b8d ("dt-bindings: iio: adc: ad7192: Add AD7194 support")
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml
> index a03da9489ed9..190889c7b62a 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml
> @@ -120,9 +120,8 @@ patternProperties:
> description:
> Positive input can be connected to pins AIN1 to AIN16 by choosing the
> appropriate value from 1 to 16. Negative input is connected to AINCOM.
> - items:
> - minimum: 1
> - maximum: 16
> + minimum: 1
> + maximum: 16
>
> oneOf:
> - required:
> --
> 2.43.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: iio: adc: ad7192: Fix 'single-channel' constraints
2024-07-23 23:09 [PATCH] dt-bindings: iio: adc: ad7192: Fix 'single-channel' constraints Rob Herring (Arm)
2024-07-24 16:42 ` Conor Dooley
@ 2024-07-26 18:52 ` Rob Herring (Arm)
2024-07-27 15:10 ` Jonathan Cameron
1 sibling, 1 reply; 4+ messages in thread
From: Rob Herring (Arm) @ 2024-07-26 18:52 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: linux-kernel, Alisa-Dariana Roman, Michael Hennerich, devicetree,
Krzysztof Kozlowski, Conor Dooley, Conor Dooley, linux-iio,
Jonathan Cameron, Michael Hennerich, Alisa-Dariana Roman,
Jonathan Cameron, Lars-Peter Clausen
On Tue, 23 Jul 2024 18:09:03 -0500, Rob Herring (Arm) wrote:
> The 'single-channel' property is an uint32, not an array, so 'items' is
> an incorrect constraint. This didn't matter until dtschema recently
> changed how properties are decoded. This results in this warning:
>
> Documentation/devicetree/bindings/iio/adc/adi,ad7192.example.dtb: adc@0: \
> channel@1:single-channel: 1 is not of type 'array'
>
> Fixes: caf7b7632b8d ("dt-bindings: iio: adc: ad7192: Add AD7194 support")
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
I have other fixes for rc1 already, so I've applied this one.
Rob
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: iio: adc: ad7192: Fix 'single-channel' constraints
2024-07-26 18:52 ` Rob Herring (Arm)
@ 2024-07-27 15:10 ` Jonathan Cameron
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2024-07-27 15:10 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: linux-kernel, Alisa-Dariana Roman, Michael Hennerich, devicetree,
Krzysztof Kozlowski, Conor Dooley, Conor Dooley, linux-iio,
Alisa-Dariana Roman, Jonathan Cameron, Lars-Peter Clausen
On Fri, 26 Jul 2024 13:52:58 -0500
"Rob Herring (Arm)" <robh@kernel.org> wrote:
> On Tue, 23 Jul 2024 18:09:03 -0500, Rob Herring (Arm) wrote:
> > The 'single-channel' property is an uint32, not an array, so 'items' is
> > an incorrect constraint. This didn't matter until dtschema recently
> > changed how properties are decoded. This results in this warning:
> >
> > Documentation/devicetree/bindings/iio/adc/adi,ad7192.example.dtb: adc@0: \
> > channel@1:single-channel: 1 is not of type 'array'
> >
> > Fixes: caf7b7632b8d ("dt-bindings: iio: adc: ad7192: Add AD7194 support")
> > Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> > ---
> > Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml | 5 ++---
> > 1 file changed, 2 insertions(+), 3 deletions(-)
> >
>
> I have other fixes for rc1 already, so I've applied this one.
>
> Rob
Cool
For the record (no need to add to patch!)
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-07-27 15:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-23 23:09 [PATCH] dt-bindings: iio: adc: ad7192: Fix 'single-channel' constraints Rob Herring (Arm)
2024-07-24 16:42 ` Conor Dooley
2024-07-26 18:52 ` Rob Herring (Arm)
2024-07-27 15:10 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).