Devicetree
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: pierre-henry.moussay@microchip.com
Cc: Conor Dooley <conor.dooley@microchip.com>,
	Daire McNamara <daire.mcnamara@microchip.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	linux-riscv@lists.infradead.org, linux-gpio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/17] dt-bindings: gpio: mpfs-gpio: Add PIC64GX GPIO compatibility
Date: Thu, 25 Jul 2024 15:25:33 +0100	[thread overview]
Message-ID: <20240725-prevalent-marry-66670630061f@spud> (raw)
In-Reply-To: <20240725121609.13101-6-pierre-henry.moussay@microchip.com>

[-- Attachment #1: Type: text/plain, Size: 1658 bytes --]

On Thu, Jul 25, 2024 at 01:15:57PM +0100, pierre-henry.moussay@microchip.com wrote:
> From: Pierre-Henry Moussay <pierre-henry.moussay@microchip.com>
> 
> PIC64GX GPIO is compatible with mpfs-gpio driver
> 
> Signed-off-by: Pierre-Henry Moussay <pierre-henry.moussay@microchip.com>
> ---
>  .../bindings/gpio/microchip,mpfs-gpio.yaml       | 16 +++++++++++-----
>  1 file changed, 11 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/gpio/microchip,mpfs-gpio.yaml b/Documentation/devicetree/bindings/gpio/microchip,mpfs-gpio.yaml
> index d61569b3f15b..fdce88374a91 100644
> --- a/Documentation/devicetree/bindings/gpio/microchip,mpfs-gpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/microchip,mpfs-gpio.yaml
> @@ -11,10 +11,14 @@ maintainers:
>  
>  properties:
>    compatible:
> -    items:
> -      - enum:
> -          - microchip,mpfs-gpio
> -          - microchip,coregpio-rtl-v3
> +    oneOf:
> +      - items:
> +          - const: microchip,pic64gx-gpio
> +          - const: microchip,mpfs-gpio
> +      - items:
> +          - enum:
> +              - microchip,mpfs-gpio
> +              - microchip,coregpio-rtl-v3
>  
>    reg:
>      maxItems: 1
> @@ -69,7 +73,9 @@ allOf:
>        properties:
>          compatible:
>            contains:
> -            const: microchip,mpfs-gpio
> +            enum:
> +              - microchip,mpfs-gpio
> +              - microchip,pic64gx-gpio

This hunk should not be needed, given you have an mpfs-gpio fallback.

Thanks,
Conor.

>      then:
>        required:
>          - interrupts
> -- 
> 2.30.2
> 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2024-07-25 14:25 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20240725121609.13101-1-pierre-henry.moussay@microchip.com>
2024-07-25 12:15 ` [PATCH 01/17] dt-bindings: can: mpfs: add PIC64GX CAN compatibility pierre-henry.moussay
2024-08-05 15:17   ` Marc Kleine-Budde
2024-07-25 12:15 ` [PATCH 02/17] dt-bindings: usb: add PIC64GX compatibility to mpfs-musb driver pierre-henry.moussay
2024-07-25 12:15 ` [PATCH 03/17] dt-bindings: mbox: add PIC64GX mailbox compatibility to MPFS mailbox pierre-henry.moussay
2024-07-25 14:16   ` Conor Dooley
2024-07-25 12:15 ` [PATCH 04/17] dt-bindings: spi: add PIC64GX SPI/QSPI compatibility to MPFS SPI/QSPI bindings pierre-henry.moussay
2024-07-25 12:15 ` [PATCH 05/17] dt-bindings: gpio: mpfs-gpio: Add PIC64GX GPIO compatibility pierre-henry.moussay
2024-07-25 14:25   ` Conor Dooley [this message]
2024-07-25 12:15 ` [PATCH 06/17] dt-bindings: riscv: sifive-l2: add a PIC64GX compatible pierre-henry.moussay
2024-07-25 14:11   ` Conor Dooley
2024-07-25 12:15 ` [PATCH 07/17] dt-bindings: clock: mpfs-ccc: Add PIC64GX compatibility pierre-henry.moussay
2024-07-25 14:19   ` Conor Dooley
2024-07-25 12:16 ` [PATCH 08/17] dt-bindings: clock: mpfs-clkcfg: " pierre-henry.moussay
2024-07-25 14:22   ` Conor Dooley
2024-07-25 12:16 ` [PATCH 09/17] dt-bindings: dma: sifive pdma: Add PIC64GX to compatibles pierre-henry.moussay
2024-07-25 12:16 ` [PATCH 10/17] dt-bindings: i2c: microchip: corei2c: Add PIC64GX as compatible with driver pierre-henry.moussay
2024-07-25 14:24   ` Conor Dooley
2024-07-25 12:16 ` [PATCH 11/17] dt-bindings: mmc: cdns: document Microchip PIC64GX MMC/SDHCI controller pierre-henry.moussay
2024-07-25 12:16 ` [PATCH 12/17] dt-bindings: net: cdns,macb: Add PIC64GX compatibility pierre-henry.moussay
2024-07-25 12:16 ` [PATCH 13/17] dt-bindings: rtc: mfps-rtc: " pierre-henry.moussay
2024-07-25 12:16 ` [PATCH 14/17] dt-bindings: soc: microchip: mpfs-sys-controller: " pierre-henry.moussay
2024-07-25 14:34   ` Conor Dooley
2024-07-25 12:16 ` [PATCH 15/17] dt-bindings: clk: microchip: Add Microchip PIC64GX host binding pierre-henry.moussay
2024-07-25 14:18   ` Conor Dooley
2024-07-25 12:16 ` [PATCH 16/17] dt-bindings: riscv: microchip: document the PIC64GX curiosity kit pierre-henry.moussay
2024-07-25 12:16 ` [PATCH 17/17] riscv: dts: microchip: add PIC64GX Curiosity Kit dts pierre-henry.moussay
2024-07-25 14:15   ` Emil Renner Berthing
2024-07-25 14:35   ` Conor Dooley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240725-prevalent-marry-66670630061f@spud \
    --to=conor@kernel.org \
    --cc=brgl@bgdev.pl \
    --cc=conor.dooley@microchip.com \
    --cc=daire.mcnamara@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=pierre-henry.moussay@microchip.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox