From: Lee Jones <lee@kernel.org>
To: Marek Vasut <marex@denx.de>
Cc: devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Pavel Machek <pavel@ucw.cz>, Rob Herring <robh@kernel.org>,
linux-leds@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
netdev@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: leds: Document "netdev" trigger
Date: Thu, 25 Jul 2024 09:50:42 +0100 [thread overview]
Message-ID: <20240725085042.GC501857@google.com> (raw)
In-Reply-To: <20240708114653.18566-1-marex@denx.de>
Cc: Andrew and netdev
On Mon, 08 Jul 2024, Marek Vasut wrote:
> Document the "netdev" trigger which is used to control LEDs by
> network device activity. This is an existing trigger used in
> existing DTs, document it so validation of those DTs would pass.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Lee Jones <lee@kernel.org>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Rob Herring <robh@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: linux-leds@vger.kernel.org
> ---
> V2: Expand the commit message slightly
> ---
> Documentation/devicetree/bindings/leds/common.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
> index 8a3c2398b10ce..bf9a101e4d420 100644
> --- a/Documentation/devicetree/bindings/leds/common.yaml
> +++ b/Documentation/devicetree/bindings/leds/common.yaml
> @@ -113,6 +113,8 @@ properties:
> # LED indicates NAND memory activity (deprecated),
> # in new implementations use "mtd"
> - nand-disk
> + # LED indicates network activity
> + - netdev
netdev is the description of the network development ML/repo, right?
Seems like an odd name for an OS agnostic property?
> # No trigger assigned to the LED. This is the default mode
> # if trigger is absent
> - none
> --
> 2.43.0
>
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-07-25 8:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-08 11:46 [PATCH v2] dt-bindings: leds: Document "netdev" trigger Marek Vasut
2024-07-09 9:06 ` Krzysztof Kozlowski
2024-07-25 8:50 ` Lee Jones [this message]
2024-07-25 12:37 ` Andrew Lunn
2024-08-01 12:53 ` Lee Jones
2024-08-01 13:03 ` Andrew Lunn
2024-08-05 13:56 ` Lee Jones
2024-08-05 22:56 ` Andrew Lunn
2024-08-16 15:47 ` Lee Jones
2024-08-16 15:53 ` (subset) " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240725085042.GC501857@google.com \
--to=lee@kernel.org \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=marex@denx.de \
--cc=netdev@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).