Re: [PATCH v5 6/9] dt-bindings: iio: add vref support to sd modulator

[Rob Herring <robh@kernel.org>]

On Wed, Jul 24, 2024 at 05:36:34PM +0200, Olivier Moysan wrote:
> Allow to specify the reference voltage used by the SD modulator.
> When the SD modulator is defined as an IIO backend, the reference
> voltage can be used to evaluate scaling information of the IIO device.
> The reference voltage is not used otherwise.

You haven't tested that this works. Add 'vref-supply' to the example.

> 
> Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com>
> ---
>  .../bindings/iio/adc/sigma-delta-modulator.yaml           | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.yaml b/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.yaml
> index b245971fecb0..ff04ae08f264 100644
> --- a/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.yaml
> @@ -31,6 +31,14 @@ anyOf:
>    - required: ['#io-backend-cells']
>    - required: ['#io-channel-cells']
>  
> +if:
> +  required:
> +    - '#io-backend-cells'
> +then:
> +  properties:
> +    vref-supply:
> +      description: Phandle to the vref input analog reference voltage.
> +

Do this instead:

properties:
  vref-supply:
    ...

dependencies:
  vref-supply: [ '#io-backend-cells' ]

>  additionalProperties: false
>  
>  examples:
> -- 
> 2.25.1
>