From: Chris Morgan <macroalpha82@gmail.com>
To: linux-rockchip@lists.infradead.org
Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
jagan@edgeble.ai, andyshrk@163.com, jonas@kwiboo.se,
sre@kernel.org, t.schramm@manjaro.org, heiko@sntech.de,
conor+dt@kernel.org, krzk+dt@kernel.org, robh@kernel.org,
Chris Morgan <macromorgan@hotmail.com>
Subject: [PATCH 3/5] arm64: dts: rockchip: Pull up sdio pins on RK3588
Date: Fri, 26 Jul 2024 14:49:46 -0500 [thread overview]
Message-ID: <20240726194948.109326-4-macroalpha82@gmail.com> (raw)
In-Reply-To: <20240726194948.109326-1-macroalpha82@gmail.com>
From: Chris Morgan <macromorgan@hotmail.com>
When using an Ampak derived bcm43456 on an RK3588s based GameForce Ace
the WiFi failed to work properly until I set the SDIO pins from
pull-none to pull-up. This matches the vendor kernel located at [1].
I tested this then on an RK3588s based Indiedroid Nova and did not
observe any adverse effects.
[1] https://github.com/rockchip-linux/kernel/commit/b96485b7af46a99c14f3c4818eb18c7836eb809c
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
arch/arm64/boot/dts/rockchip/rk3588-base-pinctrl.dtsi | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588-base-pinctrl.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-base-pinctrl.dtsi
index 30db12c4fc82..d1368418502a 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-base-pinctrl.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3588-base-pinctrl.dtsi
@@ -2449,15 +2449,15 @@ sdiom1_pins: sdiom1-pins {
/* sdio_clk_m1 */
<3 RK_PA5 2 &pcfg_pull_none>,
/* sdio_cmd_m1 */
- <3 RK_PA4 2 &pcfg_pull_none>,
+ <3 RK_PA4 2 &pcfg_pull_up>,
/* sdio_d0_m1 */
- <3 RK_PA0 2 &pcfg_pull_none>,
+ <3 RK_PA0 2 &pcfg_pull_up>,
/* sdio_d1_m1 */
- <3 RK_PA1 2 &pcfg_pull_none>,
+ <3 RK_PA1 2 &pcfg_pull_up>,
/* sdio_d2_m1 */
- <3 RK_PA2 2 &pcfg_pull_none>,
+ <3 RK_PA2 2 &pcfg_pull_up>,
/* sdio_d3_m1 */
- <3 RK_PA3 2 &pcfg_pull_none>;
+ <3 RK_PA3 2 &pcfg_pull_up>;
};
};
--
2.34.1
next prev parent reply other threads:[~2024-07-26 19:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-26 19:49 [PATCH 0/5] Add GameForce Ace Chris Morgan
2024-07-26 19:49 ` [PATCH 1/5] dt-bindings: power: supply: add dual-cell for cw2015 Chris Morgan
2024-07-30 16:36 ` Rob Herring
2024-07-26 19:49 ` [PATCH 2/5] power: supply: cw2015: Add support for dual-cell configurations Chris Morgan
2024-07-26 21:06 ` Sebastian Reichel
2024-07-31 16:02 ` Chris Morgan
2024-07-31 17:02 ` Sebastian Reichel
2024-07-31 17:14 ` Chris Morgan
2024-08-02 21:39 ` Dragan Simic
2024-08-04 16:29 ` Sebastian Reichel
2024-08-04 16:42 ` Dragan Simic
2024-07-26 19:49 ` Chris Morgan [this message]
2024-07-26 21:42 ` [PATCH 3/5] arm64: dts: rockchip: Pull up sdio pins on RK3588 Heiko Stübner
2024-07-31 15:30 ` Chris Morgan
2024-07-26 19:49 ` [PATCH 4/5] dt-bindings: arm: rockchip: Add GameForce Ace Chris Morgan
2024-07-27 9:09 ` Krzysztof Kozlowski
2024-07-26 19:49 ` [PATCH 5/5] arm64: dts: " Chris Morgan
2024-07-29 18:52 ` [PATCH 0/5] " Rob Herring (Arm)
2024-07-31 15:32 ` Chris Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240726194948.109326-4-macroalpha82@gmail.com \
--to=macroalpha82@gmail.com \
--cc=andyshrk@163.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jagan@edgeble.ai \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=macromorgan@hotmail.com \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
--cc=t.schramm@manjaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).