From: Kaustabh Chakraborty <kauschluss@disroot.org>
To: Jonathan Cameron <jic23@kernel.org>, Conor Dooley <conor@kernel.org>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
Kaustabh Chakraborty <kauschluss@disroot.org>
Subject: [PATCH v4 1/3] iio: light: stk3310: relax chipid check warning
Date: Sat, 27 Jul 2024 00:23:31 +0530 [thread overview]
Message-ID: <20240727-stk3310-v4-1-02497b1407ba@disroot.org> (raw)
In-Reply-To: <20240727-stk3310-v4-0-02497b1407ba@disroot.org>
In order to allow newer devices which are compatible with existing
sensors, issuing a warning for an unknown chipid indicates that
something has gone wrong with the init process, which isn't ideal.
Swap it with a friendlier info message to get things right.
Suggested-by: Conor Dooley <conor@kernel.org>
Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
---
drivers/iio/light/stk3310.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/light/stk3310.c b/drivers/iio/light/stk3310.c
index e3470d6743ef..48a971de6a04 100644
--- a/drivers/iio/light/stk3310.c
+++ b/drivers/iio/light/stk3310.c
@@ -496,7 +496,7 @@ static int stk3310_init(struct iio_dev *indio_dev)
ret = stk3310_check_chip_id(chipid);
if (ret < 0)
- dev_warn(&client->dev, "unknown chip id: 0x%x\n", chipid);
+ dev_info(&client->dev, "new unknown chip id: 0x%x\n", chipid);
state = STK3310_STATE_EN_ALS | STK3310_STATE_EN_PS;
ret = stk3310_set_state(data, state);
--
2.45.2
next prev parent reply other threads:[~2024-07-26 18:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-26 18:53 [PATCH v4 0/3] iio: light: stk3310: stk3013 support Kaustabh Chakraborty
2024-07-26 18:53 ` Kaustabh Chakraborty [this message]
2024-07-26 18:53 ` [PATCH v4 2/3] iio: light: stk3310: add support for stk3013 Kaustabh Chakraborty
2024-07-26 18:53 ` [PATCH v4 3/3] dt-bindings: iio: light: stk33xx: add compatible " Kaustabh Chakraborty
2024-07-30 16:25 ` Rob Herring (Arm)
2024-07-28 17:05 ` [PATCH v4 0/3] iio: light: stk3310: stk3013 support Jonathan Cameron
2024-07-30 18:17 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240727-stk3310-v4-1-02497b1407ba@disroot.org \
--to=kauschluss@disroot.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).