devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Petr Vorel <petr.vorel@gmail.com>
To: Alexander Reimelt <alexander.reimelt@posteo.de>
Cc: andersson@kernel.org, konrad.dybcio@linaro.org,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: arm: qcom: Add LG G4 (h815)
Date: Sun, 28 Jul 2024 17:13:29 +0200	[thread overview]
Message-ID: <20240728151329.GA1196482@pevik> (raw)
In-Reply-To: <20240727201413.114317-2-alexander.reimelt@posteo.de>

Hi all,

> International variant of the LG G4 from 2015.

Obviously correct.
Reviewed-by: Petr Vorel <petr.vorel@gmail.com>

Alexander, others have added their tags in previous versions. IMHO generally
it'd be worth if you carry others tags in next versions (when nothing changes).

I now see Krzysztof was faster to write this. Thus I put the tags with links:

https://lore.kernel.org/linux-arm-msm/171216461463.4018435.3466905061314737419.robh@kernel.org/
Acked-by: Rob Herring <robh@kernel.org>

https://lore.kernel.org/linux-arm-msm/d596abcd-8374-4a6f-ad98-c5a04416865d@linaro.org/
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Kind regards,
Petr

> Signed-off-by: Alexander Reimelt <alexander.reimelt@posteo.de>
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
>  1 file changed, 1 insertion(+)

> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index f08e13b61172..f79730d02eb7 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -250,6 +250,7 @@ properties:
>        - items:
>            - enum:
>                - lg,bullhead
> +              - lg,h815
>                - microsoft,talkman
>                - xiaomi,libra
>            - const: qcom,msm8992

  parent reply	other threads:[~2024-07-28 15:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-27 20:04 [PATCH v3 0/2] arm64: Add basic support for LG H815 Alexander Reimelt
2024-07-27 20:04 ` [PATCH v3 1/2] dt-bindings: arm: qcom: Add LG G4 (h815) Alexander Reimelt
2024-07-28  8:42   ` Krzysztof Kozlowski
2024-07-28 15:13   ` Petr Vorel [this message]
2024-07-28 18:59     ` Alexander Reimelt
2024-07-27 20:04 ` [PATCH v3 2/2] arm64: dts: qcom: msm8992-lg-h815: Initial support for LG G4 (H815) Alexander Reimelt
2024-07-29 18:52 ` [PATCH v3 0/2] arm64: Add basic support for LG H815 Rob Herring (Arm)
2024-08-01  3:19 ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240728151329.GA1196482@pevik \
    --to=petr.vorel@gmail.com \
    --cc=alexander.reimelt@posteo.de \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).