devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: kernel@pengutronix.de,
	Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
	 "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	 Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>,  Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	 Philipp Zabel <p.zabel@pengutronix.de>,
	 Elaine Zhang <zhangqing@rock-chips.com>,
	 David Jander <david.jander@protonic.nl>
Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org,
	 devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	 linux-rockchip@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	 Marc Kleine-Budde <mkl@pengutronix.de>
Subject: [PATCH can-next 11/21] can: rockchip_canfd: add functions to check if CAN-FD frames are equal
Date: Mon, 29 Jul 2024 15:05:42 +0200	[thread overview]
Message-ID: <20240729-rockchip-canfd-v1-11-fa1250fd6be3@pengutronix.de> (raw)
In-Reply-To: <20240729-rockchip-canfd-v1-0-fa1250fd6be3@pengutronix.de>

Add a pair new functions to check if 2 struct canfd_frame are equal.
The 1st checks if the header of the CAN frames are equal, the 2nd
checks if the data portion are equal:

- rkcanfd_can_frame_header_equal()
- rkcanfd_can_frame_data_equal()

This functionality is needed in the next patch.

Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
 drivers/net/can/rockchip/rockchip_canfd-rx.c | 42 ++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/drivers/net/can/rockchip/rockchip_canfd-rx.c b/drivers/net/can/rockchip/rockchip_canfd-rx.c
index c7b316e52580..df5280375ca9 100644
--- a/drivers/net/can/rockchip/rockchip_canfd-rx.c
+++ b/drivers/net/can/rockchip/rockchip_canfd-rx.c
@@ -6,6 +6,48 @@
 
 #include "rockchip_canfd.h"
 
+static bool rkcanfd_can_frame_header_equal(const struct canfd_frame *const cfd1,
+					   const struct canfd_frame *const cfd2,
+					   const bool is_canfd)
+{
+	const u8 mask_flags = CANFD_BRS | CANFD_ESI | CANFD_FDF;
+	canid_t mask = CAN_EFF_FLAG;
+
+	if (canfd_sanitize_len(cfd1->len) != canfd_sanitize_len(cfd2->len))
+		return false;
+
+	if (!is_canfd)
+		mask |= CAN_RTR_FLAG;
+
+	if (cfd1->can_id & CAN_EFF_FLAG)
+		mask |= CAN_EFF_MASK;
+	else
+		mask |= CAN_SFF_MASK;
+
+	if ((cfd1->can_id & mask) != (cfd2->can_id & mask))
+		return false;
+
+	if (is_canfd &&
+	    (cfd1->flags & mask_flags) != (cfd2->flags & mask_flags))
+		return false;
+
+	return true;
+}
+
+static bool rkcanfd_can_frame_data_equal(const struct canfd_frame *cfd1,
+					 const struct canfd_frame *cfd2,
+					 const bool is_canfd)
+{
+	u8 len;
+
+	if (!is_canfd && (cfd1->can_id & CAN_RTR_FLAG))
+		return true;
+
+	len = canfd_sanitize_len(cfd1->len);
+
+	return !memcmp(cfd1->data, cfd2->data, len);
+}
+
 static unsigned int
 rkcanfd_fifo_header_to_cfd_header(const struct rkcanfd_priv *priv,
 				  const struct rkcanfd_fifo_header *header,

-- 
2.43.0



  parent reply	other threads:[~2024-07-29 13:07 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-29 13:05 [PATCH can-next 00/21] can: rockchip_canfd: add support for CAN-FD IP core found on Rockchip RK3568 Marc Kleine-Budde
2024-07-29 13:05 ` [PATCH can-next 01/21] dt-bindings: can: rockchip_canfd: add binding for rockchip CAN-FD controller Marc Kleine-Budde
2024-07-30 19:21   ` Rob Herring
2024-07-31  8:44     ` Marc Kleine-Budde
2024-07-29 13:05 ` [PATCH can-next 02/21] arm64: dts: rockchip: add CAN-FD controller nodes to rk3568 Marc Kleine-Budde
2024-07-29 13:05 ` [PATCH can-next 03/21] arm64: dts: rockchip: mecsbc: add CAN0 and CAN1 interfaces Marc Kleine-Budde
2024-07-29 13:05 ` [PATCH can-next 04/21] can: rockchip_canfd: add driver for Rockchip CAN-FD controller Marc Kleine-Budde
2024-07-30 16:34   ` Simon Horman
2024-07-31  8:02     ` Marc Kleine-Budde
2024-07-29 13:05 ` [PATCH can-next 05/21] can: rockchip_canfd: add quirks for errata workarounds Marc Kleine-Budde
2024-07-29 13:05 ` [PATCH can-next 06/21] can: rockchip_canfd: add quirk for broken CAN-FD support Marc Kleine-Budde
2024-07-29 13:05 ` [PATCH can-next 07/21] can: rockchip_canfd: add support for rk3568v3 Marc Kleine-Budde
2024-07-29 13:05 ` [PATCH can-next 08/21] can: rockchip_canfd: add notes about known issues Marc Kleine-Budde
2024-07-29 13:05 ` [PATCH can-next 09/21] can: rockchip_canfd: rkcanfd_handle_rx_int_one(): implement workaround for erratum 5: check for empty FIFO Marc Kleine-Budde
2024-07-29 13:05 ` [PATCH can-next 10/21] can: rockchip_canfd: rkcanfd_register_done(): add warning for erratum 5 Marc Kleine-Budde
2024-07-29 13:05 ` Marc Kleine-Budde [this message]
2024-07-30 16:37   ` [PATCH can-next 11/21] can: rockchip_canfd: add functions to check if CAN-FD frames are equal Simon Horman
2024-07-31  8:02     ` Marc Kleine-Budde
2024-07-29 13:05 ` [PATCH can-next 12/21] can: rockchip_canfd: add TX PATH Marc Kleine-Budde
2024-07-30 16:44   ` Simon Horman
2024-07-31  8:01     ` Marc Kleine-Budde
2024-07-29 13:05 ` [PATCH can-next 13/21] can: rockchip_canfd: implement workaround for erratum 6 Marc Kleine-Budde
2024-07-29 13:05 ` [PATCH can-next 14/21] can: rockchip_canfd: implement workaround for erratum 12 Marc Kleine-Budde
2024-07-29 13:05 ` [PATCH can-next 15/21] can: rockchip_canfd: rkcanfd_get_berr_counter_corrected(): work around broken {RX,TX}ERRORCNT register Marc Kleine-Budde
2024-07-29 13:05 ` [PATCH can-next 16/21] can: rockchip_canfd: add stats support for errata workarounds Marc Kleine-Budde
2024-07-29 13:05 ` [PATCH can-next 17/21] can: rockchip_canfd: prepare to use full TX-FIFO depth Marc Kleine-Budde
2024-07-29 13:05 ` [PATCH can-next 18/21] can: rockchip_canfd: enable full TX-FIFO depth of 2 Marc Kleine-Budde
2024-07-29 13:05 ` [PATCH can-next 19/21] can: rockchip_canfd: add hardware timestamping support Marc Kleine-Budde
2024-07-30 16:30   ` Simon Horman
2024-07-31  8:00     ` Marc Kleine-Budde
2024-07-31  9:04       ` Simon Horman
2024-07-29 13:05 ` [PATCH can-next 20/21] can: rockchip_canfd: add support for CAN_CTRLMODE_LOOPBACK Marc Kleine-Budde
2024-07-29 13:05 ` [PATCH can-next 21/21] can: rockchip_canfd: add support for CAN_CTRLMODE_BERR_REPORTING Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240729-rockchip-canfd-v1-11-fa1250fd6be3@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=david.jander@protonic.nl \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=heiko@sntech.de \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mailhol.vincent@wanadoo.fr \
    --cc=netdev@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    --cc=zhangqing@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).