From: Rob Herring <robh@kernel.org>
To: Mateusz Majewski <m.majewski2@samsung.com>
Cc: linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Zhang Rui <rui.zhang@intel.com>,
Lukasz Luba <lukasz.luba@arm.com>,
Conor Dooley <conor+dt@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Sam Protsenko <semen.protsenko@linaro.org>,
Anand Moon <linux.amoon@gmail.com>
Subject: Re: [PATCH v2 6/6] dt-bindings: thermal: samsung,exynos: remove outdated information on trip point count
Date: Tue, 30 Jul 2024 10:17:48 -0600 [thread overview]
Message-ID: <20240730161748.GA1414176-robh@kernel.org> (raw)
In-Reply-To: <20240726110114.1509733-7-m.majewski2@samsung.com>
On Fri, Jul 26, 2024 at 01:01:10PM +0200, Mateusz Majewski wrote:
> This is not true as of commit 5314b1543787 ("thermal/drivers/exynos: Use
> set_trips ops").
What is not true?
How can the h/w change? I already asked that. Please make your commit
message summarize prior discussions so that the patch stands on its own
and you don't get the same response again. Assume the reviewers have 0
recollection of the prior versions because we don't. This is just one of
100s of patches a week...
>
> Signed-off-by: Mateusz Majewski <m.majewski2@samsung.com>
> ---
> v1 -> v2: remove an unnecessary sentence.
>
> .../devicetree/bindings/thermal/samsung,exynos-thermal.yaml | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml b/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml
> index b8c0bb7f4263..b85b4c420cd3 100644
> --- a/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml
> @@ -40,11 +40,7 @@ properties:
> interrupts:
> description: |
> The Exynos TMU supports generating interrupts when reaching given
> - temperature thresholds. Number of supported thermal trip points depends
> - on the SoC (only first trip points defined in DT will be configured)::
> - - most of SoC: 4
> - - samsung,exynos5433-tmu: 8
> - - samsung,exynos7-tmu: 8
> + temperature thresholds.
> maxItems: 1
>
> reg:
> --
> 2.45.1
>
next prev parent reply other threads:[~2024-07-30 16:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240726110133eucas1p1a20d4fae252520ea6747bc1101c9d59a@eucas1p1.samsung.com>
2024-07-26 11:01 ` [PATCH v2 0/6] Add initial Exynos850 support to the thermal driver Mateusz Majewski
[not found] ` <CGME20240726110135eucas1p118620038792bd07154f32f7b95f48326@eucas1p1.samsung.com>
2024-07-26 11:01 ` [PATCH v2 1/6] drivers/thermal/exynos: use DEFINE_SIMPLE_DEV_PM_OPS Mateusz Majewski
[not found] ` <CGME20240726110136eucas1p2c100992bb710acb5a12bb294401d4aeb@eucas1p2.samsung.com>
2024-07-26 11:01 ` [PATCH v2 2/6] drivers/thermal/exynos: use pm_sleep_ptr instead of conditional compilation Mateusz Majewski
2024-07-26 18:08 ` Sam Protsenko
[not found] ` <CGME20240726110138eucas1p27f33fb42af84ba7938703796c3f80727@eucas1p2.samsung.com>
2024-07-26 11:01 ` [PATCH v2 3/6] drivers/thermal/exynos: improve sanitize_temp_error Mateusz Majewski
2024-07-26 18:27 ` Sam Protsenko
[not found] ` <CGME20240726110139eucas1p24eb41978fdad0d37a95c2c829180a203@eucas1p2.samsung.com>
2024-07-26 11:01 ` [PATCH v2 4/6] dt-bindings: thermal: samsung,exynos: add exynos850-tmu string Mateusz Majewski
2024-07-26 18:28 ` Sam Protsenko
[not found] ` <CGME20240726110141eucas1p279c474e8737dcf4752808a20219e12d4@eucas1p2.samsung.com>
2024-07-26 11:01 ` [PATCH v2 5/6] drivers/thermal/exynos: add initial Exynos850 support Mateusz Majewski
2024-07-26 18:44 ` Sam Protsenko
[not found] ` <CGME20240726110142eucas1p29f261e5e81c177456fd5bb5546871eb4@eucas1p2.samsung.com>
2024-07-26 11:01 ` [PATCH v2 6/6] dt-bindings: thermal: samsung,exynos: remove outdated information on trip point count Mateusz Majewski
2024-07-26 18:31 ` Sam Protsenko
2024-07-30 16:17 ` Rob Herring [this message]
2024-07-30 17:25 ` Sam Protsenko
2024-07-31 21:14 ` Mateusz Majewski
2024-07-31 21:56 ` Sam Protsenko
2024-08-06 14:39 ` Rob Herring
[not found] ` <CGME20240726110133eucas1p1a20d4fae252520ea6747bc1101c9d59a@eucms1p3>
2024-07-26 15:03 ` [PATCH v2 0/6] Add initial Exynos850 support to the thermal driver Mateusz Majewski
2024-07-26 15:08 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240730161748.GA1414176-robh@kernel.org \
--to=robh@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=bzolnier@gmail.com \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=lukasz.luba@arm.com \
--cc=m.majewski2@samsung.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=semen.protsenko@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).