From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3259F189B97; Tue, 30 Jul 2024 19:21:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722367320; cv=none; b=SkGHV2e+S0qQ/EG9Burgurxiecva2qqEfP13RDRi/q1PHMIdr0SGFFexIlJu2xWY1k6LnwTkEvcxrKKhbYsAUpOjmV8VKObmbYD/+4dTQU2O7GsFT5OaDUhtyUW2CZg2ZHFff53AsqHTCUSJw61INeuTt6au6JgWBs2UdWu7tW4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722367320; c=relaxed/simple; bh=+z+uSHvXptbqQUkxjz2xHQBFc5+LBea44Cmnih2JyhU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cDtRwmPC3OEgBQOubVpu5iBvVCBkT112Angkpmxju81W3+xgXrUKYCgGB/b7rPuSZ2GpyLJM5GZrUr5zqdLJv+vFF2Apm+zbENGDXK828OZqYqFezPAWy6+6gkLRZYnabssQtJ35w72lDLanj6SIQOOumZiubcDFda94L+MxP0U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hjsitjva; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hjsitjva" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 844B1C32782; Tue, 30 Jul 2024 19:21:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722367319; bh=+z+uSHvXptbqQUkxjz2xHQBFc5+LBea44Cmnih2JyhU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hjsitjvai+UJvADhTVoItn0LWY29Z+U4fZJHcAtyws2IZgMZE6+zAvgcmahmMEV4+ bieUMCkz1FBPIlJdYxeqFdWYFE8psyljSxElFLoTJhHtpz4LJ821iyp4vi5O2qVdP8 vfQ2hKuVKYu27eSn4sNREMwrmaHzkKk3rHqcxBq4SwKxI6HsdrZxskOyyfrRCZEg5k wKT9cSlpSduIqxommeu2bUcnqHXxuLTIKx8yUvW9ISijsYnDfxlPvNjTDIjLSisvlU kEhPmeA95nSZjvg9dLw3wh0YSV79d1O9gSRvVTYUWyeeqSKa7mC/6l0qkMk5BcxjlN FGoWydeWRMhRQ== Date: Tue, 30 Jul 2024 13:21:58 -0600 From: Rob Herring To: Marc Kleine-Budde Cc: kernel@pengutronix.de, Vincent Mailhol , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Philipp Zabel , Elaine Zhang , David Jander , linux-can@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH can-next 01/21] dt-bindings: can: rockchip_canfd: add binding for rockchip CAN-FD controller Message-ID: <20240730192158.GA2001115-robh@kernel.org> References: <20240729-rockchip-canfd-v1-0-fa1250fd6be3@pengutronix.de> <20240729-rockchip-canfd-v1-1-fa1250fd6be3@pengutronix.de> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240729-rockchip-canfd-v1-1-fa1250fd6be3@pengutronix.de> On Mon, Jul 29, 2024 at 03:05:32PM +0200, Marc Kleine-Budde wrote: > Add the binding of the rockchip rk3568 CAN-FD controller to the device > tree bindings documentation. Subject line space is valuable. Don't say 'binding' twice. Or anything else for that matter. > Co-developed-by: Elaine Zhang > Signed-off-by: Elaine Zhang > Signed-off-by: Marc Kleine-Budde > --- > .../bindings/net/can/rockchip,canfd.yaml | 76 ++++++++++++++++++++++ > MAINTAINERS | 7 ++ > 2 files changed, 83 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/can/rockchip,canfd.yaml b/Documentation/devicetree/bindings/net/can/rockchip,canfd.yaml > new file mode 100644 > index 000000000000..85f7ea68d8b9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/can/rockchip,canfd.yaml > @@ -0,0 +1,76 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/can/rockchip,canfd.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: > + Rockchip CAN-FD controller > + > +maintainers: > + - Marc Kleine-Budde > + > +allOf: > + - $ref: can-controller.yaml# > + > +properties: > + compatible: > + oneOf: > + - const: rockchip,rk3568-canfd > + - items: > + - enum: > + - rockchip,rk3568v2-canfd > + - rockchip,rk3568v3-canfd > + - const: rockchip,rk3568-canfd > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 2 > + > + clock-names: > + items: > + - const: baudclk Just 'baud' > + - const: apb_pclk apb or pclk. > + > + resets: > + maxItems: 2 > + > + reset-names: > + items: > + - const: can > + - const: can-apb They are always for 'can' so that's redundant. I guess it is fine on the first entry, but definitely drop on the 2nd. Or do 'core' and 'apb'. > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - resets > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + can0: can@fe570000 { > + compatible = "rockchip,rk3568-canfd"; > + reg = <0x0 0xfe570000 0x0 0x1000>; > + interrupts = ; > + clocks = <&cru CLK_CAN0>, <&cru PCLK_CAN0>; > + clock-names = "baudclk", "apb_pclk"; > + resets = <&cru SRST_CAN0>, <&cru SRST_P_CAN0>; > + reset-names = "can", "can-apb"; > + }; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index c0a3d9e93689..d225dc39bd89 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -19694,6 +19694,13 @@ F: Documentation/ABI/*/sysfs-driver-hid-roccat* > F: drivers/hid/hid-roccat* > F: include/linux/hid-roccat* > > +ROCKCHIP CAN-FD DRIVER > +M: Marc Kleine-Budde > +R: kernel@pengutronix.de > +L: linux-can@vger.kernel.org > +S: Maintained > +F: Documentation/devicetree/bindings/net/can/rockchip,canfd.yaml > + > ROCKCHIP CRYPTO DRIVERS > M: Corentin Labbe > L: linux-crypto@vger.kernel.org > > -- > 2.43.0 > >