From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D81BCE573; Tue, 30 Jul 2024 19:36:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722368197; cv=none; b=fHe6+Hq6awJ9NHECNyxBl26Cnam2pL7u4EctpkY9/5h0rNR+RnfOQ0N1ay8W+UNQmQgXawp84P3fQBqKd9pu+CJWSwqaRLeXTsUbf8LhaKnMpxSEqxwL+RsgYWH7f6kHJt1IZODuOcJHugIVyyhlCDu42ZJzNATaEmVxZAwbHZc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722368197; c=relaxed/simple; bh=74KRqgftrkITa0KO51e5D65jtmCMpr+ErH9KcEfJDQw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fejFqp334LimTkGmGUNYOcD1+V9cZXGH2a/ACAKuQ2DiBsXxEXtPz2lCqtg6U1ii4KeYpk69NVC5HcZd5KuaWKHxboVxwEfzAdmnzIi/IK2J/mJe3OAATieUPfHORhaD5e9xgwtBpZOn/rQVGjBsN+j68ql4CCzxcfI9+smm9ow= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=e1RIQrQk; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="e1RIQrQk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 43DE2C32782; Tue, 30 Jul 2024 19:36:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722368197; bh=74KRqgftrkITa0KO51e5D65jtmCMpr+ErH9KcEfJDQw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=e1RIQrQkFJ6o32gJa2AHCyVl2AasokgJoTt6mXXUnXHQ5OYLnXHzl04vteAOPOdym fx1UnA6hGo/Y5CSmxcI5wzbqyKi7PUaZlP3to8P4rHwsgQLay9+b0peV/snv3MMWol kHm/boqcbHP7Xv0LIB6vtImcMpSB0ysE2GMxYZKXJpr96u/PxogjqJ6b0JVzwtDRaz 6xwWG3HjNLXq3P+9GmGHWMc8dyTuNSKUtHVUTT9qbHYtP6g8RF7yQa8VzIE+3FoLN/ hUnQ6cr6KC7AJg+QpUjWe/ExH9Y38yWyN/USgQ+ftQIOKR6hPClAlQOPJzk0xBXx2r iZB+1DXY7sS+w== Date: Tue, 30 Jul 2024 13:36:35 -0600 From: Rob Herring To: Herve Codina Cc: Christophe Leroy , Krzysztof Kozlowski , Conor Dooley , Qiang Zhao , Li Yang , Mark Brown , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Petazzoni Subject: Re: [PATCH v1 23/36] dt-bindings: soc: fsl: cpm_qe: Add QUICC Engine (QE) QMC controller Message-ID: <20240730193635.GA2017245-robh@kernel.org> References: <20240729142107.104574-1-herve.codina@bootlin.com> <20240729142107.104574-24-herve.codina@bootlin.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240729142107.104574-24-herve.codina@bootlin.com> On Mon, Jul 29, 2024 at 04:20:52PM +0200, Herve Codina wrote: > Add support for the QMC (QUICC Multichannel Controller) available in > some PowerQUICC SoC that uses a QUICC Engine (QE) block such as MPC8321. > > This QE QMC is similar to the CPM QMC except that it uses UCCs (Unified > Communication Controllers) instead of SCCs (Serial Communication > Controllers). Also, compared against the CPM QMC, this QE QMC does not > use a fixed area for the UCC/SCC parameters area but it uses a dynamic > area allocated and provided to the hardware at runtime. > Last point, the QE QMC can use a firmware to have the QMC working in > 'soft-qmc' mode. > > Signed-off-by: Herve Codina > --- > .../soc/fsl/cpm_qe/fsl,qe-ucc-qmc.yaml | 197 ++++++++++++++++++ > 1 file changed, 197 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qe-ucc-qmc.yaml > > diff --git a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qe-ucc-qmc.yaml b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qe-ucc-qmc.yaml > new file mode 100644 > index 000000000000..1215b2de36e6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qe-ucc-qmc.yaml > @@ -0,0 +1,197 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qe-ucc-qmc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: PowerQUICC QE QUICC Multichannel Controller (QMC) > + > +maintainers: > + - Herve Codina > + > +description: > + The QMC (QUICC Multichannel Controller) emulates up to 64 channels within one > + serial controller using the same TDM physical interface routed from TSA. > + > +properties: > + compatible: > + items: > + - enum: > + - fsl,mpc8321-ucc-qmc > + - const: fsl,qe-ucc-qmc > + > + reg: > + items: > + - description: UCC (Unified communication controller) register base > + - description: Dual port ram base > + > + reg-names: > + items: > + - const: ucc_regs > + - const: dpram > + > + interrupts: > + maxItems: 1 > + description: UCC interrupt line in the QE interrupt controller > + > + fsl,tsa-serial: > + $ref: /schemas/types.yaml#/definitions/phandle-array > + items: > + - items: > + - description: phandle to TSA node > + - enum: [1, 2, 3, 4, 5] > + description: | > + TSA serial interface (dt-bindings/soc/qe-fsl,tsa.h defines these > + values) > + - 1: UCC1 > + - 2: UCC2 > + - 3: UCC3 > + - 4: UCC4 > + - 5: UCC5 > + description: > + Should be a phandle/number pair. The phandle to TSA node and the TSA > + serial interface to use. > + > + fsl,soft-qmc: > + $ref: /schemas/types.yaml#/definitions/string > + description: > + Soft QMC firmware name to load. If this property is omitted, no firmware > + are used. > + > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 0 > + > +patternProperties: > + '^channel@([0-9]|[1-5][0-9]|6[0-3])$': Unit-addresses are typically in hex. > + description: > + A channel managed by this controller > + type: object > + additionalProperties: false > + > + properties: > + reg: > + minimum: 0 > + maximum: 63 > + description: > + The channel number > + > + fsl,operational-mode: > + $ref: /schemas/types.yaml#/definitions/string > + enum: [transparent, hdlc] > + default: transparent > + description: | > + The channel operational mode > + - hdlc: The channel handles HDLC frames > + - transparent: The channel handles raw data without any processing > + > + fsl,reverse-data: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + The bit order as seen on the channels is reversed, > + transmitting/receiving the MSB of each octet first. > + This flag is used only in 'transparent' mode. > + > + fsl,tx-ts-mask: > + $ref: /schemas/types.yaml#/definitions/uint64 > + description: > + Channel assigned Tx time-slots within the Tx time-slots routed by the > + TSA to this cell. > + > + fsl,rx-ts-mask: > + $ref: /schemas/types.yaml#/definitions/uint64 > + description: > + Channel assigned Rx time-slots within the Rx time-slots routed by the > + TSA to this cell. > + > + compatible: compatible goes first in the list. > + items: > + - enum: > + - fsl,mpc8321-ucc-qmc-hdlc > + - const: fsl,qe-ucc-qmc-hdlc > + - const: fsl,qmc-hdlc Really need 3 compatibles? > + > + fsl,framer: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + phandle to the framer node. The framer is in charge of an E1/T1 line > + interface connected to the TDM bus. It can be used to get the E1/T1 line > + status such as link up/down. > + > + allOf: > + - if: > + properties: > + compatible: > + not: > + contains: > + const: fsl,qmc-hdlc > + then: > + properties: > + fsl,framer: false > + > + required: > + - reg > + - fsl,tx-ts-mask > + - fsl,rx-ts-mask > + > +required: > + - compatible > + - reg > + - reg-names > + - interrupts > + - fsl,tsa-serial > + - '#address-cells' > + - '#size-cells' > + > +additionalProperties: false > + > +examples: > + - | > + #include > + > + qmc@a60 { > + compatible = "fsl,mpc8321-ucc-qmc", "fsl,qe-ucc-qmc"; > + reg = <0x3200 0x200>, > + <0x10000 0x1000>; > + reg-names = "ucc_regs", "dpram"; > + interrupts = <35>; > + interrupt-parent = <&qeic>; > + fsl,soft-qmc = "fsl_qe_ucode_qmc_8321_11.bin"; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + fsl,tsa-serial = <&tsa FSL_QE_TSA_UCC4>; > + > + channel@16 { > + /* Ch16 : First 4 even TS from all routed from TSA */ > + reg = <16>; > + fsl,operational-mode = "transparent"; > + fsl,reverse-data; > + fsl,tx-ts-mask = <0x00000000 0x000000aa>; > + fsl,rx-ts-mask = <0x00000000 0x000000aa>; > + }; > + > + channel@17 { > + /* Ch17 : First 4 odd TS from all routed from TSA */ > + reg = <17>; > + fsl,operational-mode = "transparent"; > + fsl,reverse-data; > + fsl,tx-ts-mask = <0x00000000 0x00000055>; > + fsl,rx-ts-mask = <0x00000000 0x00000055>; > + }; > + > + channel@19 { > + /* Ch19 : 8 TS (TS 8..15) from all routed from TSA */ > + compatible = "fsl,mpc8321-ucc-qmc-hdlc", > + "fsl,qe-ucc-qmc-hdlc", > + "fsl,qmc-hdlc"; > + reg = <19>; > + fsl,operational-mode = "hdlc"; > + fsl,tx-ts-mask = <0x00000000 0x0000ff00>; > + fsl,rx-ts-mask = <0x00000000 0x0000ff00>; > + fsl,framer = <&framer>; > + }; > + }; > -- > 2.45.0 >