From: Andreas Kemnade <andreas@kemnade.info>
To: Sicelo <absicsz@gmail.com>
Cc: tony@atomide.com, linux-omap@vger.kernel.org,
maemo-leste@lists.dyne.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, devicetree@vger.kernel.org,
Aaro Koskinen <aaro.koskinen@iki.fi>
Subject: Re: [PATCH] ARM: dts: omap3-n900: correct the accelerometer orientation
Date: Thu, 1 Aug 2024 08:14:12 +0200 [thread overview]
Message-ID: <20240801081412.55d1792c@kemnade.info> (raw)
In-Reply-To: <Zqf-NosCToA_czCQ@tp440p.steeds.sam>
On Mon, 29 Jul 2024 22:40:22 +0200
Sicelo <absicsz@gmail.com> wrote:
> Hello Andreas
>
> On Sun, Jul 28, 2024 at 10:06:58AM +0200, Andreas Kemnade wrote:
> > > On Mon, Jul 22, 2024 at 01:31:11PM +0200, Sicelo A. Mhlongo
> > > wrote:
> > > > Negate the values reported for the accelerometer z-axis in
> > > > order to match
> > > > Documentation/devicetree/bindings/iio/mount-matrix.txt.
> > > >
> > > > Fixes: 14a213dcb004 ("ARM: dts: n900: use iio driver for
> > > > accelerometer")
> > > >
> > > > Signed-off-by: Sicelo A. Mhlongo <absicsz@gmail.com>
> > > > ---
> > > > arch/arm/boot/dts/ti/omap/omap3-n900.dts | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/arch/arm/boot/dts/ti/omap/omap3-n900.dts
> > > > b/arch/arm/boot/dts/ti/omap/omap3-n900.dts index
> > > > 07c5b963af78..4bde3342bb95 100644 ---
> > > > a/arch/arm/boot/dts/ti/omap/omap3-n900.dts +++
> > > > b/arch/arm/boot/dts/ti/omap/omap3-n900.dts @@ -781,7 +781,7 @@
> > > > accelerometer@1d {
> > > > mount-matrix = "-1", "0", "0",
> > > > "0", "1", "0",
> > > > - "0", "0", "1";
> > > > + "0", "0", "-1";
> > > > };
> > > >
> > > > cam1: camera@3e {
> > > > --
> > > > 2.45.2
> > > >
> > >
> > > CC: Aaro Koskinen <aaro.koskinen@iki.fi>, Andreas Kemnade
> > > <andreas@kemnade.info>
> > >
> > I would expect it to be a rotation matrix but it is not. So maybe
> > this should be fixed in,the driver?
>
> The mount matrix is documented in the kernel docs [1], and this patch
> implements the suggestion that the z-axis should "be negative under
> the screen and positive in front of it, toward the face of the user."
>
> On the N900, the accelerometer is mounted such that the raw z-values
> are opposite to the specification in the kernel docs. The driver
> itself seems to be correct, and is used on a number of other boards
> (such as Motorola Droid 4), reporting expected values when used in
> conjuction with mount matrices.
>
Ok, I did not notice the other -1. It was mirroring before and now it
is a clear 180 deg turn on the y-axis.
So
Reviewed-By: Andreas Kemnade <andreas@kemnade.info>
next prev parent reply other threads:[~2024-08-01 6:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-22 11:31 [PATCH] ARM: dts: omap3-n900: correct the accelerometer orientation Sicelo A. Mhlongo
2024-07-27 18:41 ` Sicelo
2024-07-28 8:06 ` Andreas Kemnade
2024-07-29 20:40 ` Sicelo
2024-08-01 6:14 ` Andreas Kemnade [this message]
2024-08-05 18:08 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240801081412.55d1792c@kemnade.info \
--to=andreas@kemnade.info \
--cc=aaro.koskinen@iki.fi \
--cc=absicsz@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=maemo-leste@lists.dyne.org \
--cc=robh@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).