From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 655BD189534 for ; Thu, 1 Aug 2024 11:11:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722510675; cv=none; b=jSBSK3YWr0h8Ak/X3ER5lhOCAAqOve/jGO063Mp1fbrH5SvHhMS3bbOyzoozsCjQYhpSvi5N+e6JibnpadZqKqHwC49JM38D8//Bjo4HYAGMPxLDOPgEQwtq+Wrkp8l56e3SqVJI6X+tBszMX4Pnf1X3pZZ/JjCYoQI4FHzt7p8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722510675; c=relaxed/simple; bh=onHxWsInCEUNZL02MWAzhkY6TZ4nGpiCTSI+v+pCri0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=M38ELiHIHVwYqcPKtR0MmA1qaR9DYtTM88isyugQBD79XlFCwTOh8V0NxMBjItHwc6tjBf+mbKLJBzuQha218DcCBdedLoDnpsyIVFxvR0s5WrmHrE4LUbCRfMuXDgKHGhhWfttCXvONdfINdQeYwvs6NCwf49jPEpqpPWzZ/ds= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=q2pLgUA6; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="q2pLgUA6" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-710439ad77dso2204643b3a.2 for ; Thu, 01 Aug 2024 04:11:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1722510674; x=1723115474; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=8JBGFxD6jahE3TXwzjss0XWvpjFEEt8FVaR1X4PNMwA=; b=q2pLgUA6EPDLxR38JpbkL2h4xjaNoBlqFLkaVfXVHUvn48jXy9pKCyAGXIA8TryHA6 O9S6mj5+n6AUSgpaC3RNRiEkAdnvIK/uyTSg7m2zHNxG+2muo5aB3mY3sYF+WbIlKTGB R43xyIrNAvT9QyM5C1txSgafKHo3MzVxtTx0Uh0AfGcABxqIASR/0KaHoZccpQj0GUDY c1WUXfJwbE+zIE2TKgEYZykaVpkQXq5cQfYBmR51HPgHQV16BgLYIjRWFByfwjoDfnj4 39GSosl2Z3kyB/E2/qj67SOxLPV01zoynMIKIpJ4MbEQm1MpdLJY1SwgkJSezGMkBkwk sq0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722510674; x=1723115474; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8JBGFxD6jahE3TXwzjss0XWvpjFEEt8FVaR1X4PNMwA=; b=rU4HD2WLqvpLqUwbQ8HtXAckIExcCsZGYePJBYYw3YxdBz54gLMhwVeyw7ny3HLt1D RgThdPasZvF8XoeMBEtDJ7/Kjw85I+gUsk9CMILsKqHqgqLNljpo7aIv3sLEo2607bhp ZRqSgcGs0WJnOA1C6pd2lGe4XIB9MVCupZbFLqijfT/NsGkfCYx6NQPRStCrtzoEUr7a 8Tddn/nhi65GB7oFbd3IpLb8m56NPUKBS6+do2XlQklV31nYyug9LhxwQfykMDIuOCWU rCQ3gS0QKgq3fT+S+xlh9K9Byk3D2wggusP7vbQButIYma4YfrtdHZxqcXAj2PX9j8tN Q7lQ== X-Forwarded-Encrypted: i=1; AJvYcCVCA/T1PQQH+8R3/S6x4FSnoQc9PgReWUN13/tGmka2osbDEhbZ4SgzWW5BSu2hYkZQ7aH0Ezkq0V+vFKypcoE7XmtSlZkgeqfTMA== X-Gm-Message-State: AOJu0YwL0c2kz7EHU383wo0C3i6iXV3b7HOBdsW7xQjYfVe055Itb6B5 QvWAV1RIXUB5HkQsBHNEn8Nf1Rt2jvE800yEvbDoaMxgRcPAhY0K8gI4XkcbbQ== X-Google-Smtp-Source: AGHT+IHqPM6SHkoj6Vhah2++836HWIGjccmsoYPBQTMXP6Uqgnf4FBlSWurf5IC+XtA/PWvxNY0bNw== X-Received: by 2002:a05:6a20:7f94:b0:1c4:ce43:7dd1 with SMTP id adf61e73a8af0-1c68cf82a04mr2602801637.20.1722510673570; Thu, 01 Aug 2024 04:11:13 -0700 (PDT) Received: from thinkpad ([120.60.66.23]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fed7fa468bsm136893295ad.255.2024.08.01.04.11.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Aug 2024 04:11:13 -0700 (PDT) Date: Thu, 1 Aug 2024 16:41:07 +0530 From: Manivannan Sadhasivam To: Elson Roy Serrao Cc: andersson@kernel.org, konrad.dybcio@linaro.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, gregkh@linuxfoundation.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH 0/8] Enable EUD on Qualcomm sm8450 SoC Message-ID: <20240801111107.GA29707@thinkpad> References: <20240730222439.3469-1-quic_eserrao@quicinc.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240730222439.3469-1-quic_eserrao@quicinc.com> On Tue, Jul 30, 2024 at 03:24:31PM -0700, Elson Roy Serrao wrote: > The Embedded USB Debugger (EUD) is a mini High-Speed USB on-chip hub to > support the USB-based debug and trace capabilities on Qualcomm devices. > The current implementation lacks in below aspects that are needed for > proper EUD functionality. > > 1.) HS-Phy control: EUD being a HS hub needs HS-Phy support for it's > operation. Hence EUD module should enable/disable HS-phy > accordingly. > > 2.) Proper routing of USB role switch notifications: EUD hub is physically > present in between the USB connector and the USB controller. So the > usb role switch notifications originating from the connector should > route through EUD. EUD also relies on role switch notifications to > communicate with the USB, regarding EUD attach/detach events. > > This series aims at implementing the above aspects to enable EUD on > Qualcomm sm8450 SoC. > For the open source community, EUD enablement means they will only get EUD ports enumerated on the host and nothing else. There is no public info on how to use EUD nor are there any tools to make use of it. So what is the purpose of upstreaming it in the first place? If the goal is to use EUD only by Qcom employees or customers who have signed NDA, then you can just supply them the out-of-tree EUD patches and tools to work with. There is absolutely no need to upstream the driver support. So for this series and any other future EUD patches, Nacked-by: Manivannan Sadhasivam I'm really tempted to send a patch to remove the EUD driver altogether, but I'll just wait for the response before doing so. - Mani -- மணிவண்ணன் சதாசிவம்