From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Jonathan Marek <jonathan@marek.ca>,
Robert Foss <rfoss@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Rob Clark <robdclark@gmail.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Georgi Djakov <djakov@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Mike Tipton <quic_mdtipton@quicinc.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Subject: [PATCH 03/11] drm/msm/dsi: correct programming sequence for SM8350 / SM8450
Date: Sun, 04 Aug 2024 08:40:07 +0300 [thread overview]
Message-ID: <20240804-sm8350-fixes-v1-3-1149dd8399fe@linaro.org> (raw)
In-Reply-To: <20240804-sm8350-fixes-v1-0-1149dd8399fe@linaro.org>
According to the display-drivers, 5nm DSI PLL (v4.2, v4.3) have
different boundaries for pll_clock_inverters programming. Follow the
vendor code and use correct values.
Fixes: 2f9ae4e395ed ("drm/msm/dsi: add support for DSI-PHY on SM8350 and SM8450")
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c
index 3b59137ca674..031446c87dae 100644
--- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c
+++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c
@@ -135,7 +135,7 @@ static void dsi_pll_calc_dec_frac(struct dsi_pll_7nm *pll, struct dsi_pll_config
config->pll_clock_inverters = 0x00;
else
config->pll_clock_inverters = 0x40;
- } else {
+ } else if (pll->phy->cfg->quirks & DSI_PHY_7NM_QUIRK_V4_1) {
if (pll_freq <= 1000000000ULL)
config->pll_clock_inverters = 0xa0;
else if (pll_freq <= 2500000000ULL)
@@ -144,6 +144,16 @@ static void dsi_pll_calc_dec_frac(struct dsi_pll_7nm *pll, struct dsi_pll_config
config->pll_clock_inverters = 0x00;
else
config->pll_clock_inverters = 0x40;
+ } else {
+ /* 4.2, 4.3 */
+ if (pll_freq <= 1000000000ULL)
+ config->pll_clock_inverters = 0xa0;
+ else if (pll_freq <= 2500000000ULL)
+ config->pll_clock_inverters = 0x20;
+ else if (pll_freq <= 3500000000ULL)
+ config->pll_clock_inverters = 0x00;
+ else
+ config->pll_clock_inverters = 0x40;
}
config->decimal_div_start = dec;
--
2.39.2
next prev parent reply other threads:[~2024-08-04 5:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-04 5:40 [PATCH 00/11] arm64: qcom: set of fixes for SM8350 platform Dmitry Baryshkov
2024-08-04 5:40 ` [PATCH 01/11] clk: qcom: dispcc-sm8250: use CLK_SET_RATE_PARENT for branch clocks Dmitry Baryshkov
2024-08-04 5:40 ` [PATCH 02/11] clk: qcom: dispcc-sm8250: use special function for Lucid 5LPE PLL Dmitry Baryshkov
2024-08-04 5:40 ` Dmitry Baryshkov [this message]
2024-08-28 20:33 ` [PATCH 03/11] drm/msm/dsi: correct programming sequence for SM8350 / SM8450 Abhinav Kumar
2024-08-04 5:40 ` [PATCH 04/11] interconnect: qcom: sm8350: drop DISP nodes Dmitry Baryshkov
2024-08-04 5:40 ` [PATCH 05/11] interconnect: qcom: sm8450: " Dmitry Baryshkov
2024-08-04 5:40 ` [PATCH 06/11] dt-bindings: interconnect: qcom,sm8350: " Dmitry Baryshkov
2024-08-05 5:59 ` Krzysztof Kozlowski
2024-08-04 5:40 ` [PATCH 07/11] dt-bindings: interconnect: qcom,sm8450: " Dmitry Baryshkov
2024-08-04 8:49 ` kernel test robot
2024-08-04 9:16 ` Dmitry Baryshkov
2024-08-05 6:00 ` Krzysztof Kozlowski
2024-08-04 5:40 ` [PATCH 08/11] interconnect: qcom: sm8250: Enable sync_state Dmitry Baryshkov
2024-08-04 5:40 ` [PATCH 09/11] arm64: dts: qcom: sm8350: add MDSS registers interconnect Dmitry Baryshkov
2024-08-04 5:40 ` [PATCH 10/11] arm64: dts: qcom: sm8350: add refgen regulator Dmitry Baryshkov
2024-08-04 5:40 ` [PATCH 11/11] arm64: defconfig: build CONFIG_REGULATOR_QCOM_REFGEN as module Dmitry Baryshkov
2024-08-05 6:00 ` Krzysztof Kozlowski
2024-08-15 20:40 ` (subset) [PATCH 00/11] arm64: qcom: set of fixes for SM8350 platform Bjorn Andersson
2024-08-15 22:44 ` Bjorn Andersson
2024-09-05 3:33 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240804-sm8350-fixes-v1-3-1149dd8399fe@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jonathan@marek.ca \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=mturquette@baylibre.com \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_mdtipton@quicinc.com \
--cc=rfoss@kernel.org \
--cc=robdclark@gmail.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=sean@poorly.run \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).