devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lee Jones <lee@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Marek Vasut <marex@denx.de>,
	devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
	Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Pavel Machek <pavel@ucw.cz>, Rob Herring <robh@kernel.org>,
	linux-leds@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: leds: Document "netdev" trigger
Date: Mon, 5 Aug 2024 14:56:43 +0100	[thread overview]
Message-ID: <20240805135643.GC1019230@google.com> (raw)
In-Reply-To: <62cc3d64-c5e4-4af3-90ce-273ece6e8e57@lunn.ch>

On Thu, 01 Aug 2024, Andrew Lunn wrote:

> On Thu, Aug 01, 2024 at 01:53:09PM +0100, Lee Jones wrote:
> > On Thu, 25 Jul 2024, Andrew Lunn wrote:
> > 
> > > > > diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
> > > > > index 8a3c2398b10ce..bf9a101e4d420 100644
> > > > > --- a/Documentation/devicetree/bindings/leds/common.yaml
> > > > > +++ b/Documentation/devicetree/bindings/leds/common.yaml
> > > > > @@ -113,6 +113,8 @@ properties:
> > > > >              # LED indicates NAND memory activity (deprecated),
> > > > >              # in new implementations use "mtd"
> > > > >            - nand-disk
> > > > > +            # LED indicates network activity
> > > > > +          - netdev
> > > > 
> > > > netdev is the description of the network development ML/repo, right?
> > > > 
> > > > Seems like an odd name for an OS agnostic property?
> > > 
> > > I agree that one meaning is the network development community within
> > > Linux.
> > > 
> > > But it also means a network device, which is OS agnostic. I don't
> > > really see it be any different to a memory technology device, mtd.
> > 
> > MTD is an acronym.
> > 
> > The only dodgy one I see in there is 'kbd-capslock'.
> > 
> > How about, now go with me here: 'network'?
> 
> We could do, but we have to keep netdev around for backwards
> compatibility. There are DT blobs using it which we cannot break.

Oh, this 'just' a documentation patch?  'netdev' is already in use?

-- 
Lee Jones [李琼斯]

  reply	other threads:[~2024-08-05 13:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-08 11:46 [PATCH v2] dt-bindings: leds: Document "netdev" trigger Marek Vasut
2024-07-09  9:06 ` Krzysztof Kozlowski
2024-07-25  8:50 ` Lee Jones
2024-07-25 12:37   ` Andrew Lunn
2024-08-01 12:53     ` Lee Jones
2024-08-01 13:03       ` Andrew Lunn
2024-08-05 13:56         ` Lee Jones [this message]
2024-08-05 22:56           ` Andrew Lunn
2024-08-16 15:47             ` Lee Jones
2024-08-16 15:53 ` (subset) " Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240805135643.GC1019230@google.com \
    --to=lee@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jacek.anaszewski@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=netdev@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).