From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D7E8194124; Wed, 7 Aug 2024 05:42:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.19.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723009374; cv=none; b=VXCYjZAif+lVx23vTSz0or8NxbRQ+cTDUN7aNLPrlOwMGyaQGn1JB/qsnCGw9ohZNk8RQLW9jTiNVTsufsjW8kCxYo2pWagjiyd/+VhLLY4bpUHowoNavuSAS3R0lkctJZzpoRHzRJCK1ND+ITr14NwOObufrnK1okdIVcPrG2Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723009374; c=relaxed/simple; bh=8ceZ/gjp99Gn2ReZrP5n1e6TqhjqXr8pPQAmOwfo2+o=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=I2mP0RS6y6DtiFe10FEPeorg6WHA4w52AWrhR6Ip6IOvUT34v6dsWaFrv+dB1kZxIi5XyGdJ9M9XmXCq6qncXvuq/esj4JxuX3zy7Wgsg/k9Z1j6GF361vatHeENQg0EPfVSHjc5UPS59SLEkOgC3tUJA3+t/lYDzwCmCONVd8Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=yDnYgMmf; arc=none smtp.client-ip=198.47.19.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="yDnYgMmf" Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 4775gjAc113409; Wed, 7 Aug 2024 00:42:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1723009365; bh=touyr6w7+hEqxR4kfJtt19bFm30aXZBbAZgaNwWFKIk=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=yDnYgMmfftQ5UmbCnVnz0EDlBGTBCnnPx393qIO9jWaAx2oDYOReD1yIg961QGHlX o6wo5TNhMdL0iKnv5GexIsCiWC/n/yMJjGfrC8gBM1zZtSBGxpZSGEy8InRA8KqSp0 49M7F92vQxAWcaeMtq8iZjVGRPQgSDk2QXxA3fPc= Received: from DLEE108.ent.ti.com (dlee108.ent.ti.com [157.170.170.38]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 4775gj2A020883 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 7 Aug 2024 00:42:45 -0500 Received: from DLEE103.ent.ti.com (157.170.170.33) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Wed, 7 Aug 2024 00:42:45 -0500 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Wed, 7 Aug 2024 00:42:44 -0500 Received: from localhost (uda0497581.dhcp.ti.com [10.24.68.185]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 4775giF2044533; Wed, 7 Aug 2024 00:42:44 -0500 Date: Wed, 7 Aug 2024 11:12:43 +0530 From: Manorit Chawdhry To: Neha Malcom Francis CC: Nishanth Menon , Andrew Davis , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , , , , Aniket Limaye , Udit Kumar , Beleswar Padhi , Siddharth Vadapalli Subject: Re: [PATCH v3 1/5] arm64: dts: ti: k3-j721s2*: Add bootph-* properties Message-ID: <20240807054243.pvfgexgusahe7d4x@uda0497581> References: <20240730-b4-upstream-bootph-all-v3-0-9bc2eccb6952@ti.com> <20240730-b4-upstream-bootph-all-v3-1-9bc2eccb6952@ti.com> <20240806150700.uw4xdanjr4ypdvm3@rasping> <20240807052628.jclbmw4zs72jm6km@uda0497581> <8a910e2f-aaf2-40cd-8131-a1a2531a12c8@ti.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <8a910e2f-aaf2-40cd-8131-a1a2531a12c8@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Hi Neha, On 11:03-20240807, Neha Malcom Francis wrote: > Hi Manorit > > On 07/08/24 10:56, Manorit Chawdhry wrote: > > Hi Nishanth, > > > > On 10:07-20240806, Nishanth Menon wrote: > > > On 09:43-20240806, Andrew Davis wrote: > > > > On 7/30/24 4:53 AM, Manorit Chawdhry wrote: > > > > > Adds bootph-* properties to the leaf nodes to enable U-boot to > > > > > utilise them. > > > > > > > > U-Boot? Let's try to pretend like this is a generic property and > > > > just say "bootloader" :) > > > > > @@ -445,6 +446,7 @@ flash@0 { > > > > > cdns,tchsh-ns = <60>; > > > > > cdns,tslch-ns = <60>; > > > > > cdns,read-delay = <4>; > > > > > + bootph-all; > > > > > > Here and elsewhere, follow: > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst#n117 > > > > Could you tell me what are you seeing wrong? The dts-coding-style that > > you shared doesn't tell a specific location for bootph-* properties so > > using the generic reasoning. > > > > "1. Most important properties start the node: compatible then bus addressing to > > match unit address." > > > > This is the least important property considering Linux and hence the > > reasoning was that it should come in the last. Also, j722s and am62p > > follow the same convention so it was taken from there only. > > > > Not sure if this is what he meant, but bootph-* comes under standard/common > properties as per my understanding of the coding style. And status needs to > be at the very end if it's there (in this case it's not but just > mentioning). I see status property being at the top of many nodes so I don't think it's even followed right now, with that reasoning, I don't think I can use that point for ordering the dt nodes. If it's under common nodes then also I think it's in the appropriate location considering that even in those properties it is the least important and should be coming in the last. If you see any problem with this node then please let me know in the ordering. Regards, Manorit > > > Regards, > > Manorit > > > > > > > > > > > > > }; > > > > > }; > > > > > > > > > > > -- > > > Regards, > > > Nishanth Menon > > > Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D > > -- > Thanking You > Neha Malcom Francis