* [PATCH] dt-bindings: memory-controllers: fsl,imx-weim: Fix "fsl,weim-cs-timing" schema
@ 2024-08-07 22:59 Rob Herring (Arm)
2024-08-08 2:20 ` Peng Fan
2024-08-08 15:24 ` Krzysztof Kozlowski
0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring (Arm) @ 2024-08-07 22:59 UTC (permalink / raw)
To: Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam
Cc: linux-kernel, devicetree, imx, linux-arm-kernel
The "fsl,weim-cs-timing" property is an array, but the constraints in
the if/then schema are for a matrix. That worked fine when all
properties were decoded into a matrix, but now dtschema decodes
properties into scalars and arrays based on their type.
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
.../memory-controllers/fsl/fsl,imx-weim.yaml | 25 ++++++++-----------
1 file changed, 11 insertions(+), 14 deletions(-)
diff --git a/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,imx-weim.yaml b/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,imx-weim.yaml
index 3f40ca5b13f6..ce4ec94a561c 100644
--- a/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,imx-weim.yaml
+++ b/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,imx-weim.yaml
@@ -134,9 +134,8 @@ allOf:
properties:
fsl,weim-cs-timing:
items:
- items:
- - description: CSxU
- - description: CSxL
+ - description: CSxU
+ - description: CSxL
- if:
properties:
compatible:
@@ -151,10 +150,9 @@ allOf:
properties:
fsl,weim-cs-timing:
items:
- items:
- - description: CSCRxU
- - description: CSCRxL
- - description: CSCRxA
+ - description: CSCRxU
+ - description: CSCRxL
+ - description: CSCRxA
- if:
properties:
compatible:
@@ -171,13 +169,12 @@ allOf:
properties:
fsl,weim-cs-timing:
items:
- items:
- - description: CSxGCR1
- - description: CSxGCR2
- - description: CSxRCR1
- - description: CSxRCR2
- - description: CSxWCR1
- - description: CSxWCR2
+ - description: CSxGCR1
+ - description: CSxGCR2
+ - description: CSxRCR1
+ - description: CSxRCR2
+ - description: CSxWCR1
+ - description: CSxWCR2
additionalProperties: false
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] dt-bindings: memory-controllers: fsl,imx-weim: Fix "fsl,weim-cs-timing" schema
2024-08-07 22:59 [PATCH] dt-bindings: memory-controllers: fsl,imx-weim: Fix "fsl,weim-cs-timing" schema Rob Herring (Arm)
@ 2024-08-08 2:20 ` Peng Fan
2024-08-08 15:24 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Peng Fan @ 2024-08-08 2:20 UTC (permalink / raw)
To: Rob Herring (Arm), Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org
> Subject: [PATCH] dt-bindings: memory-controllers: fsl,imx-weim: Fix
> "fsl,weim-cs-timing" schema
>
> The "fsl,weim-cs-timing" property is an array, but the constraints in the
> if/then schema are for a matrix. That worked fine when all properties
> were decoded into a matrix, but now dtschema decodes properties into
> scalars and arrays based on their type.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Acked-by: Peng Fan <peng.fan@nxp.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: memory-controllers: fsl,imx-weim: Fix "fsl,weim-cs-timing" schema
2024-08-07 22:59 [PATCH] dt-bindings: memory-controllers: fsl,imx-weim: Fix "fsl,weim-cs-timing" schema Rob Herring (Arm)
2024-08-08 2:20 ` Peng Fan
@ 2024-08-08 15:24 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-08 15:24 UTC (permalink / raw)
To: Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Rob Herring (Arm)
Cc: linux-kernel, devicetree, imx, linux-arm-kernel
On Wed, 07 Aug 2024 16:59:58 -0600, Rob Herring (Arm) wrote:
> The "fsl,weim-cs-timing" property is an array, but the constraints in
> the if/then schema are for a matrix. That worked fine when all
> properties were decoded into a matrix, but now dtschema decodes
> properties into scalars and arrays based on their type.
>
>
Applied, thanks!
[1/1] dt-bindings: memory-controllers: fsl,imx-weim: Fix "fsl,weim-cs-timing" schema
https://git.kernel.org/krzk/linux-mem-ctrl/c/e3e4e77140b4a240865309cc543141a593be4a21
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-08 15:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-07 22:59 [PATCH] dt-bindings: memory-controllers: fsl,imx-weim: Fix "fsl,weim-cs-timing" schema Rob Herring (Arm)
2024-08-08 2:20 ` Peng Fan
2024-08-08 15:24 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox