From: Conor Dooley <conor@kernel.org>
To: Frank Li <Frank.Li@nxp.com>
Cc: Shawn Guo <shawnguo@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
"moderated list:ARM/FREESCALE LAYERSCAPE ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
imx@lists.linux.dev
Subject: Re: [PATCH 1/1] arm64: dts: lx2160a: Change PCIe compatible string to fsl,ls2088a-pcie
Date: Thu, 8 Aug 2024 16:34:32 +0100 [thread overview]
Message-ID: <20240808-frosted-voicing-883f4f728527@spud> (raw)
In-Reply-To: <20240808153120.3305203-1-Frank.Li@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 669 bytes --]
On Thu, Aug 08, 2024 at 11:31:20AM -0400, Frank Li wrote:
> The mass production lx2160 rev2 use designware PCIe Controller. Old Rev1
> which use mobivel PCIe controller was not supported. Although uboot
> fixup can change compatible string fsl,lx2160a-pcie to fsl,ls2088a-pcie
> since 2019, it is quite confused and should correctly reflect hardware
> status in fsl-lx2160a.dtsi.
This does not begin to explain why removing the soc-specific compatible,
and instead putting the compatible for another soc is the right fix.
Come up with a new compatible for this device, that perhaps falls back
to the ls2088a, but this change doesn't seem right to me.
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-08-08 15:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 15:31 [PATCH 1/1] arm64: dts: lx2160a: Change PCIe compatible string to fsl,ls2088a-pcie Frank Li
2024-08-08 15:34 ` Conor Dooley [this message]
2024-08-08 15:51 ` Frank Li
2024-08-08 15:55 ` Conor Dooley
2024-08-08 16:15 ` Frank Li
2024-08-09 15:07 ` Conor Dooley
2024-08-09 17:11 ` Frank Li
2024-08-10 12:21 ` Krzysztof Kozlowski
2024-08-12 17:29 ` Rob Herring
2024-08-12 19:08 ` Frank Li
2024-08-12 23:29 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240808-frosted-voicing-883f4f728527@spud \
--to=conor@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox