From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A6D615624D for ; Thu, 8 Aug 2024 12:01:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723118483; cv=none; b=bllEuwwqjyX8XK1MvF4QHbBoZsBgNs7pLV/Ej/2qJycKs5YD2hsGnMONslPLvqWQLuMehmJUBrWc/u44GPPIquqHwQnKVy1DfL/HS8jxyg60XCwdurhyUb5+tFt3QZ24Vpg4Dcib8KdYy62dfW33ITgo0416jh6LwyPQSVjTVVQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723118483; c=relaxed/simple; bh=v1/ezKij1Xb1/LM0FzxebKnX6GG097BFMwzk7oYzp/o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PjtDsYZk69QUZKwbdafhD0ZUQ1X414QNmEyMo0K3yjnkRHk+vHJDHvRuhMNmDCsvh4pZCrMffY3IhwMAy1jSxAXeag2PZHWb1sUWG8GVYQrerceazag99osOP568gTRWjrFV1KTjlTeHWwvTM/B+YUph3M/10bAa2ay5rL+SO2U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=oG4ktlny; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oG4ktlny" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1fc5296e214so9205175ad.0 for ; Thu, 08 Aug 2024 05:01:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1723118481; x=1723723281; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=x56HaYfAguqXwkXH/W0VkzCpF6NMLJ6hsKX1WsF80Hc=; b=oG4ktlnyivgSythmARtVDS0DcvSmdkuwukckwShy20aF0fGS76+jy5OpA7uJUrvy3e KhpCdWg+kvqulKeRS+twAoDDrSROJmn2/5WiCavoXJRPi6C+RYPH3kdZocKInrIwp0/S clGJ9jZeHMXfCAriAE+sgRdN2+PQJM+NV+/brsYNT+RpoGQh8/isJ9cu/a1k/Pcn2Flf vVR1Yqf8as1rbta0++So2bXS1QGup015HSyXHzYKRDAS6gYs0GrXQ1fnVJ3AqAiy2iV1 qTK4bZrmRoBASnuNCzjluyuEHIIyd0WfD6gLyxsZ3orAKczP4jpx1Qe1Rdhp2FZ4kkMf RiFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723118481; x=1723723281; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=x56HaYfAguqXwkXH/W0VkzCpF6NMLJ6hsKX1WsF80Hc=; b=V9IdQXqSkNpxeK3TZlq4wTLCQx2caHCcdalaEvfUso73cyd20SoylMQwrflXxES4xW LJT6v4LCQHL3Q8diyGphyscAo5Vl32SzXBGTnLVBy56cxMygNLX4iORZj7c2OYmW5r9B IJADWw47K+hlHyQVpKvwY/F6WD4U7qYgAn5vH4cjNYqHohhGJver5xNX+cBrXO0A4Irg 2OTWkV8BhB1h44MetUZ9++jZR59uhgK5+9+/R20X0r4wqFi1lwQKmXpNIZ4jsSzI1+6h lQXqHK3MOZTdn/j4omZgyq4XiW97w6d/MhCL9lcFza9t5jUOa9hCTLbCfXs9Mfei8e8i KVKQ== X-Forwarded-Encrypted: i=1; AJvYcCV4iuhFv2jny088G6Gj7pgbmKjpG1Uy0pzVl6XavgWK7TpimfoFMEXj5Y3Pigd2YV6v4auq9TjAK0xUcjuR0JIwn4JLLCuGClvisA== X-Gm-Message-State: AOJu0Ywbc7q0ptcLW3eD/kUrKy6deVCtW6DhlQLfgUXzwInMEbfhhy6a dBUT1WowEodpSRyQaJcNkcwV53ebI4M1M6uguZfPPwjVrdA3joCTE6MmzXTbAg== X-Google-Smtp-Source: AGHT+IHer9Cx3RKHDR+QrEa4bUNXipYY8dzX3QCoI0MnxJJA0/SxKpWCbY7pKxl6gWV8lep00FD9dg== X-Received: by 2002:a17:902:f605:b0:1fd:6766:6877 with SMTP id d9443c01a7336-20095224b8dmr25116925ad.2.1723118480848; Thu, 08 Aug 2024 05:01:20 -0700 (PDT) Received: from thinkpad ([120.60.136.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2d1b3ad01d4sm3285656a91.23.2024.08.08.05.01.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Aug 2024 05:01:20 -0700 (PDT) Date: Thu, 8 Aug 2024 17:31:09 +0530 From: Manivannan Sadhasivam To: Krzysztof Kozlowski Cc: Bjorn Andersson , Krishna Chaitanya Chundru , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , cros-qcom-dts-watchers@chromium.org, Bartosz Golaszewski , Jingoo Han , andersson@kernel.org, quic_vbadigan@quicinc.com, linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH v2 1/8] dt-bindings: PCI: Add binding for qps615 Message-ID: <20240808120109.GA18983@thinkpad> References: <20240803-qps615-v2-0-9560b7c71369@quicinc.com> <20240803-qps615-v2-1-9560b7c71369@quicinc.com> <5f65905c-f1e4-4f52-ba7c-10c1a4892e30@kernel.org> <90582c92-ca50-4776-918d-b7486cf942b0@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <90582c92-ca50-4776-918d-b7486cf942b0@kernel.org> On Mon, Aug 05, 2024 at 07:18:04PM +0200, Krzysztof Kozlowski wrote: > On 05/08/2024 19:07, Bjorn Andersson wrote: > > On Mon, Aug 05, 2024 at 09:41:26AM +0530, Krishna Chaitanya Chundru wrote: > >> On 8/4/2024 2:23 PM, Krzysztof Kozlowski wrote: > >>> On 03/08/2024 05:22, Krishna chaitanya chundru wrote: > >>>> diff --git a/Documentation/devicetree/bindings/pci/qcom,qps615.yaml b/Documentation/devicetree/bindings/pci/qcom,qps615.yaml > > [..] > >>>> + qps615,axi-clk-freq-hz: > >>>> + description: > >>>> + AXI clock which internal bus of the switch. > >>> > >>> No need, use CCF. > >>> > >> ack > > > > This is a clock that's internal to the QPS615, so there's no clock > > controller involved and hence I don't think CCF is applicable. > > AXI does not sound that internal. Well, AXI is applicable to whatever entity that implements it. We mostly seen it in ARM SoCs (host), but in this case the PCIe switch also has a microcontroller /processor of some sort, so AXI is indeed relevant for it. The naming actually comes from the switch's i2c register name that is being configured in the driver based on this property value. > DT rarely needs to specify internal > clock rates. What if you want to define rates for 20 clocks? Even > clock-frequency is deprecated, so why this would be allowed? > bus-frequency is allowed for buses, but that's not the case here, I guess? > This clock frequency is for the switch's internal AXI bus that runs at default 200MHz. And this property is used to specify a frequency that is configured over the i2c interface so that the switch's AXI bus can operate in a low frequency there by reducing the power consumption of the switch. It is not strictly needed for the switch operation, but for power optimization. So this property can also be dropped for the initial submission and added later if you prefer. - Mani -- மணிவண்ணன் சதாசிவம்