From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66E5F18C357 for ; Thu, 8 Aug 2024 12:41:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723120900; cv=none; b=M5Czj1chYBFF9rmA97TmAGkienggv8wuFItQRHUdGnpiB1xr6ya4cPRzpxGHGyvNupRfB5yaB0LSoao/NbwGI+/RoDysGu8ONdUdwxIlmBAysxlBhyjVHvS2/EzcRzoeLjDqKZerzIWqcdu/qdvS2PptGMPfhwlQ4+4JX73wF40= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723120900; c=relaxed/simple; bh=hkr9WGJyGQYdEgES+RHkmsEEcDQ7Ewuv/VkdQZ3r+oY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TAvxweMw+4TJMHRI7tkJSGOVZlrUNQw7XY0Sc/4haWeokuYyOdJTtMlEdIKNXDYFk8WOI589m6p0DsxhxDoxRjHmzZ3mvbQHlX3pu4+CxwTRH4s5Qk1rKfawB5k5HkrdEmC+tDi+b2gCs6NKQJjd9owvMrV6+LGBwRGD62ARIos= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=xq9yiwAV; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xq9yiwAV" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-2d1c1fb5cafso487261a91.2 for ; Thu, 08 Aug 2024 05:41:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1723120899; x=1723725699; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=JDkeMjSSE/q2/D8tDcbbL2oQ2eQNUSlKo6jAVgmOk6M=; b=xq9yiwAVNUmug7tzVNyD33SU45x0/3u8ee3a+Sib94iycdgFESyDcRX3OhtlXJRA+v 05eSprXbrC9JwbK7TUfl3TvEoqmHRxpuhdEIAwk7PHL+tDUrH9Ht8Fhzn6asggZMF/ZW +yvrOrODoOyzlHfudj3tg4vw0jKgZDLvBQ4EXNomCmKlFUiadNrDw2oE+Rz5d6mTuyXt 2nbLNcN+PpKm+5VYpatYYNXsClOTRwJ2VcuX1dg9CP3PzVGVt1nXniZwK45Ikpq7wNkx lrT1URgIc/MfjZnjhx27IeX+zp+u7QTVdM5Ly50VX1MyAGax7m9JiVrKxUr46gRiaJSW hzzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723120899; x=1723725699; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JDkeMjSSE/q2/D8tDcbbL2oQ2eQNUSlKo6jAVgmOk6M=; b=WJw7yz4vxp/tHKpG30M2NXeuCVhFIr2TPhHhSFKAjKjM6BcgG9lKz3OERJEawUkKf6 1k+eiGpU7/LrwrHK4n/lKSXa9J/hKPXhabHoPrDf1iKTDu9dZgtes7991i3FywmPsxbG wdjxXT3BEgkJidot5IBeY5OxQJENCg9LgEwwi5tOXQIa1kaWuKKUv7j6lfSnqVqfllb/ x/Rk9vqwaPElBHE6cRNZq+iqiuL528pooJsJUGyQjn1jxn+6nLj7fBF+0N1P3UpZ6Ia7 Ow1CyUL/SnvFdh70cavw1dMiD4kl7Go0AI25WFqQOCDo6+iZXWPElemTy+gXy74GvqfS kEVw== X-Forwarded-Encrypted: i=1; AJvYcCV2K5oZMlCU/HGePTE6H12hRH4T7/1HiDSdDeTdLVjlcuSNw7pazoBwOaC5Fo6fPgCtyofuQiHm5LpZFe7ZBaKVYG036jrHVen0pQ== X-Gm-Message-State: AOJu0Yyzh/kI8XluRXM8BSBnvtnLpaKTV8d67nh0Mc0v+OhUQXtYS/Kz 9VbD/f066pVlYSKRI7VKKk8zgzN+7IanDjE0/HyYzyz1xAkpupy2Lon+UPmmGA== X-Google-Smtp-Source: AGHT+IHhEQXIaC4hSwtqImtR0VaMhf/q4UqBwMBcF5Q5CSvQc/aZj4QJVZX5anT30C7V8NQ1r/Dw/A== X-Received: by 2002:a17:90a:17e2:b0:2cb:4c06:8f11 with SMTP id 98e67ed59e1d1-2d1c33f070fmr2059832a91.22.1723120898644; Thu, 08 Aug 2024 05:41:38 -0700 (PDT) Received: from thinkpad ([120.60.136.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2d1b3ab9b3fsm3391453a91.20.2024.08.08.05.41.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Aug 2024 05:41:38 -0700 (PDT) Date: Thu, 8 Aug 2024 18:11:21 +0530 From: Manivannan Sadhasivam To: Krzysztof Kozlowski Cc: Bjorn Andersson , Krishna Chaitanya Chundru , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , cros-qcom-dts-watchers@chromium.org, Bartosz Golaszewski , Jingoo Han , andersson@kernel.org, quic_vbadigan@quicinc.com, linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH v2 1/8] dt-bindings: PCI: Add binding for qps615 Message-ID: <20240808124121.GB18983@thinkpad> References: <20240803-qps615-v2-0-9560b7c71369@quicinc.com> <20240803-qps615-v2-1-9560b7c71369@quicinc.com> <5f65905c-f1e4-4f52-ba7c-10c1a4892e30@kernel.org> <90582c92-ca50-4776-918d-b7486cf942b0@kernel.org> <20240808120109.GA18983@thinkpad> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Aug 08, 2024 at 02:13:01PM +0200, Krzysztof Kozlowski wrote: > On 08/08/2024 14:01, Manivannan Sadhasivam wrote: > > On Mon, Aug 05, 2024 at 07:18:04PM +0200, Krzysztof Kozlowski wrote: > >> On 05/08/2024 19:07, Bjorn Andersson wrote: > >>> On Mon, Aug 05, 2024 at 09:41:26AM +0530, Krishna Chaitanya Chundru wrote: > >>>> On 8/4/2024 2:23 PM, Krzysztof Kozlowski wrote: > >>>>> On 03/08/2024 05:22, Krishna chaitanya chundru wrote: > >>>>>> diff --git a/Documentation/devicetree/bindings/pci/qcom,qps615.yaml b/Documentation/devicetree/bindings/pci/qcom,qps615.yaml > >>> [..] > >>>>>> + qps615,axi-clk-freq-hz: > >>>>>> + description: > >>>>>> + AXI clock which internal bus of the switch. > >>>>> > >>>>> No need, use CCF. > >>>>> > >>>> ack > >>> > >>> This is a clock that's internal to the QPS615, so there's no clock > >>> controller involved and hence I don't think CCF is applicable. > >> > >> AXI does not sound that internal. > > > > Well, AXI is applicable to whatever entity that implements it. We mostly seen it > > in ARM SoCs (host), but in this case the PCIe switch also has a microcontroller > > /processor of some sort, so AXI is indeed relevant for it. The naming actually > > comes from the switch's i2c register name that is being configured in the driver > > based on this property value. > > > >> DT rarely needs to specify internal > >> clock rates. What if you want to define rates for 20 clocks? Even > >> clock-frequency is deprecated, so why this would be allowed? > >> bus-frequency is allowed for buses, but that's not the case here, I guess? > >> > > > > This clock frequency is for the switch's internal AXI bus that runs at default > > 200MHz. And this property is used to specify a frequency that is configured over > > the i2c interface so that the switch's AXI bus can operate in a low frequency > > there by reducing the power consumption of the switch. > > > > It is not strictly needed for the switch operation, but for power optimization. > > So this property can also be dropped for the initial submission and added later > > if you prefer. > > So if the clock rate can change, why this is static in DTB? Or why this > is configurable per-board? > Because, board manufacturers can change the frequency depending on the switch configuration (enablement of DSP's etc...) > There is a reason why clock-frequency property is not welcomed and you > are re-implementing it. > Hmm, I'm not aware that 'clock-frequency' is not encouraged these days. So you are suggesting to change the rate in the driver itself based on the switch configuration? If so, what difference does it make? And no more *-freq properties are allowed? - Mani -- மணிவண்ணன் சதாசிவம்