From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2006B4D112; Mon, 12 Aug 2024 15:55:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723478143; cv=none; b=ttcQGTtlmJwOEPySGW7Oz2Idlt3TCVLgeuoOdKW1ErHKUe5tlZPGKDN6Q8X2FcneBtsVz1hTtqGhGH7ovv8+tA64JLDjR6tFdzHSAUjUtUJXtJldN2mOIpkv8wrXmBMTjga/7QYUeDINYABg7fGZDmru6NCTvSZ6MCzWKxAmaSU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723478143; c=relaxed/simple; bh=fIxgfU9U7UdKHCzgTt5JxPxYSDRiI+jpNpkMi6cCmNM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Qhrt7jdDYSXF27kr1Cd4qhVMjgBr861VHTNIkjI6sdYOQTAOyqx2h0G9iFOcThJPRsmgFRwH499/QFjhr/NT7aKrRxEJIwue4+7PtanKVNXBItq56OVG3/XtStHL9q6wBa/x1GL+fOAIF/uzYsfs5rAP0qVgaCo4hg+t7lxNrFs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=P3mgSpRi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="P3mgSpRi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6098DC32782; Mon, 12 Aug 2024 15:55:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723478142; bh=fIxgfU9U7UdKHCzgTt5JxPxYSDRiI+jpNpkMi6cCmNM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P3mgSpRiCH/hfVz2HIjVM3C3Yq1lKI/jniZJcW7Ur61Ag1fqi65ipjx2ct84DMI7M ysFCCNySYeQc9/SjndDB+u/vUZB6yel/3PTpuALkdKCzgb4fEN+R4JpiF47QioSeDx q6hQE6XJuufABIB5Cyn/PVzhgYEyCxcpi8w73daUvRcKkqS+mhH0QCfPlsLZ70vXxU 1maqNbGWxk3KsNl93e3FEmNsxc/oM6locRh/VSratxEfDtPff5xHOOblWkXV1nLL82 JFWjibQXr6QkjDKkLp5iLrFxtvilJGf/NEtL1Zakmnt3L2hh5WyJ0Sx07x7rOmUZfs QkQN7t4vp1Idw== Date: Mon, 12 Aug 2024 16:55:38 +0100 From: Conor Dooley To: Jan Kiszka Cc: Minda Chen , Vinod Koul , Kishon Vijay Abraham I , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Dan Carpenter , Rob Herring , Krzysztof Kozlowski , Conor Dooley Subject: Re: [PATCH v2 1/3] dt-bindings: phy: jh7110-usb-phy: Add sys-syscon property Message-ID: <20240812-overstuff-skirt-7a8aabbcdc6f@spud> References: <30f3ca9f6bd788e16767b36aa22c0e9dc4d1c6a4.1723472153.git.jan.kiszka@siemens.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LtVVHt/+tPGAV+JK" Content-Disposition: inline In-Reply-To: <30f3ca9f6bd788e16767b36aa22c0e9dc4d1c6a4.1723472153.git.jan.kiszka@siemens.com> --LtVVHt/+tPGAV+JK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 12, 2024 at 04:15:51PM +0200, Jan Kiszka wrote: > From: Jan Kiszka >=20 > Analogously to the PCI PHY, access to sys_syscon is needed to connect > the USB PHY to its controller. >=20 > Signed-off-by: Jan Kiszka > Reviewed-by: Rob Herring (Arm) > --- > CC: Rob Herring > CC: Krzysztof Kozlowski > CC: Conor Dooley > --- > .../bindings/phy/starfive,jh7110-usb-phy.yaml | 11 +++++++++++ > 1 file changed, 11 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/phy/starfive,jh7110-usb-ph= y.yaml b/Documentation/devicetree/bindings/phy/starfive,jh7110-usb-phy.yaml > index 269e9f9f12b6..eaf0050c6f17 100644 > --- a/Documentation/devicetree/bindings/phy/starfive,jh7110-usb-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/starfive,jh7110-usb-phy.yaml > @@ -19,6 +19,16 @@ properties: > "#phy-cells": > const: 0 > =20 > + starfive,sys-syscon: > + $ref: /schemas/types.yaml#/definitions/phandle-array > + items: > + - items: > + - description: phandle to System Register Controller sys_sysco= n node. > + - description: PHY connect offset of SYS_SYSCONSAIF__SYSCFG re= gister for USB PHY. Why is having a new property for this required? The devicetree only has a single usb phy, so isn't it sufficient to look up the syscon by compatible, rather than via phandle + offset? > + description: > + The phandle to System Register Controller syscon node and the PHY = connect offset > + of SYS_SYSCONSAIF__SYSCFG register. Connect PHY to USB controller. > + > clocks: > items: > - description: PHY 125m > @@ -47,4 +57,5 @@ examples: > <&stgcrg 6>; > clock-names =3D "125m", "app_125m"; > #phy-cells =3D <0>; > + starfive,sys-syscon =3D <&sys_syscon 0x18>; > }; > --=20 > 2.43.0 >=20 --LtVVHt/+tPGAV+JK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZrowegAKCRB4tDGHoIJi 0gXFAP9irfiKqj3CaOoVEdmxFBQbHAu8wbJBdmXuGodai0OMaQEAp0i//vC20L1l o+8FpvJ1Mt/ZC28yMFhDKZtipTS5rgc= =rBq+ -----END PGP SIGNATURE----- --LtVVHt/+tPGAV+JK--