Re: [PATCH V3 RESEND 2/4] dt-bindings: interrupt-controller: convert bcm2836-l1-intc to yaml

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 4054 bytes --]

On Mon, Aug 12, 2024 at 10:03:56PM +0200, Stefan Wahren wrote:
> Convert the DT binding document for BCM2836 per-CPU interrupt
> controller from .txt to YAML.
> 
> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
> ---
>  .../brcm,bcm2836-l1-intc.txt                  | 37 --------------
>  .../brcm,bcm2836-l1-intc.yaml                 | 51 +++++++++++++++++++
>  2 files changed, 51 insertions(+), 37 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/brcm,bcm2836-l1-intc.txt
>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/brcm,bcm2836-l1-intc.yaml
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm2836-l1-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm2836-l1-intc.txt
> deleted file mode 100644
> index 8ced1696c325..000000000000
> --- a/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm2836-l1-intc.txt
> +++ /dev/null
> @@ -1,37 +0,0 @@
> -BCM2836 per-CPU interrupt controller
> -
> -The BCM2836 has a per-cpu interrupt controller for the timer, PMU
> -events, and SMP IPIs.  One of the CPUs may receive interrupts for the
> -peripheral (GPU) events, which chain to the BCM2835-style interrupt
> -controller.
> -
> -Required properties:
> -
> -- compatible:	 	Should be "brcm,bcm2836-l1-intc"
> -- reg:			Specifies base physical address and size of the
> -			  registers
> -- interrupt-controller:	Identifies the node as an interrupt controller
> -- #interrupt-cells:	Specifies the number of cells needed to encode an
> -			  interrupt source. The value shall be 2
> -
> -Please refer to interrupts.txt in this directory for details of the common
> -Interrupt Controllers bindings used by client devices.
> -
> -The interrupt sources are as follows:
> -
> -0: CNTPSIRQ
> -1: CNTPNSIRQ
> -2: CNTHPIRQ
> -3: CNTVIRQ
> -8: GPU_FAST
> -9: PMU_FAST
> -
> -Example:
> -
> -local_intc: local_intc {
> -	compatible = "brcm,bcm2836-l1-intc";
> -	reg = <0x40000000 0x100>;
> -	interrupt-controller;
> -	#interrupt-cells = <2>;
> -	interrupt-parent = <&local_intc>;
> -};
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm2836-l1-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm2836-l1-intc.yaml
> new file mode 100644
> index 000000000000..5fda626c80ce
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm2836-l1-intc.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/interrupt-controller/brcm,bcm2836-l1-intc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: BCM2836 per-CPU interrupt controller
> +
> +maintainers:
> +  - Stefan Wahren <wahrenst@gmx.net>
> +  - Raspberry Pi Kernel Maintenance <kernel-list@raspberrypi.com>
> +
> +description:
> +  The BCM2836 has a per-cpu interrupt controller for the timer, PMU
> +  events, and SMP IPIs. One of the CPUs may receive interrupts for the
> +  peripheral (GPU) events, which chain to the BCM2835-style interrupt
> +  controller.
> +
> +allOf:
> +  - $ref: /schemas/interrupt-controller.yaml#
> +
> +properties:
> +  compatible:
> +    const: brcm,bcm2836-l1-intc
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupt-controller: true
> +
> +  '#interrupt-cells':
> +    const: 2
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupt-controller
> +  - '#interrupt-cells'
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    local_intc: interrupt-controller@40000000 {

If, for some reason, there's a respin - drop the label.
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

> +        compatible = "brcm,bcm2836-l1-intc";
> +        reg = <0x40000000 0x100>;
> +        interrupt-controller;
> +        #interrupt-cells = <2>;
> +        interrupt-parent = <&local_intc>;
> +    };
> +...
> --
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]