From: Rob Herring <robh@kernel.org>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Matthias Kaehlcke <mka@chromium.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Fabio Estevam <festevam@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
kernel@pengutronix.de, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: usb: microchip,usb2514: add support for port vbus-supply
Date: Tue, 13 Aug 2024 12:57:52 -0600 [thread overview]
Message-ID: <20240813185752.GA1423091-robh@kernel.org> (raw)
In-Reply-To: <20240807-b4-v6-10-topic-usb-onboard-dev-v1-2-f33ce21353c9@pengutronix.de>
On Wed, Aug 07, 2024 at 04:36:52PM +0200, Marco Felsch wrote:
> Some PCB designs don't connect the USB hub port power control GPIO and
> instead make use of an host controllable regulator. Add support for this
> use-case by introducing an portX-vbus-supply property.
>
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
> Documentation/devicetree/bindings/usb/microchip,usb2514.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml
> index 783c27591e56..51d02c4b8f2d 100644
> --- a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml
> +++ b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml
> @@ -35,6 +35,13 @@ required:
> - compatible
> - reg
>
> +patternProperties:
> + "^port[1-7]-vbus-supply$"
> + type: object
> + description:
> + Regulator controlling the USB VBUS on portX. Only required if the host
> + controls the portX VBUS.
This is completely external to the Microchip part, right?
I think each port node should have a 'vbus-supply' property instead.
Rob
next prev parent reply other threads:[~2024-08-13 18:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-07 14:36 [PATCH 0/3] External VBUS port power handling for onboard USB devices Marco Felsch
2024-08-07 14:36 ` [PATCH 1/3] usb: hub: add infrastructure to pass onboard_dev port features Marco Felsch
2024-08-08 7:50 ` kernel test robot
2024-08-09 9:33 ` Marco Felsch
2024-09-23 9:56 ` Matthias Kaehlcke
2024-10-28 21:49 ` Marco Felsch
2024-12-31 9:34 ` Junzhong Pan
2025-01-06 6:52 ` Marco Felsch
2025-01-10 7:37 ` Junzhong Pan
2025-03-03 10:25 ` Marco Felsch
2024-08-08 13:06 ` kernel test robot
2024-08-07 14:36 ` [PATCH 2/3] dt-bindings: usb: microchip,usb2514: add support for port vbus-supply Marco Felsch
2024-08-13 18:57 ` Rob Herring [this message]
2024-08-14 13:41 ` Marco Felsch
2024-08-07 14:36 ` [PATCH 3/3] usb: misc: onboard_dev: add ext-vbus-supply handling Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240813185752.GA1423091-robh@kernel.org \
--to=robh@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=mka@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).