* [PATCH v2 01/11] dt-bindings: arm: qcom,ids: Add IDs for SM7325 family
2024-08-08 18:40 [PATCH v2 00/11] Add Nothing Phone (1) support Danila Tikhonov
@ 2024-08-08 18:40 ` Danila Tikhonov
2024-08-08 18:40 ` [PATCH v2 02/11] soc: qcom: socinfo: Add Soc " Danila Tikhonov
` (11 subsequent siblings)
12 siblings, 0 replies; 27+ messages in thread
From: Danila Tikhonov @ 2024-08-08 18:40 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, andersson, konradybcio, davem, edumazet,
kuba, pabeni, rafael, viresh.kumar, kees, tony.luck, gpiccoli,
ulf.hansson, andre.przywara, quic_rjendra, davidwronek,
neil.armstrong, heiko.stuebner, rafal, macromorgan, linus.walleij,
lpieralisi, dmitry.baryshkov, fekz115
Cc: devicetree, linux-kernel, linux-arm-msm, netdev, linux-pm,
linux-hardening, Danila Tikhonov, Krzysztof Kozlowski
Add Qualcomm SM7325/SM7325P (yupik) SoC IDs.
Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
include/dt-bindings/arm/qcom,ids.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
index d6c9e9472121..a4315872049e 100644
--- a/include/dt-bindings/arm/qcom,ids.h
+++ b/include/dt-bindings/arm/qcom,ids.h
@@ -234,11 +234,13 @@
#define QCOM_ID_SA8540P 461
#define QCOM_ID_QCM4290 469
#define QCOM_ID_QCS4290 470
+#define QCOM_ID_SM7325 475
#define QCOM_ID_SM8450_2 480
#define QCOM_ID_SM8450_3 482
#define QCOM_ID_SC7280 487
#define QCOM_ID_SC7180P 495
#define QCOM_ID_QCM6490 497
+#define QCOM_ID_SM7325P 499
#define QCOM_ID_IPQ5000 503
#define QCOM_ID_IPQ0509 504
#define QCOM_ID_IPQ0518 505
--
2.45.2
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH v2 02/11] soc: qcom: socinfo: Add Soc IDs for SM7325 family
2024-08-08 18:40 [PATCH v2 00/11] Add Nothing Phone (1) support Danila Tikhonov
2024-08-08 18:40 ` [PATCH v2 01/11] dt-bindings: arm: qcom,ids: Add IDs for SM7325 family Danila Tikhonov
@ 2024-08-08 18:40 ` Danila Tikhonov
2024-08-08 18:40 ` [PATCH v2 03/11] cpufreq: Add SM7325 to cpufreq-dt-platdev blocklist Danila Tikhonov
` (10 subsequent siblings)
12 siblings, 0 replies; 27+ messages in thread
From: Danila Tikhonov @ 2024-08-08 18:40 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, andersson, konradybcio, davem, edumazet,
kuba, pabeni, rafael, viresh.kumar, kees, tony.luck, gpiccoli,
ulf.hansson, andre.przywara, quic_rjendra, davidwronek,
neil.armstrong, heiko.stuebner, rafal, macromorgan, linus.walleij,
lpieralisi, dmitry.baryshkov, fekz115
Cc: devicetree, linux-kernel, linux-arm-msm, netdev, linux-pm,
linux-hardening, Danila Tikhonov, Krzysztof Kozlowski
Add Soc ID table entries for Qualcomm SM7325 family.
Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/soc/qcom/socinfo.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
index d7359a235e3c..f4e5f7a62206 100644
--- a/drivers/soc/qcom/socinfo.c
+++ b/drivers/soc/qcom/socinfo.c
@@ -401,11 +401,13 @@ static const struct soc_id soc_id[] = {
{ qcom_board_id(SA8540P) },
{ qcom_board_id(QCM4290) },
{ qcom_board_id(QCS4290) },
+ { qcom_board_id(SM7325) },
{ qcom_board_id_named(SM8450_2, "SM8450") },
{ qcom_board_id_named(SM8450_3, "SM8450") },
{ qcom_board_id(SC7280) },
{ qcom_board_id(SC7180P) },
{ qcom_board_id(QCM6490) },
+ { qcom_board_id(SM7325P) },
{ qcom_board_id(IPQ5000) },
{ qcom_board_id(IPQ0509) },
{ qcom_board_id(IPQ0518) },
--
2.45.2
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH v2 03/11] cpufreq: Add SM7325 to cpufreq-dt-platdev blocklist
2024-08-08 18:40 [PATCH v2 00/11] Add Nothing Phone (1) support Danila Tikhonov
2024-08-08 18:40 ` [PATCH v2 01/11] dt-bindings: arm: qcom,ids: Add IDs for SM7325 family Danila Tikhonov
2024-08-08 18:40 ` [PATCH v2 02/11] soc: qcom: socinfo: Add Soc " Danila Tikhonov
@ 2024-08-08 18:40 ` Danila Tikhonov
2024-08-16 2:59 ` Viresh Kumar
2024-08-08 18:40 ` [PATCH v2 04/11] soc: qcom: pd_mapper: Add SM7325 compatible Danila Tikhonov
` (9 subsequent siblings)
12 siblings, 1 reply; 27+ messages in thread
From: Danila Tikhonov @ 2024-08-08 18:40 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, andersson, konradybcio, davem, edumazet,
kuba, pabeni, rafael, viresh.kumar, kees, tony.luck, gpiccoli,
ulf.hansson, andre.przywara, quic_rjendra, davidwronek,
neil.armstrong, heiko.stuebner, rafal, macromorgan, linus.walleij,
lpieralisi, dmitry.baryshkov, fekz115
Cc: devicetree, linux-kernel, linux-arm-msm, netdev, linux-pm,
linux-hardening, Danila Tikhonov
The Qualcomm SM7325 platform uses the qcom-cpufreq-hw driver, so add
it to the cpufreq-dt-platdev driver's blocklist.
Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
drivers/cpufreq/cpufreq-dt-platdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
index cac379ba006d..18942bfe9c95 100644
--- a/drivers/cpufreq/cpufreq-dt-platdev.c
+++ b/drivers/cpufreq/cpufreq-dt-platdev.c
@@ -166,6 +166,7 @@ static const struct of_device_id blocklist[] __initconst = {
{ .compatible = "qcom,sm6350", },
{ .compatible = "qcom,sm6375", },
{ .compatible = "qcom,sm7225", },
+ { .compatible = "qcom,sm7325", },
{ .compatible = "qcom,sm8150", },
{ .compatible = "qcom,sm8250", },
{ .compatible = "qcom,sm8350", },
--
2.45.2
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [PATCH v2 03/11] cpufreq: Add SM7325 to cpufreq-dt-platdev blocklist
2024-08-08 18:40 ` [PATCH v2 03/11] cpufreq: Add SM7325 to cpufreq-dt-platdev blocklist Danila Tikhonov
@ 2024-08-16 2:59 ` Viresh Kumar
0 siblings, 0 replies; 27+ messages in thread
From: Viresh Kumar @ 2024-08-16 2:59 UTC (permalink / raw)
To: Danila Tikhonov
Cc: robh, krzk+dt, conor+dt, andersson, konradybcio, davem, edumazet,
kuba, pabeni, rafael, kees, tony.luck, gpiccoli, ulf.hansson,
andre.przywara, quic_rjendra, davidwronek, neil.armstrong,
heiko.stuebner, rafal, macromorgan, linus.walleij, lpieralisi,
dmitry.baryshkov, fekz115, devicetree, linux-kernel,
linux-arm-msm, netdev, linux-pm, linux-hardening
On 08-08-24, 21:40, Danila Tikhonov wrote:
> The Qualcomm SM7325 platform uses the qcom-cpufreq-hw driver, so add
> it to the cpufreq-dt-platdev driver's blocklist.
>
> Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/cpufreq/cpufreq-dt-platdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
> index cac379ba006d..18942bfe9c95 100644
> --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> @@ -166,6 +166,7 @@ static const struct of_device_id blocklist[] __initconst = {
> { .compatible = "qcom,sm6350", },
> { .compatible = "qcom,sm6375", },
> { .compatible = "qcom,sm7225", },
> + { .compatible = "qcom,sm7325", },
> { .compatible = "qcom,sm8150", },
> { .compatible = "qcom,sm8250", },
> { .compatible = "qcom,sm8350", },
Applied. Thanks.
--
viresh
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH v2 04/11] soc: qcom: pd_mapper: Add SM7325 compatible
2024-08-08 18:40 [PATCH v2 00/11] Add Nothing Phone (1) support Danila Tikhonov
` (2 preceding siblings ...)
2024-08-08 18:40 ` [PATCH v2 03/11] cpufreq: Add SM7325 to cpufreq-dt-platdev blocklist Danila Tikhonov
@ 2024-08-08 18:40 ` Danila Tikhonov
2024-08-08 18:40 ` [PATCH v2 05/11] dt-bindings: soc: qcom: qcom,pmic-glink: Document " Danila Tikhonov
` (8 subsequent siblings)
12 siblings, 0 replies; 27+ messages in thread
From: Danila Tikhonov @ 2024-08-08 18:40 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, andersson, konradybcio, davem, edumazet,
kuba, pabeni, rafael, viresh.kumar, kees, tony.luck, gpiccoli,
ulf.hansson, andre.przywara, quic_rjendra, davidwronek,
neil.armstrong, heiko.stuebner, rafal, macromorgan, linus.walleij,
lpieralisi, dmitry.baryshkov, fekz115
Cc: devicetree, linux-kernel, linux-arm-msm, netdev, linux-pm,
linux-hardening, Danila Tikhonov
The Qualcomm SM7325 platform is identical to SC7280, so add
compatibility leading to SC7280.
Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
drivers/soc/qcom/qcom_pd_mapper.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/soc/qcom/qcom_pd_mapper.c b/drivers/soc/qcom/qcom_pd_mapper.c
index 9afa09c3920e..e8a881977e73 100644
--- a/drivers/soc/qcom/qcom_pd_mapper.c
+++ b/drivers/soc/qcom/qcom_pd_mapper.c
@@ -539,6 +539,7 @@ static const struct of_device_id qcom_pdm_domains[] __maybe_unused = {
{ .compatible = "qcom,sm4250", .data = sm6115_domains, },
{ .compatible = "qcom,sm6115", .data = sm6115_domains, },
{ .compatible = "qcom,sm6350", .data = sm6350_domains, },
+ { .compatible = "qcom,sm7325", .data = sc7280_domains, },
{ .compatible = "qcom,sm8150", .data = sm8150_domains, },
{ .compatible = "qcom,sm8250", .data = sm8250_domains, },
{ .compatible = "qcom,sm8350", .data = sm8350_domains, },
--
2.45.2
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH v2 05/11] dt-bindings: soc: qcom: qcom,pmic-glink: Document SM7325 compatible
2024-08-08 18:40 [PATCH v2 00/11] Add Nothing Phone (1) support Danila Tikhonov
` (3 preceding siblings ...)
2024-08-08 18:40 ` [PATCH v2 04/11] soc: qcom: pd_mapper: Add SM7325 compatible Danila Tikhonov
@ 2024-08-08 18:40 ` Danila Tikhonov
2024-08-09 6:10 ` Krzysztof Kozlowski
2024-08-08 18:40 ` [PATCH v2 06/11] dt-bindings: nfc: nxp,nci: Document PN553 compatible Danila Tikhonov
` (7 subsequent siblings)
12 siblings, 1 reply; 27+ messages in thread
From: Danila Tikhonov @ 2024-08-08 18:40 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, andersson, konradybcio, davem, edumazet,
kuba, pabeni, rafael, viresh.kumar, kees, tony.luck, gpiccoli,
ulf.hansson, andre.przywara, quic_rjendra, davidwronek,
neil.armstrong, heiko.stuebner, rafal, macromorgan, linus.walleij,
lpieralisi, dmitry.baryshkov, fekz115
Cc: devicetree, linux-kernel, linux-arm-msm, netdev, linux-pm,
linux-hardening, Danila Tikhonov
The SM7325 is the closest SoC to the QCM6490 and is also identical
to the SC7280. The SM7325 also requires both UCSI_NO_PARTNER_PDOS &
UCSI_DELAY_DEVICE_PDOS quirks.
Document the PMIC GLINK firmware interface on the SM7325 Platform
by using the QCM6490 bindings as fallback.
Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
---
.../devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
index 4512390f90f0..2d3fe0b54243 100644
--- a/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
+++ b/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
@@ -30,6 +30,11 @@ properties:
- qcom,sm8450-pmic-glink
- qcom,sm8550-pmic-glink
- const: qcom,pmic-glink
+ - items:
+ - enum:
+ - qcom,sm7325-pmic-glink
+ - const: qcom,qcm6490-pmic-glink
+ - const: qcom,pmic-glink
- items:
- enum:
- qcom,sm8650-pmic-glink
--
2.45.2
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [PATCH v2 05/11] dt-bindings: soc: qcom: qcom,pmic-glink: Document SM7325 compatible
2024-08-08 18:40 ` [PATCH v2 05/11] dt-bindings: soc: qcom: qcom,pmic-glink: Document " Danila Tikhonov
@ 2024-08-09 6:10 ` Krzysztof Kozlowski
0 siblings, 0 replies; 27+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-09 6:10 UTC (permalink / raw)
To: Danila Tikhonov, robh, krzk+dt, conor+dt, andersson, konradybcio,
davem, edumazet, kuba, pabeni, rafael, viresh.kumar, kees,
tony.luck, gpiccoli, ulf.hansson, andre.przywara, quic_rjendra,
davidwronek, neil.armstrong, heiko.stuebner, rafal, macromorgan,
linus.walleij, lpieralisi, dmitry.baryshkov, fekz115
Cc: devicetree, linux-kernel, linux-arm-msm, netdev, linux-pm,
linux-hardening
On 08/08/2024 20:40, Danila Tikhonov wrote:
> The SM7325 is the closest SoC to the QCM6490 and is also identical
> to the SC7280. The SM7325 also requires both UCSI_NO_PARTNER_PDOS &
> UCSI_DELAY_DEVICE_PDOS quirks.
>
> Document the PMIC GLINK firmware interface on the SM7325 Platform
> by using the QCM6490 bindings as fallback.
>
> Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
> ---
> .../devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH v2 06/11] dt-bindings: nfc: nxp,nci: Document PN553 compatible
2024-08-08 18:40 [PATCH v2 00/11] Add Nothing Phone (1) support Danila Tikhonov
` (4 preceding siblings ...)
2024-08-08 18:40 ` [PATCH v2 05/11] dt-bindings: soc: qcom: qcom,pmic-glink: Document " Danila Tikhonov
@ 2024-08-08 18:40 ` Danila Tikhonov
2024-08-09 5:39 ` Krzysztof Kozlowski
2024-08-13 19:33 ` Rob Herring (Arm)
2024-08-08 18:40 ` [PATCH v2 07/11] dt-bindings: arm: cpus: Add qcom kryo670 compatible Danila Tikhonov
` (6 subsequent siblings)
12 siblings, 2 replies; 27+ messages in thread
From: Danila Tikhonov @ 2024-08-08 18:40 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, andersson, konradybcio, davem, edumazet,
kuba, pabeni, rafael, viresh.kumar, kees, tony.luck, gpiccoli,
ulf.hansson, andre.przywara, quic_rjendra, davidwronek,
neil.armstrong, heiko.stuebner, rafal, macromorgan, linus.walleij,
lpieralisi, dmitry.baryshkov, fekz115
Cc: devicetree, linux-kernel, linux-arm-msm, netdev, linux-pm,
linux-hardening, Danila Tikhonov
The PN553 is another NFC chip from NXP, document the compatible in the
bindings.
Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
---
Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml b/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml
index 6924aff0b2c5..364b36151180 100644
--- a/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml
+++ b/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml
@@ -17,6 +17,7 @@ properties:
- enum:
- nxp,nq310
- nxp,pn547
+ - nxp,pn553
- const: nxp,nxp-nci-i2c
enable-gpios:
--
2.45.2
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [PATCH v2 06/11] dt-bindings: nfc: nxp,nci: Document PN553 compatible
2024-08-08 18:40 ` [PATCH v2 06/11] dt-bindings: nfc: nxp,nci: Document PN553 compatible Danila Tikhonov
@ 2024-08-09 5:39 ` Krzysztof Kozlowski
2024-08-09 17:38 ` Danila Tikhonov
2024-08-13 19:33 ` Rob Herring
2024-08-13 19:33 ` Rob Herring (Arm)
1 sibling, 2 replies; 27+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-09 5:39 UTC (permalink / raw)
To: Danila Tikhonov, robh, krzk+dt, conor+dt, andersson, konradybcio,
davem, edumazet, kuba, pabeni, rafael, viresh.kumar, kees,
tony.luck, gpiccoli, ulf.hansson, andre.przywara, quic_rjendra,
davidwronek, neil.armstrong, heiko.stuebner, rafal, macromorgan,
linus.walleij, lpieralisi, dmitry.baryshkov, fekz115
Cc: devicetree, linux-kernel, linux-arm-msm, netdev, linux-pm,
linux-hardening
On 08/08/2024 20:40, Danila Tikhonov wrote:
> The PN553 is another NFC chip from NXP, document the compatible in the
> bindings.
>
> Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
> ---
> Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml b/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml
> index 6924aff0b2c5..364b36151180 100644
> --- a/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml
> +++ b/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml
> @@ -17,6 +17,7 @@ properties:
> - enum:
> - nxp,nq310
> - nxp,pn547
> + - nxp,pn553
Keep the list ordered.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v2 06/11] dt-bindings: nfc: nxp,nci: Document PN553 compatible
2024-08-09 5:39 ` Krzysztof Kozlowski
@ 2024-08-09 17:38 ` Danila Tikhonov
2024-08-13 19:33 ` Rob Herring
1 sibling, 0 replies; 27+ messages in thread
From: Danila Tikhonov @ 2024-08-09 17:38 UTC (permalink / raw)
To: Krzysztof Kozlowski, robh, krzk+dt, conor+dt, andersson,
konradybcio, davem, edumazet, kuba, pabeni, rafael, viresh.kumar,
kees, tony.luck, gpiccoli, ulf.hansson, andre.przywara,
quic_rjendra, davidwronek, neil.armstrong, heiko.stuebner, rafal,
macromorgan, linus.walleij, lpieralisi, dmitry.baryshkov, fekz115
Cc: devicetree, linux-kernel, linux-arm-msm, netdev, linux-pm,
linux-hardening, danila
On 8/9/24 08:39, Krzysztof Kozlowski wrote:
> On 08/08/2024 20:40, Danila Tikhonov wrote:
>> The PN553 is another NFC chip from NXP, document the compatible in the
>> bindings.
>>
>> Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
>> ---
>> Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml b/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml
>> index 6924aff0b2c5..364b36151180 100644
>> --- a/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml
>> +++ b/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml
>> @@ -17,6 +17,7 @@ properties:
>> - enum:
>> - nxp,nq310
>> - nxp,pn547
>> + - nxp,pn553
> Keep the list ordered.
>
> Best regards,
> Krzysztof
>
Thanks for your comment.
Then I will fix it for nxp,pn547 too in this patch. Do you mind?
---
Best wishes,
Danila.
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v2 06/11] dt-bindings: nfc: nxp,nci: Document PN553 compatible
2024-08-09 5:39 ` Krzysztof Kozlowski
2024-08-09 17:38 ` Danila Tikhonov
@ 2024-08-13 19:33 ` Rob Herring
2024-08-14 6:00 ` Krzysztof Kozlowski
1 sibling, 1 reply; 27+ messages in thread
From: Rob Herring @ 2024-08-13 19:33 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Danila Tikhonov, krzk+dt, conor+dt, andersson, konradybcio, davem,
edumazet, kuba, pabeni, rafael, viresh.kumar, kees, tony.luck,
gpiccoli, ulf.hansson, andre.przywara, quic_rjendra, davidwronek,
neil.armstrong, heiko.stuebner, rafal, macromorgan, linus.walleij,
lpieralisi, dmitry.baryshkov, fekz115, devicetree, linux-kernel,
linux-arm-msm, netdev, linux-pm, linux-hardening
On Fri, Aug 09, 2024 at 07:39:53AM +0200, Krzysztof Kozlowski wrote:
> On 08/08/2024 20:40, Danila Tikhonov wrote:
> > The PN553 is another NFC chip from NXP, document the compatible in the
> > bindings.
> >
> > Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
> > ---
> > Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml b/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml
> > index 6924aff0b2c5..364b36151180 100644
> > --- a/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml
> > +++ b/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml
> > @@ -17,6 +17,7 @@ properties:
> > - enum:
> > - nxp,nq310
> > - nxp,pn547
> > + - nxp,pn553
>
> Keep the list ordered.
Looks ordered to me. n before p...
Rob
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v2 06/11] dt-bindings: nfc: nxp,nci: Document PN553 compatible
2024-08-13 19:33 ` Rob Herring
@ 2024-08-14 6:00 ` Krzysztof Kozlowski
0 siblings, 0 replies; 27+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-14 6:00 UTC (permalink / raw)
To: Rob Herring
Cc: Danila Tikhonov, krzk+dt, conor+dt, andersson, konradybcio, davem,
edumazet, kuba, pabeni, rafael, viresh.kumar, kees, tony.luck,
gpiccoli, ulf.hansson, andre.przywara, quic_rjendra, davidwronek,
neil.armstrong, heiko.stuebner, rafal, macromorgan, linus.walleij,
lpieralisi, dmitry.baryshkov, fekz115, devicetree, linux-kernel,
linux-arm-msm, netdev, linux-pm, linux-hardening
On 13/08/2024 21:33, Rob Herring wrote:
> On Fri, Aug 09, 2024 at 07:39:53AM +0200, Krzysztof Kozlowski wrote:
>> On 08/08/2024 20:40, Danila Tikhonov wrote:
>>> The PN553 is another NFC chip from NXP, document the compatible in the
>>> bindings.
>>>
>>> Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
>>> ---
>>> Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml b/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml
>>> index 6924aff0b2c5..364b36151180 100644
>>> --- a/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml
>>> +++ b/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml
>>> @@ -17,6 +17,7 @@ properties:
>>> - enum:
>>> - nxp,nq310
>>> - nxp,pn547
>>> + - nxp,pn553
>>
>> Keep the list ordered.
>
> Looks ordered to me. n before p...
Now it is... I think I misread 5->3.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v2 06/11] dt-bindings: nfc: nxp,nci: Document PN553 compatible
2024-08-08 18:40 ` [PATCH v2 06/11] dt-bindings: nfc: nxp,nci: Document PN553 compatible Danila Tikhonov
2024-08-09 5:39 ` Krzysztof Kozlowski
@ 2024-08-13 19:33 ` Rob Herring (Arm)
1 sibling, 0 replies; 27+ messages in thread
From: Rob Herring (Arm) @ 2024-08-13 19:33 UTC (permalink / raw)
To: Danila Tikhonov
Cc: quic_rjendra, ulf.hansson, linux-pm, pabeni, rafael, konradybcio,
kees, linux-hardening, conor+dt, viresh.kumar, macromorgan,
dmitry.baryshkov, gpiccoli, devicetree, davidwronek, tony.luck,
kuba, neil.armstrong, linux-arm-msm, andre.przywara, krzk+dt,
rafal, linus.walleij, andersson, netdev, fekz115, davem, edumazet,
heiko.stuebner, linux-kernel, lpieralisi
On Thu, 08 Aug 2024 21:40:20 +0300, Danila Tikhonov wrote:
> The PN553 is another NFC chip from NXP, document the compatible in the
> bindings.
>
> Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
> ---
> Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH v2 07/11] dt-bindings: arm: cpus: Add qcom kryo670 compatible
2024-08-08 18:40 [PATCH v2 00/11] Add Nothing Phone (1) support Danila Tikhonov
` (5 preceding siblings ...)
2024-08-08 18:40 ` [PATCH v2 06/11] dt-bindings: nfc: nxp,nci: Document PN553 compatible Danila Tikhonov
@ 2024-08-08 18:40 ` Danila Tikhonov
2024-08-08 18:40 ` [PATCH v2 08/11] arm64: dts: qcom: Add SM7325 device tree Danila Tikhonov
` (5 subsequent siblings)
12 siblings, 0 replies; 27+ messages in thread
From: Danila Tikhonov @ 2024-08-08 18:40 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, andersson, konradybcio, davem, edumazet,
kuba, pabeni, rafael, viresh.kumar, kees, tony.luck, gpiccoli,
ulf.hansson, andre.przywara, quic_rjendra, davidwronek,
neil.armstrong, heiko.stuebner, rafal, macromorgan, linus.walleij,
lpieralisi, dmitry.baryshkov, fekz115
Cc: devicetree, linux-kernel, linux-arm-msm, netdev, linux-pm,
linux-hardening, Danila Tikhonov, Krzysztof Kozlowski
The Qualcomm Snapdragon 778G/778G+/780G/782G uses CPUs named Kryo 670.
Add the compatible string in the documentation.
Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/arm/cpus.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/arm/cpus.yaml b/Documentation/devicetree/bindings/arm/cpus.yaml
index f308ff6c3532..2bf9501b3b0d 100644
--- a/Documentation/devicetree/bindings/arm/cpus.yaml
+++ b/Documentation/devicetree/bindings/arm/cpus.yaml
@@ -202,6 +202,7 @@ properties:
- qcom,kryo560
- qcom,kryo570
- qcom,kryo660
+ - qcom,kryo670
- qcom,kryo685
- qcom,kryo780
- qcom,oryon
--
2.45.2
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH v2 08/11] arm64: dts: qcom: Add SM7325 device tree
2024-08-08 18:40 [PATCH v2 00/11] Add Nothing Phone (1) support Danila Tikhonov
` (6 preceding siblings ...)
2024-08-08 18:40 ` [PATCH v2 07/11] dt-bindings: arm: cpus: Add qcom kryo670 compatible Danila Tikhonov
@ 2024-08-08 18:40 ` Danila Tikhonov
2024-08-08 21:38 ` Rob Herring
2024-08-20 0:48 ` Konrad Dybcio
2024-08-08 18:40 ` [PATCH v2 09/11] dt-bindings: vendor-prefixes: Add Nothing Technology Limited Danila Tikhonov
` (4 subsequent siblings)
12 siblings, 2 replies; 27+ messages in thread
From: Danila Tikhonov @ 2024-08-08 18:40 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, andersson, konradybcio, davem, edumazet,
kuba, pabeni, rafael, viresh.kumar, kees, tony.luck, gpiccoli,
ulf.hansson, andre.przywara, quic_rjendra, davidwronek,
neil.armstrong, heiko.stuebner, rafal, macromorgan, linus.walleij,
lpieralisi, dmitry.baryshkov, fekz115
Cc: devicetree, linux-kernel, linux-arm-msm, netdev, linux-pm,
linux-hardening, Danila Tikhonov
From: Eugene Lepshy <fekz115@gmail.com>
The Snapdragon 778G (SM7325) / 778G+ (SM7325-AE) / 782G (SM7325-AF)
is software-wise very similar to the Snapdragon 7c+ Gen 3 (SC7280).
It uses the Kryo670.
Signed-off-by: Eugene Lepshy <fekz115@gmail.com>
Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
arch/arm64/boot/dts/qcom/sm7325.dtsi | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
create mode 100644 arch/arm64/boot/dts/qcom/sm7325.dtsi
diff --git a/arch/arm64/boot/dts/qcom/sm7325.dtsi b/arch/arm64/boot/dts/qcom/sm7325.dtsi
new file mode 100644
index 000000000000..5b4574484412
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sm7325.dtsi
@@ -0,0 +1,17 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2024, Eugene Lepshy <fekz115@gmail.com>
+ * Copyright (c) 2024, Danila Tikhonov <danila@jiaxyga.com>
+ */
+
+#include "sc7280.dtsi"
+
+/* SM7325 uses Kryo 670 */
+&CPU0 { compatible = "qcom,kryo670"; };
+&CPU1 { compatible = "qcom,kryo670"; };
+&CPU2 { compatible = "qcom,kryo670"; };
+&CPU3 { compatible = "qcom,kryo670"; };
+&CPU4 { compatible = "qcom,kryo670"; };
+&CPU5 { compatible = "qcom,kryo670"; };
+&CPU6 { compatible = "qcom,kryo670"; };
+&CPU7 { compatible = "qcom,kryo670"; };
--
2.45.2
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [PATCH v2 08/11] arm64: dts: qcom: Add SM7325 device tree
2024-08-08 18:40 ` [PATCH v2 08/11] arm64: dts: qcom: Add SM7325 device tree Danila Tikhonov
@ 2024-08-08 21:38 ` Rob Herring
2024-08-17 18:09 ` Danila Tikhonov
2024-08-18 19:33 ` Danila Tikhonov
2024-08-20 0:48 ` Konrad Dybcio
1 sibling, 2 replies; 27+ messages in thread
From: Rob Herring @ 2024-08-08 21:38 UTC (permalink / raw)
To: Danila Tikhonov
Cc: krzk+dt, conor+dt, andersson, konradybcio, davem, edumazet, kuba,
pabeni, rafael, viresh.kumar, kees, tony.luck, gpiccoli,
ulf.hansson, andre.przywara, quic_rjendra, davidwronek,
neil.armstrong, heiko.stuebner, rafal, macromorgan, linus.walleij,
lpieralisi, dmitry.baryshkov, fekz115, devicetree, linux-kernel,
linux-arm-msm, netdev, linux-pm, linux-hardening
On Thu, Aug 08, 2024 at 09:40:22PM +0300, Danila Tikhonov wrote:
> From: Eugene Lepshy <fekz115@gmail.com>
>
> The Snapdragon 778G (SM7325) / 778G+ (SM7325-AE) / 782G (SM7325-AF)
> is software-wise very similar to the Snapdragon 7c+ Gen 3 (SC7280).
>
> It uses the Kryo670.
>
> Signed-off-by: Eugene Lepshy <fekz115@gmail.com>
> Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sm7325.dtsi | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/sm7325.dtsi
>
> diff --git a/arch/arm64/boot/dts/qcom/sm7325.dtsi b/arch/arm64/boot/dts/qcom/sm7325.dtsi
> new file mode 100644
> index 000000000000..5b4574484412
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm7325.dtsi
> @@ -0,0 +1,17 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2024, Eugene Lepshy <fekz115@gmail.com>
> + * Copyright (c) 2024, Danila Tikhonov <danila@jiaxyga.com>
> + */
> +
> +#include "sc7280.dtsi"
> +
> +/* SM7325 uses Kryo 670 */
> +&CPU0 { compatible = "qcom,kryo670"; };
> +&CPU1 { compatible = "qcom,kryo670"; };
> +&CPU2 { compatible = "qcom,kryo670"; };
> +&CPU3 { compatible = "qcom,kryo670"; };
> +&CPU4 { compatible = "qcom,kryo670"; };
> +&CPU5 { compatible = "qcom,kryo670"; };
> +&CPU6 { compatible = "qcom,kryo670"; };
> +&CPU7 { compatible = "qcom,kryo670"; };
No PMU? Because PMUs are also a per CPU model compatible string.
I fixed most QCom platforms recently.
Rob
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [PATCH v2 08/11] arm64: dts: qcom: Add SM7325 device tree
2024-08-08 21:38 ` Rob Herring
@ 2024-08-17 18:09 ` Danila Tikhonov
2024-08-18 19:33 ` Danila Tikhonov
1 sibling, 0 replies; 27+ messages in thread
From: Danila Tikhonov @ 2024-08-17 18:09 UTC (permalink / raw)
To: Rob Herring
Cc: krzk+dt, conor+dt, andersson, konradybcio, davem, edumazet, kuba,
pabeni, rafael, viresh.kumar, kees, tony.luck, gpiccoli,
ulf.hansson, andre.przywara, quic_rjendra, davidwronek,
neil.armstrong, heiko.stuebner, rafal, macromorgan, linus.walleij,
lpieralisi, dmitry.baryshkov, fekz115, devicetree, linux-kernel,
linux-arm-msm, netdev, linux-pm, linux-hardening, danila
On 8/9/24 00:38, Rob Herring wrote:
> On Thu, Aug 08, 2024 at 09:40:22PM +0300, Danila Tikhonov wrote:
>> From: Eugene Lepshy <fekz115@gmail.com>
>>
>> The Snapdragon 778G (SM7325) / 778G+ (SM7325-AE) / 782G (SM7325-AF)
>> is software-wise very similar to the Snapdragon 7c+ Gen 3 (SC7280).
>>
>> It uses the Kryo670.
>>
>> Signed-off-by: Eugene Lepshy <fekz115@gmail.com>
>> Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> ---
>> arch/arm64/boot/dts/qcom/sm7325.dtsi | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>> create mode 100644 arch/arm64/boot/dts/qcom/sm7325.dtsi
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm7325.dtsi b/arch/arm64/boot/dts/qcom/sm7325.dtsi
>> new file mode 100644
>> index 000000000000..5b4574484412
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/sm7325.dtsi
>> @@ -0,0 +1,17 @@
>> +// SPDX-License-Identifier: BSD-3-Clause
>> +/*
>> + * Copyright (c) 2024, Eugene Lepshy <fekz115@gmail.com>
>> + * Copyright (c) 2024, Danila Tikhonov <danila@jiaxyga.com>
>> + */
>> +
>> +#include "sc7280.dtsi"
>> +
>> +/* SM7325 uses Kryo 670 */
>> +&CPU0 { compatible = "qcom,kryo670"; };
>> +&CPU1 { compatible = "qcom,kryo670"; };
>> +&CPU2 { compatible = "qcom,kryo670"; };
>> +&CPU3 { compatible = "qcom,kryo670"; };
>> +&CPU4 { compatible = "qcom,kryo670"; };
>> +&CPU5 { compatible = "qcom,kryo670"; };
>> +&CPU6 { compatible = "qcom,kryo670"; };
>> +&CPU7 { compatible = "qcom,kryo670"; };
> No PMU? Because PMUs are also a per CPU model compatible string.
>
> I fixed most QCom platforms recently.
>
> Rob
Sorry for my long reply and thank you for your feedback.
You are absolutely right. But at the moment I can't confirm that the
sc7280 doesn't use cortex a55 and a78 either. I would fix that in the
sc7280 DTS right away if I could confirm it. I am almost certain that
the qcm6490 uses cortex a55 and a78 just like the sm7325 (and I
hope Luca Weiss can confirm that too)
If anyone with a sc7280 can read /proc/cpuinfo I would be very grateful.
Best wishes,
Danila
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [PATCH v2 08/11] arm64: dts: qcom: Add SM7325 device tree
2024-08-08 21:38 ` Rob Herring
2024-08-17 18:09 ` Danila Tikhonov
@ 2024-08-18 19:33 ` Danila Tikhonov
1 sibling, 0 replies; 27+ messages in thread
From: Danila Tikhonov @ 2024-08-18 19:33 UTC (permalink / raw)
To: Rob Herring
Cc: krzk+dt, conor+dt, andersson, konradybcio, davem, edumazet, kuba,
pabeni, rafael, viresh.kumar, kees, tony.luck, gpiccoli,
ulf.hansson, andre.przywara, quic_rjendra, davidwronek,
neil.armstrong, heiko.stuebner, rafal, macromorgan, linus.walleij,
lpieralisi, dmitry.baryshkov, fekz115, devicetree, linux-kernel,
linux-arm-msm, netdev, linux-pm, linux-hardening, danila
On 8/9/24 00:38, Rob Herring wrote:
> On Thu, Aug 08, 2024 at 09:40:22PM +0300, Danila Tikhonov wrote:
>> From: Eugene Lepshy <fekz115@gmail.com>
>>
>> The Snapdragon 778G (SM7325) / 778G+ (SM7325-AE) / 782G (SM7325-AF)
>> is software-wise very similar to the Snapdragon 7c+ Gen 3 (SC7280).
>>
>> It uses the Kryo670.
>>
>> Signed-off-by: Eugene Lepshy <fekz115@gmail.com>
>> Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> ---
>> arch/arm64/boot/dts/qcom/sm7325.dtsi | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>> create mode 100644 arch/arm64/boot/dts/qcom/sm7325.dtsi
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm7325.dtsi b/arch/arm64/boot/dts/qcom/sm7325.dtsi
>> new file mode 100644
>> index 000000000000..5b4574484412
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/sm7325.dtsi
>> @@ -0,0 +1,17 @@
>> +// SPDX-License-Identifier: BSD-3-Clause
>> +/*
>> + * Copyright (c) 2024, Eugene Lepshy <fekz115@gmail.com>
>> + * Copyright (c) 2024, Danila Tikhonov <danila@jiaxyga.com>
>> + */
>> +
>> +#include "sc7280.dtsi"
>> +
>> +/* SM7325 uses Kryo 670 */
>> +&CPU0 { compatible = "qcom,kryo670"; };
>> +&CPU1 { compatible = "qcom,kryo670"; };
>> +&CPU2 { compatible = "qcom,kryo670"; };
>> +&CPU3 { compatible = "qcom,kryo670"; };
>> +&CPU4 { compatible = "qcom,kryo670"; };
>> +&CPU5 { compatible = "qcom,kryo670"; };
>> +&CPU6 { compatible = "qcom,kryo670"; };
>> +&CPU7 { compatible = "qcom,kryo670"; };
> No PMU? Because PMUs are also a per CPU model compatible string.
>
> I fixed most QCom platforms recently.
>
> Rob
A patch has been sent to fix this in SC7280:
https://lore.kernel.org/all/20240818192905.120477-1-danila@jiaxyga.com/
Best wishes,
Danila
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [PATCH v2 08/11] arm64: dts: qcom: Add SM7325 device tree
2024-08-08 18:40 ` [PATCH v2 08/11] arm64: dts: qcom: Add SM7325 device tree Danila Tikhonov
2024-08-08 21:38 ` Rob Herring
@ 2024-08-20 0:48 ` Konrad Dybcio
2024-08-20 22:53 ` Danila Tikhonov
1 sibling, 1 reply; 27+ messages in thread
From: Konrad Dybcio @ 2024-08-20 0:48 UTC (permalink / raw)
To: Danila Tikhonov, robh, krzk+dt, conor+dt, andersson, konradybcio,
davem, edumazet, kuba, pabeni, rafael, viresh.kumar, kees,
tony.luck, gpiccoli, ulf.hansson, andre.przywara, quic_rjendra,
davidwronek, neil.armstrong, heiko.stuebner, rafal, macromorgan,
linus.walleij, lpieralisi, dmitry.baryshkov, fekz115
Cc: devicetree, linux-kernel, linux-arm-msm, netdev, linux-pm,
linux-hardening
On 8.08.2024 8:40 PM, Danila Tikhonov wrote:
> From: Eugene Lepshy <fekz115@gmail.com>
>
> The Snapdragon 778G (SM7325) / 778G+ (SM7325-AE) / 782G (SM7325-AF)
> is software-wise very similar to the Snapdragon 7c+ Gen 3 (SC7280).
>
> It uses the Kryo670.
>
> Signed-off-by: Eugene Lepshy <fekz115@gmail.com>
> Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sm7325.dtsi | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/sm7325.dtsi
>
> diff --git a/arch/arm64/boot/dts/qcom/sm7325.dtsi b/arch/arm64/boot/dts/qcom/sm7325.dtsi
> new file mode 100644
> index 000000000000..5b4574484412
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm7325.dtsi
> @@ -0,0 +1,17 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2024, Eugene Lepshy <fekz115@gmail.com>
> + * Copyright (c) 2024, Danila Tikhonov <danila@jiaxyga.com>
> + */
> +
> +#include "sc7280.dtsi"
> +
> +/* SM7325 uses Kryo 670 */
> +&CPU0 { compatible = "qcom,kryo670"; };
> +&CPU1 { compatible = "qcom,kryo670"; };
> +&CPU2 { compatible = "qcom,kryo670"; };
> +&CPU3 { compatible = "qcom,kryo670"; };
> +&CPU4 { compatible = "qcom,kryo670"; };
> +&CPU5 { compatible = "qcom,kryo670"; };
> +&CPU6 { compatible = "qcom,kryo670"; };
> +&CPU7 { compatible = "qcom,kryo670"; };
This is a meaningless marketing name. As you mentioned in your
reply, cpu0-3 and cpu4-7 are wholly different (maybe cpu7 even
has a different MIDR part num?), we should do something about it :/
Please post the output of `dmesg | grep "Booted secondary processor"`
Konrad
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [PATCH v2 08/11] arm64: dts: qcom: Add SM7325 device tree
2024-08-20 0:48 ` Konrad Dybcio
@ 2024-08-20 22:53 ` Danila Tikhonov
2024-08-27 10:45 ` Konrad Dybcio
0 siblings, 1 reply; 27+ messages in thread
From: Danila Tikhonov @ 2024-08-20 22:53 UTC (permalink / raw)
To: Konrad Dybcio, robh, krzk+dt, conor+dt, andersson, konradybcio,
davem, edumazet, kuba, pabeni, rafael, viresh.kumar, kees,
tony.luck, gpiccoli, ulf.hansson, andre.przywara, quic_rjendra,
davidwronek, neil.armstrong, heiko.stuebner, rafal, macromorgan,
linus.walleij, lpieralisi, dmitry.baryshkov, fekz115
Cc: devicetree, linux-kernel, linux-arm-msm, netdev, linux-pm,
linux-hardening, danila
On 8/20/24 03:48, Konrad Dybcio wrote:
> On 8.08.2024 8:40 PM, Danila Tikhonov wrote:
>> From: Eugene Lepshy <fekz115@gmail.com>
>>
>> The Snapdragon 778G (SM7325) / 778G+ (SM7325-AE) / 782G (SM7325-AF)
>> is software-wise very similar to the Snapdragon 7c+ Gen 3 (SC7280).
>>
>> It uses the Kryo670.
>>
>> Signed-off-by: Eugene Lepshy <fekz115@gmail.com>
>> Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> ---
>> arch/arm64/boot/dts/qcom/sm7325.dtsi | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>> create mode 100644 arch/arm64/boot/dts/qcom/sm7325.dtsi
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm7325.dtsi b/arch/arm64/boot/dts/qcom/sm7325.dtsi
>> new file mode 100644
>> index 000000000000..5b4574484412
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/sm7325.dtsi
>> @@ -0,0 +1,17 @@
>> +// SPDX-License-Identifier: BSD-3-Clause
>> +/*
>> + * Copyright (c) 2024, Eugene Lepshy <fekz115@gmail.com>
>> + * Copyright (c) 2024, Danila Tikhonov <danila@jiaxyga.com>
>> + */
>> +
>> +#include "sc7280.dtsi"
>> +
>> +/* SM7325 uses Kryo 670 */
>> +&CPU0 { compatible = "qcom,kryo670"; };
>> +&CPU1 { compatible = "qcom,kryo670"; };
>> +&CPU2 { compatible = "qcom,kryo670"; };
>> +&CPU3 { compatible = "qcom,kryo670"; };
>> +&CPU4 { compatible = "qcom,kryo670"; };
>> +&CPU5 { compatible = "qcom,kryo670"; };
>> +&CPU6 { compatible = "qcom,kryo670"; };
>> +&CPU7 { compatible = "qcom,kryo670"; };
> This is a meaningless marketing name. As you mentioned in your
> reply, cpu0-3 and cpu4-7 are wholly different (maybe cpu7 even
> has a different MIDR part num?), we should do something about it :/
>
> Please post the output of `dmesg | grep "Booted secondary processor"`
>
> Konrad
Sure:
[ 0.000000] Booting Linux on physical CPU 0x0000000000 [0x412fd050]
[ 0.020670] CPU1: Booted secondary processor 0x0000000100 [0x412fd050]
[ 0.036781] CPU2: Booted secondary processor 0x0000000200 [0x412fd050]
[ 0.052717] CPU3: Booted secondary processor 0x0000000300 [0x412fd050]
[ 0.070194] CPU4: Booted secondary processor 0x0000000400 [0x411fd411]
[ 0.089236] CPU5: Booted secondary processor 0x0000000500 [0x411fd411]
[ 0.109298] CPU6: Booted secondary processor 0x0000000600 [0x411fd411]
[ 0.126140] CPU7: Booted secondary processor 0x0000000700 [0x411fd411]
Best wishes,
Danila
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: [PATCH v2 08/11] arm64: dts: qcom: Add SM7325 device tree
2024-08-20 22:53 ` Danila Tikhonov
@ 2024-08-27 10:45 ` Konrad Dybcio
0 siblings, 0 replies; 27+ messages in thread
From: Konrad Dybcio @ 2024-08-27 10:45 UTC (permalink / raw)
To: Danila Tikhonov, robh, krzk+dt, conor+dt, andersson, konradybcio,
davem, edumazet, kuba, pabeni, rafael, viresh.kumar, kees,
tony.luck, gpiccoli, ulf.hansson, andre.przywara, quic_rjendra,
davidwronek, neil.armstrong, heiko.stuebner, rafal, macromorgan,
linus.walleij, lpieralisi, dmitry.baryshkov, fekz115
Cc: devicetree, linux-kernel, linux-arm-msm, netdev, linux-pm,
linux-hardening
On 21.08.2024 12:53 AM, Danila Tikhonov wrote:
> On 8/20/24 03:48, Konrad Dybcio wrote:
>> On 8.08.2024 8:40 PM, Danila Tikhonov wrote:
>>> From: Eugene Lepshy <fekz115@gmail.com>
>>>
>>> The Snapdragon 778G (SM7325) / 778G+ (SM7325-AE) / 782G (SM7325-AF)
>>> is software-wise very similar to the Snapdragon 7c+ Gen 3 (SC7280).
>>>
>>> It uses the Kryo670.
>>>
>>> Signed-off-by: Eugene Lepshy <fekz115@gmail.com>
>>> Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
>>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>>> ---
>>> arch/arm64/boot/dts/qcom/sm7325.dtsi | 17 +++++++++++++++++
>>> 1 file changed, 17 insertions(+)
>>> create mode 100644 arch/arm64/boot/dts/qcom/sm7325.dtsi
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sm7325.dtsi b/arch/arm64/boot/dts/qcom/sm7325.dtsi
>>> new file mode 100644
>>> index 000000000000..5b4574484412
>>> --- /dev/null
>>> +++ b/arch/arm64/boot/dts/qcom/sm7325.dtsi
>>> @@ -0,0 +1,17 @@
>>> +// SPDX-License-Identifier: BSD-3-Clause
>>> +/*
>>> + * Copyright (c) 2024, Eugene Lepshy <fekz115@gmail.com>
>>> + * Copyright (c) 2024, Danila Tikhonov <danila@jiaxyga.com>
>>> + */
>>> +
>>> +#include "sc7280.dtsi"
>>> +
>>> +/* SM7325 uses Kryo 670 */
>>> +&CPU0 { compatible = "qcom,kryo670"; };
>>> +&CPU1 { compatible = "qcom,kryo670"; };
>>> +&CPU2 { compatible = "qcom,kryo670"; };
>>> +&CPU3 { compatible = "qcom,kryo670"; };
>>> +&CPU4 { compatible = "qcom,kryo670"; };
>>> +&CPU5 { compatible = "qcom,kryo670"; };
>>> +&CPU6 { compatible = "qcom,kryo670"; };
>>> +&CPU7 { compatible = "qcom,kryo670"; };
>> This is a meaningless marketing name. As you mentioned in your
>> reply, cpu0-3 and cpu4-7 are wholly different (maybe cpu7 even
>> has a different MIDR part num?), we should do something about it :/
>>
>> Please post the output of `dmesg | grep "Booted secondary processor"`
>>
>> Konrad
> Sure:
> [ 0.000000] Booting Linux on physical CPU 0x0000000000 [0x412fd050]
> [ 0.020670] CPU1: Booted secondary processor 0x0000000100 [0x412fd050]
> [ 0.036781] CPU2: Booted secondary processor 0x0000000200 [0x412fd050]
> [ 0.052717] CPU3: Booted secondary processor 0x0000000300 [0x412fd050]
> [ 0.070194] CPU4: Booted secondary processor 0x0000000400 [0x411fd411]
> [ 0.089236] CPU5: Booted secondary processor 0x0000000500 [0x411fd411]
> [ 0.109298] CPU6: Booted secondary processor 0x0000000600 [0x411fd411]
> [ 0.126140] CPU7: Booted secondary processor 0x0000000700 [0x411fd411]
0x41 is Arm Ltd
0xd41 is CA78, 0xd05 is CA55
Konrad
^ permalink raw reply [flat|nested] 27+ messages in thread
* [PATCH v2 09/11] dt-bindings: vendor-prefixes: Add Nothing Technology Limited
2024-08-08 18:40 [PATCH v2 00/11] Add Nothing Phone (1) support Danila Tikhonov
` (7 preceding siblings ...)
2024-08-08 18:40 ` [PATCH v2 08/11] arm64: dts: qcom: Add SM7325 device tree Danila Tikhonov
@ 2024-08-08 18:40 ` Danila Tikhonov
2024-08-08 18:40 ` [PATCH v2 10/11] dt-bindings: arm: qcom: Add SM7325 Nothing Phone 1 Danila Tikhonov
` (3 subsequent siblings)
12 siblings, 0 replies; 27+ messages in thread
From: Danila Tikhonov @ 2024-08-08 18:40 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, andersson, konradybcio, davem, edumazet,
kuba, pabeni, rafael, viresh.kumar, kees, tony.luck, gpiccoli,
ulf.hansson, andre.przywara, quic_rjendra, davidwronek,
neil.armstrong, heiko.stuebner, rafal, macromorgan, linus.walleij,
lpieralisi, dmitry.baryshkov, fekz115
Cc: devicetree, linux-kernel, linux-arm-msm, netdev, linux-pm,
linux-hardening, Danila Tikhonov, Krzysztof Kozlowski
Add entry for Nothing Technology Limited (https://nothing.tech/)
Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 12033629595a..6f4133e0c604 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -1041,6 +1041,8 @@ patternProperties:
description: Nokia
"^nordic,.*":
description: Nordic Semiconductor
+ "^nothing,.*":
+ description: Nothing Technology Limited
"^novatek,.*":
description: Novatek
"^novtech,.*":
--
2.45.2
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH v2 10/11] dt-bindings: arm: qcom: Add SM7325 Nothing Phone 1
2024-08-08 18:40 [PATCH v2 00/11] Add Nothing Phone (1) support Danila Tikhonov
` (8 preceding siblings ...)
2024-08-08 18:40 ` [PATCH v2 09/11] dt-bindings: vendor-prefixes: Add Nothing Technology Limited Danila Tikhonov
@ 2024-08-08 18:40 ` Danila Tikhonov
2024-08-08 18:40 ` [PATCH v2 11/11] arm64: dts: qcom: sm7325: Add device-tree for " Danila Tikhonov
` (2 subsequent siblings)
12 siblings, 0 replies; 27+ messages in thread
From: Danila Tikhonov @ 2024-08-08 18:40 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, andersson, konradybcio, davem, edumazet,
kuba, pabeni, rafael, viresh.kumar, kees, tony.luck, gpiccoli,
ulf.hansson, andre.przywara, quic_rjendra, davidwronek,
neil.armstrong, heiko.stuebner, rafal, macromorgan, linus.walleij,
lpieralisi, dmitry.baryshkov, fekz115
Cc: devicetree, linux-kernel, linux-arm-msm, netdev, linux-pm,
linux-hardening, Danila Tikhonov, Krzysztof Kozlowski
Nothing Phone 1 (nothing,spacewar) is a smartphone based on the SM7325
SoC.
Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 4ef456cefd6c..ea7b51740e64 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -76,6 +76,7 @@ description: |
sm6375
sm7125
sm7225
+ sm7325
sm8150
sm8250
sm8350
@@ -988,6 +989,11 @@ properties:
- fairphone,fp4
- const: qcom,sm7225
+ - items:
+ - enum:
+ - nothing,spacewar
+ - const: qcom,sm7325
+
- items:
- enum:
- microsoft,surface-duo
--
2.45.2
^ permalink raw reply related [flat|nested] 27+ messages in thread* [PATCH v2 11/11] arm64: dts: qcom: sm7325: Add device-tree for Nothing Phone 1
2024-08-08 18:40 [PATCH v2 00/11] Add Nothing Phone (1) support Danila Tikhonov
` (9 preceding siblings ...)
2024-08-08 18:40 ` [PATCH v2 10/11] dt-bindings: arm: qcom: Add SM7325 Nothing Phone 1 Danila Tikhonov
@ 2024-08-08 18:40 ` Danila Tikhonov
2024-08-12 15:09 ` [PATCH v2 00/11] Add Nothing Phone (1) support Rob Herring (Arm)
2024-08-15 21:56 ` (subset) " Bjorn Andersson
12 siblings, 0 replies; 27+ messages in thread
From: Danila Tikhonov @ 2024-08-08 18:40 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, andersson, konradybcio, davem, edumazet,
kuba, pabeni, rafael, viresh.kumar, kees, tony.luck, gpiccoli,
ulf.hansson, andre.przywara, quic_rjendra, davidwronek,
neil.armstrong, heiko.stuebner, rafal, macromorgan, linus.walleij,
lpieralisi, dmitry.baryshkov, fekz115
Cc: devicetree, linux-kernel, linux-arm-msm, netdev, linux-pm,
linux-hardening, Danila Tikhonov
From: Eugene Lepshy <fekz115@gmail.com>
Add device tree for the Nothing Phone 1 (nothing,spacewar) smartphone
which is based on the SM7325 SoC.
Supported features are, as of now:
* USB & UFS
* Debug UART
* Display via SimpleFB
* Power & volume buttons
* PMIC GLink
* Remoteprocs (ADSP, CDSP, MPSS, WPSS)
* WiFi & Bluetooth
* IPA
* VPU Iris (Venus)
* NFC
* Flash/torch LED
* RTC
* Device-specific thermals
* Various plumbing like regulators, i2c, spi, cci, etc
Signed-off-by: Eugene Lepshy <fekz115@gmail.com>
Co-developed-by: Danila Tikhonov <danila@jiaxyga.com>
Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
---
arch/arm64/boot/dts/qcom/Makefile | 1 +
.../boot/dts/qcom/sm7325-nothing-spacewar.dts | 1263 +++++++++++++++++
2 files changed, 1264 insertions(+)
create mode 100644 arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dts
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index e534442620a1..ab7962b1388d 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -234,6 +234,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sm6375-sony-xperia-murray-pdx225.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm7125-xiaomi-curtana.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm7125-xiaomi-joyeuse.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm7225-fairphone-fp4.dtb
+dtb-$(CONFIG_ARCH_QCOM) += sm7325-nothing-spacewar.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm8150-hdk.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm8150-microsoft-surface-duo.dtb
dtb-$(CONFIG_ARCH_QCOM) += sm8150-mtp.dtb
diff --git a/arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dts b/arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dts
new file mode 100644
index 000000000000..6cf744ba55be
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dts
@@ -0,0 +1,1263 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2024, Eugene Lepshy <fekz115@gmail.com>
+ * Copyright (c) 2024, Danila Tikhonov <danila@jiaxyga.com>
+ */
+
+/dts-v1/;
+
+#include <dt-bindings/arm/qcom,ids.h>
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/iio/qcom,spmi-adc7-pm7325.h>
+#include <dt-bindings/iio/qcom,spmi-adc7-pm8350b.h>
+#include <dt-bindings/iio/qcom,spmi-adc7-pmk8350.h>
+#include <dt-bindings/leds/common.h>
+#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
+#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
+#include <dt-bindings/sound/qcom,q6afe.h>
+#include <dt-bindings/sound/qcom,q6asm.h>
+
+#include "sm7325.dtsi"
+#include "pm7325.dtsi"
+#include "pm8350b.dtsi" /* PM7325B */
+#include "pm8350c.dtsi" /* PM7350C */
+#include "pmk8350.dtsi" /* PMK7325 */
+
+/delete-node/ &rmtfs_mem;
+
+/ {
+ model = "Nothing Phone (1)";
+ compatible = "nothing,spacewar", "qcom,sm7325";
+ chassis-type = "handset";
+
+ qcom,msm-id = <QCOM_ID_SM7325 0x10000>;
+ qcom,board-id = <QCOM_BOARD_ID(QRD, 1, 0) 0>;
+
+ aliases {
+ bluetooth0 = &bluetooth;
+ serial0 = &uart5;
+ serial1 = &uart7;
+ wifi0 = &wifi;
+ };
+
+ chosen {
+ #address-cells = <2>;
+ #size-cells = <2>;
+ ranges;
+
+ stdout-path = "serial0:115200n8";
+
+ framebuffer0: framebuffer@e1000000 {
+ compatible = "simple-framebuffer";
+ reg = <0x0 0xe1000000 0x0 (1080 * 2400 * 4)>;
+ width = <1080>;
+ height = <2400>;
+ stride = <(1080 * 4)>;
+ format = "a8r8g8b8";
+
+ clocks = <&gcc GCC_DISP_HF_AXI_CLK>,
+ <&dispcc DISP_CC_MDSS_MDP_CLK>,
+ <&dispcc DISP_CC_MDSS_BYTE0_CLK>,
+ <&dispcc DISP_CC_MDSS_BYTE0_INTF_CLK>,
+ <&dispcc DISP_CC_MDSS_PCLK0_CLK>,
+ <&dispcc DISP_CC_MDSS_VSYNC_CLK>;
+ power-domains = <&dispcc DISP_CC_MDSS_CORE_GDSC>;
+ };
+ };
+
+ gpio-keys {
+ compatible = "gpio-keys";
+
+ pinctrl-0 = <&kypd_volp_n>;
+ pinctrl-names = "default";
+
+ key-volume-up {
+ label = "Volume up";
+ gpios = <&pm7325_gpios 6 GPIO_ACTIVE_LOW>;
+ linux,code = <KEY_VOLUMEUP>;
+ };
+ };
+
+ pmic-glink {
+ compatible = "qcom,sm7325-pmic-glink",
+ "qcom,qcm6490-pmic-glink",
+ "qcom,pmic-glink";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ orientation-gpios = <&tlmm 140 GPIO_ACTIVE_HIGH>;
+
+ connector@0 {
+ compatible = "usb-c-connector";
+ reg = <0>;
+ power-role = "dual";
+ data-role = "dual";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+
+ pmic_glink_hs_in: endpoint {
+ remote-endpoint = <&usb_1_dwc3_hs>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+
+ pmic_glink_sbu: endpoint {
+ remote-endpoint = <&fsa4480_sbu_mux>;
+ };
+ };
+ };
+ };
+ };
+
+ reserved-memory {
+ #address-cells = <2>;
+ #size-cells = <2>;
+ ranges;
+
+ ramoops_mem: ramoops@83a00000 {
+ compatible = "ramoops";
+ reg = <0x0 0x83a00000 0x0 0x400000>;
+ pmsg-size = <0x200000>;
+ mem-type = <2>;
+ console-size = <0x200000>;
+ };
+
+ cdsp_mem: cdsp@88f00000 {
+ reg = <0x0 0x88f00000 0x0 0x1e00000>;
+ no-map;
+ };
+
+ removed_mem: removed@c0000000 {
+ reg = <0x0 0xc0000000 0x0 0x5100000>;
+ no-map;
+ };
+
+ cont_splash_mem: cont-splash@e1000000 {
+ reg = <0x0 0xe1000000 0x0 (1080 * 2400 * 4)>;
+ no-map;
+ };
+
+ rmtfs_mem: rmtfs@f8500000 {
+ compatible = "qcom,rmtfs-mem";
+ reg = <0x0 0xf8500000 0x0 0x600000>;
+ no-map;
+
+ qcom,client-id = <1>;
+ qcom,vmid = <QCOM_SCM_VMID_MSS_MSA>,
+ <QCOM_SCM_VMID_NAV>;
+ };
+ };
+
+ thermal-zones {
+ camera-thermal {
+ polling-delay-passive = <0>;
+ thermal-sensors = <&pmk8350_adc_tm 2>;
+
+ trips {
+ active-config0 {
+ temperature = <125000>;
+ hysteresis = <1000>;
+ type = "passive";
+ };
+ };
+ };
+
+ chg-skin-thermal {
+ polling-delay-passive = <0>;
+ thermal-sensors = <&pmk8350_adc_tm 6>;
+
+ trips {
+ active-config0 {
+ temperature = <125000>;
+ hysteresis = <1000>;
+ type = "passive";
+ };
+ };
+ };
+
+ conn-thermal {
+ polling-delay-passive = <0>;
+ thermal-sensors = <&pmk8350_adc_tm 5>;
+
+ trips {
+ active-config0 {
+ temperature = <125000>;
+ hysteresis = <1000>;
+ type = "passive";
+ };
+ };
+ };
+
+ quiet-thermal {
+ polling-delay-passive = <0>;
+ thermal-sensors = <&pmk8350_adc_tm 1>;
+
+ trips {
+ active-config0 {
+ temperature = <125000>;
+ hysteresis = <1000>;
+ type = "passive";
+ };
+ };
+ };
+
+ rear-cam-thermal {
+ polling-delay-passive = <0>;
+ thermal-sensors = <&pmk8350_adc_tm 4>;
+
+ trips {
+ active-config0 {
+ temperature = <125000>;
+ hysteresis = <1000>;
+ type = "passive";
+ };
+ };
+ };
+
+ sdm-skin-thermal {
+ polling-delay-passive = <0>;
+ thermal-sensors = <&pmk8350_adc_tm 3>;
+
+ trips {
+ active-config0 {
+ temperature = <125000>;
+ hysteresis = <1000>;
+ type = "passive";
+ };
+ };
+ };
+
+ xo-thermal {
+ polling-delay-passive = <0>;
+ thermal-sensors = <&pmk8350_adc_tm 0>;
+
+ trips {
+ active-config0 {
+ temperature = <125000>;
+ hysteresis = <1000>;
+ type = "passive";
+ };
+ };
+ };
+ };
+
+ vph_pwr: vph-pwr-regulator {
+ compatible = "regulator-fixed";
+ regulator-name = "vph_pwr";
+ regulator-min-microvolt = <3700000>;
+ regulator-max-microvolt = <3700000>;
+ };
+
+ // S2B is really ebi.lvl but it's there for supply map completeness sake.
+ vreg_s2b_0p7: smpa3-regulator {
+ compatible = "regulator-fixed";
+ regulator-name = "vreg_s2b_0p7";
+
+ regulator-min-microvolt = <65535>;
+ regulator-max-microvolt = <65535>;
+ regulator-always-on;
+ vin-supply = <&vph_pwr>;
+ };
+};
+
+&apps_rsc {
+ regulators-0 {
+ compatible = "qcom,pm7325-rpmh-regulators";
+ qcom,pmic-id = "b";
+
+ vdd-s1-supply = <&vph_pwr>;
+ vdd-s2-supply = <&vph_pwr>;
+ vdd-s7-supply = <&vph_pwr>;
+ vdd-s8-supply = <&vph_pwr>;
+
+ vdd-l1-l4-l12-l15-supply = <&vreg_s7b_0p952>;
+ vdd-l2-l7-supply = <&vreg_bob>;
+ vdd-l3-supply = <&vreg_s2b_0p7>;
+ vdd-l5-supply = <&vreg_s2b_0p7>;
+ vdd-l6-l9-l10-supply = <&vreg_s8b_1p256>;
+ vdd-l8-supply = <&vreg_s7b_0p952>;
+ vdd-l11-l17-l18-l19-supply = <&vreg_s1b_1p856>;
+ vdd-l13-supply = <&vreg_s7b_0p952>;
+ vdd-l14-l16-supply = <&vreg_s8b_1p256>;
+
+ /*
+ * S2, L4-L5 are ARCs:
+ * S2 - ebi.lvl,
+ * L4 - lmx.lvl,
+ * l5 - lcx.lvl.
+ *
+ * L10 are unused.
+ */
+
+ vdd19_pmu_rfa_i:
+ vreg_s1b_1p856: smps1 {
+ regulator-name = "vreg_s1b_1p856";
+ regulator-min-microvolt = <1840000>;
+ regulator-max-microvolt = <2040000>;
+ };
+
+ vdd_pmu_aon_i:
+ vdd09_pmu_rfa_i:
+ vdd095_mx_pmu:
+ vdd095_pmu_1:
+ vdd095_pmu_2:
+ vreg_s7b_0p952: smps7 {
+ regulator-name = "vreg_s7b_0p952";
+ regulator-min-microvolt = <535000>;
+ regulator-max-microvolt = <1120000>;
+ };
+
+ vdd13_pmu_rfa_i:
+ vreg_s8b_1p256: smps8 {
+ regulator-name = "vreg_s8b_1p256";
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <1500000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_RET>;
+ };
+
+ vreg_l1b_0p912: ldo1 {
+ regulator-name = "vreg_l1b_0p912";
+ regulator-min-microvolt = <825000>;
+ regulator-max-microvolt = <925000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vdd_a_usbhs_3p1:
+ vreg_l2b_3p072: ldo2 {
+ regulator-name = "vreg_l2b_3p072";
+ regulator-min-microvolt = <2700000>;
+ regulator-max-microvolt = <3544000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vdd_io_ebi0_1:
+ vdd_io_ebi0_2:
+ vdd_io_ebi0_3:
+ vdd_io_ebi0_4:
+ vdd_io_ebi1_1:
+ vdd_io_ebi1_2:
+ vdd_io_ebi1_3:
+ vdd_io_ebi1_4:
+ vreg_l3b_0p6: ldo3 {
+ regulator-name = "vreg_l3b_0p6";
+ regulator-min-microvolt = <312000>;
+ regulator-max-microvolt = <910000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vdd_a_csi_01_1p2:
+ vdd_a_csi_23_1p2:
+ vdd_a_csi_4_1p2:
+ vdd_a_dsi_0_1p2:
+ vdd_a_qlink_0_1p2_ck:
+ vdd_a_qlink_1_1p2:
+ vdd_a_ufs_0_1p2:
+ vdd_vref_1p2_1:
+ vdd_vref_1p2_2:
+ vreg_l6b_1p2: ldo6 {
+ regulator-name = "vreg_l6b_1p2";
+ regulator-min-microvolt = <1140000>;
+ regulator-max-microvolt = <1260000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ regulator-allow-set-load;
+ regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+ RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l7b_2p96: ldo7 {
+ regulator-name = "vreg_l7b_2p96";
+ regulator-min-microvolt = <2400000>;
+ regulator-max-microvolt = <3544000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ regulator-allow-set-load;
+ regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+ RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l8b_0p904: ldo8 {
+ regulator-name = "vreg_l8b_0p904";
+ regulator-min-microvolt = <870000>;
+ regulator-max-microvolt = <970000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vdd_px10:
+ vreg_l9b_1p2: ldo9 {
+ regulator-name = "vreg_l9b_1p2";
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <1304000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ regulator-allow-set-load;
+ regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+ RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vddah_0:
+ vddah_1:
+ vddah_fbrx:
+ vddah_tx0:
+ vddah_tx0_1:
+ vddah_tx1:
+ vddah_tx1_1:
+ vreg_l11b_1p776: ldo11 {
+ regulator-name = "vreg_l11b_1p776";
+ regulator-min-microvolt = <1504000>;
+ regulator-max-microvolt = <2000000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vddal_dig0:
+ vddal_dig_1:
+ vddal_dig_2:
+ vddal_dig_xo:
+ vddal_gps_l1:
+ vddal_gps_l5:
+ vddal_icon:
+ vddal_rx:
+ vddal_rx0:
+ vddal_rx1:
+ vddal_rx2:
+ vddal_tx0:
+ vddal_tx0_1:
+ vddal_tx1:
+ vddal_tx1_2:
+ vreg_l12b_0p8: ldo12 {
+ regulator-name = "vreg_l12b_0p8";
+ regulator-min-microvolt = <751000>;
+ regulator-max-microvolt = <824000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vdd_cx1:
+ vdd_cx2:
+ vreg_l13b_0p8: ldo13 {
+ regulator-name = "vreg_l13b_0p8";
+ regulator-min-microvolt = <530000>;
+ regulator-max-microvolt = <824000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vdd_1p2:
+ vdd_lna:
+ vddam_fbrx:
+ vddam_rx_0:
+ vddam_rx_1:
+ vddam_rx0:
+ vddam_rx1:
+ vddam_rx2:
+ vddam_rxe_a:
+ vddam_rxe_b:
+ vddam_rxe_c:
+ vddam_rxe_d:
+ vddam_rxe_e:
+ vddam_tx0:
+ vddam_tx0_1:
+ vddam_tx1:
+ vddam_tx1_1:
+ vddam_xo:
+ vreg_l14b_1p2: ldo14 {
+ regulator-name = "vreg_l14b_1p2";
+ regulator-min-microvolt = <1080000>;
+ regulator-max-microvolt = <1304000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vdd_mx:
+ vddmx_tx:
+ vdd_phy:
+ vreg_l15b_0p88: ldo15 {
+ regulator-name = "vreg_l15b_0p88";
+ regulator-min-microvolt = <765000>;
+ regulator-max-microvolt = <1020000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l16b_1p2: ldo16 {
+ regulator-name = "vreg_l16b_1p2";
+ regulator-min-microvolt = <1100000>;
+ regulator-max-microvolt = <1300000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vdd_buck:
+ vreg_l17b_1p8: ldo17 {
+ regulator-name = "vreg_l17b_1p8";
+ regulator-min-microvolt = <1700000>;
+ regulator-max-microvolt = <1900000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vdd_px_wcd9385:
+ vdd_txrx:
+ vdd_px0:
+ vdd_px3:
+ vdd_px7:
+ vreg_l18b_1p8: ldo18 {
+ regulator-name = "vreg_l18b_1p8";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <2000000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vdd_1p8:
+ vdd_px_sdr735:
+ vdd_pxm:
+ vddio_px_1:
+ vddio_px_2:
+ vddio_px_3:
+ vdd18_io:
+ vddpx_ts:
+ vddpx_wl4otp:
+ vreg_l19b_1p8: ldo19 {
+ regulator-name = "vreg_l19b_1p8";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <2000000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+ };
+
+ regulators-1 {
+ compatible = "qcom,pm8350c-rpmh-regulators";
+ qcom,pmic-id = "c";
+
+ vdd-s1-supply = <&vph_pwr>;
+ vdd-s2-supply = <&vph_pwr>;
+ vdd-s5-supply = <&vph_pwr>;
+ vdd-s7-supply = <&vph_pwr>;
+ vdd-s9-supply = <&vph_pwr>;
+ vdd-s10-supply = <&vph_pwr>;
+
+ vdd-l1-l12-supply = <&vreg_s1b_1p856>;
+ vdd-l2-l8-supply = <&vreg_s1b_1p856>;
+ vdd-l3-l4-l5-l7-l13-supply = <&vreg_bob>;
+ vdd-l6-l9-l11-supply = <&vreg_bob>;
+ vdd-l10-supply = <&vreg_s7b_0p952>;
+
+ vdd-bob-supply = <&vph_pwr>;
+
+ /*
+ * S2, S5, S7, S10 are ARCs:
+ * S2 - cx.lvl,
+ * S5 - mss.lvl,
+ * S7 - gfx.lvl,
+ * S10 - mx.lvl.
+ */
+
+ vdd22_wlbtpa_ch0:
+ vdd22_wlbtpa_ch1:
+ vdd22_wlbtppa_ch0:
+ vdd22_wlbtppa_ch1:
+ vdd22_wlpa5g_ch0:
+ vdd22_wlpa5g_ch1:
+ vdd22_wlppa5g_ch0:
+ vdd22_wlppa5g_ch1:
+ vreg_s1c_2p2: smps1 {
+ regulator-name = "vreg_s1c_2p2";
+ regulator-min-microvolt = <2190000>;
+ regulator-max-microvolt = <2210000>;
+ };
+
+ vdd_px1:
+ vreg_s9c_0p676: smps9 {
+ regulator-name = "vreg_s9c_0p676";
+ regulator-min-microvolt = <1010000>;
+ regulator-max-microvolt = <1170000>;
+ };
+
+ vdd_a_apc_cs_1p8:
+ vdd_a_cxo_1p8:
+ vdd_a_gfx_cs_1p8:
+ vdd_a_qrefs_1p8:
+ vdd_a_turing_q6_cs_1p8:
+ vdd_a_usbhs_1p8:
+ vdd_qfprom:
+ vreg_l1c_1p8: ldo1 {
+ regulator-name = "vreg_l1c_1p8";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1980000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l2c_1p8: ldo2 {
+ regulator-name = "vreg_l2c_1p8";
+ regulator-min-microvolt = <1620000>;
+ regulator-max-microvolt = <1980000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vdd_ts:
+ vreg_l3c_3p0: ldo3 {
+ regulator-name = "vreg_l3c_3p0";
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <3540000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vdd_px5:
+ vreg_l4c_1p8_3p0: ldo4 {
+ regulator-name = "vreg_l4c_1p8_3p0";
+ regulator-min-microvolt = <1620000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vdd_px6:
+ vreg_l5c_1p8_3p0: ldo5 {
+ regulator-name = "vreg_l5c_1p8_3p0";
+ regulator-min-microvolt = <1620000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vdd_px2:
+ vreg_l6c_2p96: ldo6 {
+ regulator-name = "vreg_l6c_2p96";
+ regulator-min-microvolt = <1650000>;
+ regulator-max-microvolt = <3544000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vdd_sensor_3p3:
+ vreg_l7c_3p0: ldo7 {
+ regulator-name = "vreg_l7c_3p0";
+ regulator-min-microvolt = <3000000>;
+ regulator-max-microvolt = <3544000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vdd_sensor_1p8:
+ vreg_l8c_1p8: ldo8 {
+ regulator-name = "vreg_l8c_1p8";
+ regulator-min-microvolt = <1620000>;
+ regulator-max-microvolt = <2000000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vreg_l9c_2p96: ldo9 {
+ regulator-name = "vreg_l9c_2p96";
+ regulator-min-microvolt = <2700000>;
+ regulator-max-microvolt = <3544000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vdd_a_csi_01_0p9:
+ vdd_a_csi_23_0p9:
+ vdd_a_csi_4_0p9:
+ vdd_a_dsi_0_0p9:
+ vdd_a_dsi_0_pll_0p9:
+ vdd_a_gnss_0p9:
+ vdd_a_qlink_0_0p9:
+ vdd_a_qlink_0_0p9_ck:
+ vdd_a_qlink_1_0p9:
+ vdd_a_qlink_1_0p9_ck:
+ vdd_a_qrefs_0p875_1:
+ vdd_a_qrefs_0p875_2:
+ vdd_a_qrefs_0p875_3:
+ vdd_a_qrefs_0p875_4:
+ vdd_a_qrefs_0p875_5:
+ vdd_a_qrefs_0p875_6:
+ vdd_a_qrefs_0p875_7:
+ vdd_a_qrefs_0p875_8:
+ vdd_a_qrefs_0p875_9:
+ vdd_a_ufs_0_core:
+ vdd_a_usbhs_core:
+ vdd_vref_0p9:
+ vreg_l10c_0p88: ldo10 {
+ regulator-name = "vreg_l10c_0p88";
+ regulator-min-microvolt = <720000>;
+ regulator-max-microvolt = <1050000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ regulator-allow-set-load;
+ regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+ RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vdd_fm:
+ vdd_wlan_fem:
+ vreg_l11c_2p8: ldo11 {
+ regulator-name = "vreg_l11c_2p8";
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <3544000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vdd_io_oled:
+ vreg_l12c_1p8: ldo12 {
+ regulator-name = "vreg_l12c_1p8";
+ regulator-min-microvolt = <1650000>;
+ regulator-max-microvolt = <2000000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vdd_oled:
+ vreg_l13c_3p0: ldo13 {
+ regulator-name = "vreg_l13c_3p0";
+ regulator-min-microvolt = <2700000>;
+ regulator-max-microvolt = <3544000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
+ vdd_flash:
+ vdd_mic_bias:
+ vreg_bob: bob {
+ regulator-name = "vreg_bob";
+ regulator-min-microvolt = <3008000>;
+ regulator-max-microvolt = <3960000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_AUTO>;
+ };
+ };
+};
+
+&cci0 {
+ status = "okay";
+};
+
+&cci0_i2c0 {
+ /* sony,imx471 (Front) */
+};
+
+&cci1 {
+ status = "okay";
+};
+
+&cci1_i2c0 {
+ /* samsung,s5kjn1 (Rear-aux UW) */
+};
+
+&cci1_i2c1 {
+ /* sony,imx766 (Rear Wide) */
+};
+
+&gcc {
+ protected-clocks = <GCC_CFG_NOC_LPASS_CLK>,
+ <GCC_MSS_CFG_AHB_CLK>,
+ <GCC_MSS_OFFLINE_AXI_CLK>,
+ <GCC_MSS_Q6SS_BOOT_CLK_SRC>,
+ <GCC_MSS_Q6_MEMNOC_AXI_CLK>,
+ <GCC_MSS_SNOC_AXI_CLK>,
+ <GCC_QSPI_CNOC_PERIPH_AHB_CLK>,
+ <GCC_QSPI_CORE_CLK>,
+ <GCC_QSPI_CORE_CLK_SRC>,
+ <GCC_SEC_CTRL_CLK_SRC>,
+ <GCC_WPSS_AHB_BDG_MST_CLK>,
+ <GCC_WPSS_AHB_CLK>,
+ <GCC_WPSS_RSCP_CLK>;
+};
+
+&gpi_dma0 {
+ status = "okay";
+};
+
+&gpi_dma1 {
+ status = "okay";
+};
+
+&gpu_zap_shader {
+ firmware-name = "qcom/sm7325/nothing/spacewar/a660_zap.mbn";
+};
+
+&i2c1 {
+ clock-frequency = <100000>;
+ status = "okay";
+
+ /* awinic,aw21018 (Glyph LED) @ 20 */
+
+ typec-mux@42 {
+ compatible = "fcs,fsa4480";
+ reg = <0x42>;
+
+ vcc-supply = <&vreg_bob>;
+
+ mode-switch;
+ orientation-switch;
+
+ port {
+ fsa4480_sbu_mux: endpoint {
+ remote-endpoint = <&pmic_glink_sbu>;
+ };
+ };
+ };
+};
+
+&i2c2 {
+ clock-frequency = <100000>;
+ status = "okay";
+
+ /* nxp,tfa9873 (EAR speaker codec) @ 34 */
+ /* nxp,tfa9873 (Main speaker codec) @ 35 */
+};
+
+&i2c9 {
+ clock-frequency = <1000000>;
+ status = "okay";
+
+ nfc@28 {
+ compatible = "nxp,pn553",
+ "nxp,nxp-nci-i2c";
+ reg = <0x28>;
+
+ interrupt-parent = <&tlmm>;
+ interrupts = <41 IRQ_TYPE_EDGE_RISING>;
+
+ enable-gpios = <&tlmm 38 GPIO_ACTIVE_HIGH>;
+ firmware-gpios = <&tlmm 40 GPIO_ACTIVE_HIGH>;
+
+ pinctrl-0 = <&nfc_en>,
+ <&nfc_clk_req>,
+ <&nfc_dwl_req>,
+ <&nfc_int_req>;
+ pinctrl-names = "default";
+ };
+};
+
+&ipa {
+ qcom,gsi-loader = "self";
+ memory-region = <&ipa_fw_mem>;
+ firmware-name = "qcom/sm7325/nothing/spacewar/ipa_fws.mbn";
+
+ status = "okay";
+};
+
+/* MDSS remains disabled until the panel driver is present. */
+&mdss_dsi {
+ vdda-supply = <&vdd_a_dsi_0_1p2>;
+
+ /* Visionox RM692E5 panel */
+};
+
+&mdss_dsi_phy {
+ vdds-supply = <&vdd_a_dsi_0_0p9>;
+};
+
+&pm7325_gpios {
+ gpio-line-names = "NC", /* GPIO_1 */
+ "PA_THERM3",
+ "PA_THERM4",
+ "NC",
+ "NC",
+ "KYPD_VOLP_N",
+ "NC",
+ "NC",
+ "NC",
+ "NC"; /* GPIO_10 */
+
+ kypd_volp_n: kypd-volp-n-state {
+ pins = "gpio6";
+ function = PMIC_GPIO_FUNC_NORMAL;
+ bias-pull-up;
+ input-enable;
+ power-source = <1>;
+ };
+};
+
+&pm8350c_flash {
+ status = "okay";
+
+ led-0 {
+ function = LED_FUNCTION_FLASH;
+ color = <LED_COLOR_ID_WHITE>;
+ led-sources = <1>, <4>;
+ led-max-microamp = <500000>;
+ flash-max-microamp = <1500000>;
+ flash-max-timeout-us = <1280000>;
+ };
+};
+
+&pmk8350_adc_tm {
+ status = "okay";
+
+ /* PMK8350 */
+ xo-therm@0 {
+ reg = <0>;
+ io-channels = <&pmk8350_vadc PMK8350_ADC7_AMUX_THM1_100K_PU>;
+ qcom,ratiometric;
+ qcom,hw-settle-time-us = <200>;
+ };
+
+ /* PM7325 */
+ quiet-therm@1 {
+ reg = <1>;
+ io-channels = <&pmk8350_vadc PM7325_ADC7_AMUX_THM1_100K_PU>;
+ qcom,ratiometric;
+ qcom,hw-settle-time-us = <200>;
+ };
+
+ cam-flash-therm@2 {
+ reg = <2>;
+ io-channels = <&pmk8350_vadc PM7325_ADC7_AMUX_THM2_100K_PU>;
+ qcom,ratiometric;
+ qcom,hw-settle-time-us = <200>;
+ };
+
+ sdm-skin-therm@3 {
+ reg = <3>;
+ io-channels = <&pmk8350_vadc PM7325_ADC7_AMUX_THM3_100K_PU>;
+ qcom,ratiometric;
+ qcom,hw-settle-time-us = <200>;
+ };
+
+ wide-rfc-therm@4 {
+ reg = <4>;
+ io-channels = <&pmk8350_vadc PM7325_ADC7_AMUX_THM4_100K_PU>;
+ qcom,ratiometric;
+ qcom,hw-settle-time-us = <200>;
+ };
+
+ /* PM8350B */
+ usb-conn-therm@5 {
+ reg = <5>;
+ io-channels = <&pmk8350_vadc PM8350B_ADC7_AMUX_THM4_100K_PU>;
+ qcom,ratiometric;
+ qcom,hw-settle-time-us = <200>;
+ };
+
+ chg-skin-therm@6 {
+ reg = <6>;
+ io-channels = <&pmk8350_vadc PM8350B_ADC7_GPIO2_100K_PU>;
+ qcom,ratiometric;
+ qcom,hw-settle-time-us = <200>;
+ };
+};
+
+&pmk8350_rtc {
+ status = "okay";
+};
+
+&pmk8350_vadc {
+ /* PMK8350 */
+ channel@44 {
+ reg = <PMK8350_ADC7_AMUX_THM1_100K_PU>;
+ qcom,ratiometric;
+ qcom,hw-settle-time = <200>;
+ qcom,pre-scaling = <1 1>;
+ label = "pmk8350_xo_therm";
+ };
+
+ /* PM7325 */
+ channel@144 {
+ reg = <PM7325_ADC7_AMUX_THM1_100K_PU>;
+ qcom,ratiometric;
+ qcom,hw-settle-time = <200>;
+ qcom,pre-scaling = <1 1>;
+ label = "pm7325_quiet_therm";
+ };
+
+ channel@145 {
+ reg = <PM7325_ADC7_AMUX_THM2_100K_PU>;
+ qcom,ratiometric;
+ qcom,hw-settle-time = <200>;
+ qcom,pre-scaling = <1 1>;
+ label = "pm7325_cam_flash_therm";
+ };
+
+ channel@146 {
+ reg = <PM7325_ADC7_AMUX_THM3_100K_PU>;
+ qcom,ratiometric;
+ qcom,hw-settle-time = <200>;
+ qcom,pre-scaling = <1 1>;
+ label = "pm7325_sdm_skin_therm";
+ };
+
+ channel@147 {
+ reg = <PM7325_ADC7_AMUX_THM4_100K_PU>;
+ qcom,ratiometric;
+ qcom,hw-settle-time = <200>;
+ qcom,pre-scaling = <1 1>;
+ label = "pm7325_wide_rfc_therm";
+ };
+
+ channel@14a {
+ reg = <PM7325_ADC7_GPIO1_100K_PU>;
+ qcom,ratiometric;
+ qcom,hw-settle-time = <200>;
+ qcom,pre-scaling = <1 1>;
+ label = "pm7325_pa3_therm";
+ };
+
+ channel@14b {
+ reg = <PM7325_ADC7_GPIO2_100K_PU>;
+ qcom,ratiometric;
+ qcom,hw-settle-time = <200>;
+ qcom,pre-scaling = <1 1>;
+ label = "pm7325_pa4_therm";
+ };
+
+ /* PM8350B */
+ channel@344 {
+ reg = <PM8350B_ADC7_AMUX_THM1_100K_PU>;
+ qcom,ratiometric;
+ qcom,hw-settle-time = <200>;
+ qcom,pre-scaling = <1 1>;
+ label = "pm8350b_batt_therm";
+ };
+
+ channel@347 {
+ reg = <PM8350B_ADC7_AMUX_THM4_100K_PU>;
+ qcom,ratiometric;
+ qcom,hw-settle-time = <200>;
+ qcom,pre-scaling = <1 1>;
+ label = "pm8350b_usb_conn_therm";
+ };
+
+ channel@34b {
+ reg = <PM8350B_ADC7_GPIO2_100K_PU>;
+ qcom,ratiometric;
+ qcom,hw-settle-time = <200>;
+ qcom,pre-scaling = <1 1>;
+ label = "pm8350b_chg_skin_therm";
+ };
+
+ channel@34c {
+ reg = <PM8350B_ADC7_GPIO3_100K_PU>;
+ qcom,ratiometric;
+ qcom,hw-settle-time = <200>;
+ qcom,pre-scaling = <1 1>;
+ label = "pm8350b_usb_therm2";
+ };
+};
+
+&pon_pwrkey {
+ status = "okay";
+};
+
+&pon_resin {
+ linux,code = <KEY_VOLUMEDOWN>;
+ status = "okay";
+};
+
+&q6afedai {
+ dai@16 {
+ reg = <PRIMARY_MI2S_RX>;
+ qcom,sd-lines = <1>;
+ };
+};
+
+&q6asmdai {
+ dai@0 {
+ reg = <0>;
+ };
+};
+
+&qfprom {
+ vcc-supply = <&vdd_qfprom>;
+};
+
+&qup_uart5_rx {
+ drive-strength = <2>;
+ bias-disable;
+};
+
+&qup_uart5_tx {
+ drive-strength = <2>;
+ bias-disable;
+};
+
+&qupv3_id_0 {
+ status = "okay";
+};
+
+&qupv3_id_1 {
+ status = "okay";
+};
+
+&remoteproc_adsp {
+ firmware-name = "qcom/sm7325/nothing/spacewar/adsp.mbn";
+ status = "okay";
+};
+
+&remoteproc_cdsp {
+ firmware-name = "qcom/sm7325/nothing/spacewar/cdsp.mbn";
+ status = "okay";
+};
+
+&remoteproc_mpss {
+ firmware-name = "qcom/sm7325/nothing/spacewar/modem.mbn";
+ status = "okay";
+};
+
+&remoteproc_wpss {
+ firmware-name = "qcom/sm7325/nothing/spacewar/wpss.mbn";
+ status = "okay";
+};
+
+&spi13 {
+ status = "okay";
+
+ /* focaltech,ft3680 (Touchscreen) @ 0 */
+};
+
+&tlmm {
+ /* 56-59: Fingerprint reader (SPI) */
+ gpio-reserved-ranges = <56 4>;
+
+ bt_uart_sleep_cts: bt-uart-sleep-cts-state {
+ pins = "gpio28";
+ function = "gpio";
+ bias-bus-hold;
+ };
+
+ bt_uart_sleep_rts: bt-uart-sleep-rts-state {
+ pins = "gpio29";
+ function = "gpio";
+ bias-pull-down;
+ };
+
+ bt_uart_sleep_txd: bt-uart-sleep-txd-state {
+ pins = "gpio30";
+ function = "gpio";
+ bias-pull-up;
+ };
+
+ bt_uart_sleep_rxd: bt-uart-sleep-rxd-state {
+ pins = "gpio31";
+ function = "gpio";
+ bias-pull-up;
+ };
+
+ nfc_en: nfc-en-state {
+ pins = "gpio38";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-disable;
+ };
+
+ nfc_clk_req: nfc-clk-req-state {
+ pins = "gpio39";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-disable;
+ };
+
+ nfc_dwl_req: nfc-dwl-req-state {
+ pins = "gpio40";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-disable;
+ };
+
+ nfc_int_req: nfc-int-req-state {
+ pins = "gpio41";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
+
+ hst_bt_en: hst-bt-en-state {
+ pins = "gpio85";
+ function = "gpio";
+ output-low;
+ bias-disable;
+ };
+
+ hst_sw_ctrl: hst-sw-ctrl-state {
+ pins = "gpio86";
+ function = "gpio";
+ bias-pull-down;
+ };
+};
+
+&uart5 {
+ status = "okay";
+};
+
+&uart7 {
+ /delete-property/interrupts;
+ interrupts-extended = <&intc GIC_SPI 608 IRQ_TYPE_LEVEL_HIGH>,
+ <&tlmm 31 IRQ_TYPE_EDGE_FALLING>;
+
+ pinctrl-1 = <&bt_uart_sleep_cts>,
+ <&bt_uart_sleep_rts>,
+ <&bt_uart_sleep_txd>,
+ <&bt_uart_sleep_rxd>;
+ pinctrl-names = "default", "sleep";
+
+ status = "okay";
+
+ bluetooth: bluetooth {
+ compatible = "qcom,wcn6750-bt";
+
+ pinctrl-0 = <&hst_bt_en>,
+ <&hst_sw_ctrl>;
+ pinctrl-names = "default";
+
+ enable-gpios = <&tlmm 85 GPIO_ACTIVE_HIGH>;
+ swctrl-gpios = <&tlmm 86 GPIO_ACTIVE_HIGH>;
+
+ vddio-supply = <&vreg_l19b_1p8>;
+ vddaon-supply = <&vreg_s7b_0p952>;
+ vddbtcxmx-supply = <&vreg_s7b_0p952>;
+ vddrfacmn-supply = <&vreg_s7b_0p952>;
+ vddrfa0p8-supply = <&vreg_s7b_0p952>;
+ vddrfa1p7-supply = <&vdd19_pmu_rfa_i>;
+ vddrfa1p2-supply = <&vdd13_pmu_rfa_i>;
+ vddrfa2p2-supply = <&vreg_s1c_2p2>;
+ vddasd-supply = <&vreg_l11c_2p8>;
+ max-speed = <3200000>;
+
+ qcom,local-bd-address-broken;
+ };
+};
+
+&ufs_mem_hc {
+ reset-gpios = <&tlmm 175 GPIO_ACTIVE_LOW>;
+
+ vcc-supply = <&vreg_l7b_2p96>;
+ vcc-max-microamp = <800000>;
+ /*
+ * Technically l9b enables an eLDO (supplied by s1b) which then powers
+ * VCCQ2 of the UFS.
+ */
+ vccq-supply = <&vreg_l9b_1p2>;
+ vccq-max-microamp = <900000>;
+
+ status = "okay";
+};
+
+&ufs_mem_phy {
+ vdda-phy-supply = <&vdd_a_ufs_0_core>;
+ vdda-pll-supply = <&vdd_a_ufs_0_1p2>;
+ status = "okay";
+};
+
+&usb_1 {
+ /* USB 2.0 only */
+ qcom,select-utmi-as-pipe-clk;
+ status = "okay";
+};
+
+&usb_1_dwc3 {
+ dr_mode = "otg";
+ usb-role-switch;
+ maximum-speed = "high-speed";
+ /* Remove USB3 phy */
+ phys = <&usb_1_hsphy>;
+ phy-names = "usb2-phy";
+};
+
+&usb_1_dwc3_hs {
+ remote-endpoint = <&pmic_glink_hs_in>;
+};
+
+&usb_1_hsphy {
+ vdda-pll-supply = <&vdd_a_usbhs_core>;
+ vdda18-supply = <&vdd_a_usbhs_1p8>;
+ vdda33-supply = <&vdd_a_usbhs_3p1>;
+ status = "okay";
+};
+
+&venus {
+ firmware-name = "qcom/sm7325/nothing/spacewar/vpu20_1v.mbn";
+ status = "okay";
+};
+
+&wifi {
+ status = "okay";
+};
--
2.45.2
^ permalink raw reply related [flat|nested] 27+ messages in thread* Re: [PATCH v2 00/11] Add Nothing Phone (1) support
2024-08-08 18:40 [PATCH v2 00/11] Add Nothing Phone (1) support Danila Tikhonov
` (10 preceding siblings ...)
2024-08-08 18:40 ` [PATCH v2 11/11] arm64: dts: qcom: sm7325: Add device-tree for " Danila Tikhonov
@ 2024-08-12 15:09 ` Rob Herring (Arm)
2024-08-15 21:56 ` (subset) " Bjorn Andersson
12 siblings, 0 replies; 27+ messages in thread
From: Rob Herring (Arm) @ 2024-08-12 15:09 UTC (permalink / raw)
To: Danila Tikhonov
Cc: neil.armstrong, ulf.hansson, linux-hardening, dmitry.baryshkov,
linux-kernel, kees, krzk+dt, heiko.stuebner, devicetree,
macromorgan, linux-pm, viresh.kumar, lpieralisi, quic_rjendra,
kuba, linux-arm-msm, pabeni, fekz115, linux, andre.przywara,
conor+dt, konradybcio, gpiccoli, andersson, rafael, netdev, rafal,
tony.luck, davidwronek, linus.walleij, edumazet, davem
On Thu, 08 Aug 2024 21:40:14 +0300, Danila Tikhonov wrote:
> This series of patches adds support for the Nothing Phone (1), identified
> as nothing,spacewar. The Nothing Phone (1) is built on the Qualcomm
> Snapdragon 778G+ (SM7325-AE, also known as yupik).
>
> SM7325 is identical to SC7280 just as SM7125 is identical to SC7180, so
> SM7325 devicetree imports SC7280 devicetree as a base.
>
> All of these patches are essential for the integration of the Nothing
> Phone (1) into the kernel. The inclusion of SoC IDs is particularly
> important, as I encounter crash dumps if the device tree lacks msm and
> board id information.
>
> Changes in v2:
> - Add Krzysztof's R-b tag (patches no. 1, 2, 10)
> - Add Dmitry's R-b tag (patches no. 3, 4, 8)
> - Document SM7325 as fallback to QCM6490 (patch no. 5)
> - Drop patch no. 6 from v1
> - Document PN553 NFC IC as fallback to nxp-nci-i2c (patch no. 6)
> - Add Krzysztof's A-b tag (patches no. 7, 9)
> - Switch nl.nothing.tech/nothing.tech in commit msg (patch no. 9)
> - Add fallback compatibility for NFC (patch no. 10)
> - Fix interrupt type for NFC (patch no. 10)
> Note: Rob's A-b tag (patch no. 5) was not added because the patch was
> fixed. Please look at it again.
> - Link to v1:
> https://lore.kernel.org/all/20240729201843.142918-1-danila@jiaxyga.com/
>
> To: Rob Herring <robh@kernel.org>
> To: Krzysztof Kozlowski <krzk+dt@kernel.org>
> To: Conor Dooley <conor+dt@kernel.org>
> To: Bjorn Andersson <andersson@kernel.org>
> To: Konrad Dybcio <konradybcio@kernel.org>
> To: "David S. Miller" <davem@davemloft.net>
> To: Eric Dumazet <edumazet@google.com>
> To: Jakub Kicinski <kuba@kernel.org>
> To: Paolo Abeni <pabeni@redhat.com>
> To: "Rafael J. Wysocki" <rafael@kernel.org>
> To: Viresh Kumar <viresh.kumar@linaro.org>
> To: Kees Cook <kees@kernel.org>
> To: Tony Luck <tony.luck@intel.com>
> To: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
> To: Ulf Hansson <ulf.hansson@linaro.org>
> To: Andre Przywara <andre.przywara@arm.com>
> To: Rajendra Nayak <quic_rjendra@quicinc.com>
> To: David Wronek <davidwronek@gmail.com>
> To: Neil Armstrong <neil.armstrong@linaro.org>
> To: Heiko Stuebner <heiko.stuebner@cherry.de>
> To: "Rafał Miłecki" <rafal@milecki.pl>
> To: Chris Morgan <macromorgan@hotmail.com>
> To: Linus Walleij <linus.walleij@linaro.org>
> To: Lorenzo Pieralisi <lpieralisi@kernel.org>
> To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> To: Eugene Lepshy <fekz115@gmail.com>
> Cc: devicetree@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-arm-msm@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Cc: linux-pm@vger.kernel.org
> Cc: linux-hardening@vger.kernel.org
> Cc: linux@mainlining.org
> Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
>
> Danila Tikhonov (9):
> dt-bindings: arm: qcom,ids: Add IDs for SM7325 family
> soc: qcom: socinfo: Add Soc IDs for SM7325 family
> cpufreq: Add SM7325 to cpufreq-dt-platdev blocklist
> soc: qcom: pd_mapper: Add SM7325 compatible
> dt-bindings: soc: qcom: qcom,pmic-glink: Document SM7325 compatible
> dt-bindings: nfc: nxp,nci: Document PN553 compatible
> dt-bindings: arm: cpus: Add qcom kryo670 compatible
> dt-bindings: vendor-prefixes: Add Nothing Technology Limited
> dt-bindings: arm: qcom: Add SM7325 Nothing Phone 1
>
> Eugene Lepshy (2):
> arm64: dts: qcom: Add SM7325 device tree
> arm64: dts: qcom: sm7325: Add device-tree for Nothing Phone 1
>
> .../devicetree/bindings/arm/cpus.yaml | 1 +
> .../devicetree/bindings/arm/qcom.yaml | 6 +
> .../devicetree/bindings/net/nfc/nxp,nci.yaml | 1 +
> .../bindings/soc/qcom/qcom,pmic-glink.yaml | 5 +
> .../devicetree/bindings/vendor-prefixes.yaml | 2 +
> arch/arm64/boot/dts/qcom/Makefile | 1 +
> .../boot/dts/qcom/sm7325-nothing-spacewar.dts | 1263 +++++++++++++++++
> arch/arm64/boot/dts/qcom/sm7325.dtsi | 17 +
> drivers/cpufreq/cpufreq-dt-platdev.c | 1 +
> drivers/soc/qcom/qcom_pd_mapper.c | 1 +
> drivers/soc/qcom/socinfo.c | 2 +
> include/dt-bindings/arm/qcom,ids.h | 2 +
> 12 files changed, 1302 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dts
> create mode 100644 arch/arm64/boot/dts/qcom/sm7325.dtsi
>
> --
> 2.45.2
>
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y qcom/sm7325-nothing-spacewar.dtb' for 20240808184048.63030-1-danila@jiaxyga.com:
arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dtb: /: qcom,board-id: False schema does not allow [[65547, 0]]
from schema $id: http://devicetree.org/schemas/arm/qcom.yaml#
arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dtb: /: qcom,msm-id: False schema does not allow [[475, 65536]]
from schema $id: http://devicetree.org/schemas/arm/qcom.yaml#
arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dtb: pcie@1c08000: interrupts: [[0, 307, 4], [0, 308, 4], [0, 309, 4], [0, 312, 4], [0, 313, 4], [0, 314, 4], [0, 374, 4], [0, 375, 4]] is too long
from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-sc7280.yaml#
arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dtb: pcie@1c08000: interrupt-names:0: 'msi' was expected
from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-sc7280.yaml#
arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dtb: pcie@1c08000: interrupt-names: ['msi0', 'msi1', 'msi2', 'msi3', 'msi4', 'msi5', 'msi6', 'msi7'] is too long
from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-sc7280.yaml#
arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dtb: usb@8cf8800: interrupt-names: ['pwr_event', 'hs_phy_irq', 'dp_hs_phy_irq', 'dm_hs_phy_irq'] is too short
from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml#
arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dtb: video-codec@aa00000: iommus: [[68, 8576, 32]] is too short
from schema $id: http://devicetree.org/schemas/media/qcom,sc7280-venus.yaml#
^ permalink raw reply [flat|nested] 27+ messages in thread* Re: (subset) [PATCH v2 00/11] Add Nothing Phone (1) support
2024-08-08 18:40 [PATCH v2 00/11] Add Nothing Phone (1) support Danila Tikhonov
` (11 preceding siblings ...)
2024-08-12 15:09 ` [PATCH v2 00/11] Add Nothing Phone (1) support Rob Herring (Arm)
@ 2024-08-15 21:56 ` Bjorn Andersson
12 siblings, 0 replies; 27+ messages in thread
From: Bjorn Andersson @ 2024-08-15 21:56 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, konradybcio, davem, edumazet, kuba,
pabeni, rafael, viresh.kumar, kees, tony.luck, gpiccoli,
ulf.hansson, andre.przywara, quic_rjendra, davidwronek,
neil.armstrong, heiko.stuebner, rafal, macromorgan, linus.walleij,
lpieralisi, dmitry.baryshkov, fekz115, Danila Tikhonov
Cc: devicetree, linux-kernel, linux-arm-msm, netdev, linux-pm,
linux-hardening, linux
On Thu, 08 Aug 2024 21:40:14 +0300, Danila Tikhonov wrote:
> This series of patches adds support for the Nothing Phone (1), identified
> as nothing,spacewar. The Nothing Phone (1) is built on the Qualcomm
> Snapdragon 778G+ (SM7325-AE, also known as yupik).
>
> SM7325 is identical to SC7280 just as SM7125 is identical to SC7180, so
> SM7325 devicetree imports SC7280 devicetree as a base.
>
> [...]
Applied, thanks!
[01/11] dt-bindings: arm: qcom,ids: Add IDs for SM7325 family
commit: c580e7bfc0cd140b8d3cf73183e08ca8b23326db
[02/11] soc: qcom: socinfo: Add Soc IDs for SM7325 family
commit: 31150c9e87b4a8fe8e726a6f50ac0933f5075532
[04/11] soc: qcom: pd_mapper: Add SM7325 compatible
commit: 79b26c110545530fa2945050a2ffbb3c4e270228
[05/11] dt-bindings: soc: qcom: qcom,pmic-glink: Document SM7325 compatible
commit: e6b666de995e993bcda883ff045164f090e5506d
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 27+ messages in thread