devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] dt-bindings: net: convert maxim,ds26522.txt to yaml format
@ 2024-08-09 14:32 Frank Li
  2024-08-09 14:32 ` [PATCH v3 1/1] arm64: dts: imx93: add lpi2c1 and st lsm6dso node Frank Li
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Frank Li @ 2024-08-09 14:32 UTC (permalink / raw)
  To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	open list:NETWORKING DRIVERS,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list
  Cc: imx

Convert binding doc maxim,ds26522.txt to yaml format.
Additional changes
- Remove spi-max-frequency because ref to
/schemas/spi/spi-peripheral-props.yaml
- Add address-cells and size-cells in example

Fix below warning:
arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dtb: /soc/spi@2100000/slic@2: failed to match any schema with compatible: ['maxim,ds26522']

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 .../devicetree/bindings/net/maxim,ds26522.txt | 13 ------
 .../bindings/net/maxim,ds26522.yaml           | 40 +++++++++++++++++++
 2 files changed, 40 insertions(+), 13 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/net/maxim,ds26522.txt
 create mode 100644 Documentation/devicetree/bindings/net/maxim,ds26522.yaml

diff --git a/Documentation/devicetree/bindings/net/maxim,ds26522.txt b/Documentation/devicetree/bindings/net/maxim,ds26522.txt
deleted file mode 100644
index ee8bb725f245a..0000000000000
--- a/Documentation/devicetree/bindings/net/maxim,ds26522.txt
+++ /dev/null
@@ -1,13 +0,0 @@
-* Maxim (Dallas) DS26522 Dual T1/E1/J1 Transceiver
-
-Required properties:
-- compatible: Should contain "maxim,ds26522".
-- reg: SPI CS.
-- spi-max-frequency: SPI clock.
-
-Example:
-	slic@1 {
-		compatible = "maxim,ds26522";
-		reg = <1>;
-		spi-max-frequency = <2000000>; /* input clock */
-	};
diff --git a/Documentation/devicetree/bindings/net/maxim,ds26522.yaml b/Documentation/devicetree/bindings/net/maxim,ds26522.yaml
new file mode 100644
index 0000000000000..6c97eda217e83
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/maxim,ds26522.yaml
@@ -0,0 +1,40 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/maxim,ds26522.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Maxim (Dallas) DS26522 Dual T1/E1/J1 Transceiver
+
+maintainers:
+  - Frank Li <Frank.Li@nxp.com>
+
+properties:
+  compatible:
+    items:
+      - const: maxim,ds26522
+
+  reg:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+
+allOf:
+  - $ref: /schemas/spi/spi-peripheral-props.yaml
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    spi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        transceiver@1 {
+            compatible = "maxim,ds26522";
+            reg = <1>;
+            spi-max-frequency = <2000000>; /* input clock */
+        };
+    };
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v3 1/1] arm64: dts: imx93: add lpi2c1 and st lsm6dso node
  2024-08-09 14:32 [PATCH 1/1] dt-bindings: net: convert maxim,ds26522.txt to yaml format Frank Li
@ 2024-08-09 14:32 ` Frank Li
  2024-08-09 14:37   ` Frank Li
  2024-08-10 12:37 ` [PATCH 1/1] dt-bindings: net: convert maxim,ds26522.txt to yaml format Krzysztof Kozlowski
  2024-08-13 19:48 ` Rob Herring
  2 siblings, 1 reply; 5+ messages in thread
From: Frank Li @ 2024-08-09 14:32 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	open list
  Cc: imx

From: Clark Wang <xiaoning.wang@nxp.com>

The i.MX93 11x11 EVK has a ST LSM6DSO connected to I2C, which a is 6-axis
IMU (inertial measurement unit = accelerometer & gyroscope). So add the
missing parts to the DTS file.

Signed-off-by: Clark Wang <xiaoning.wang@nxp.com>
Reviewed-by: Haibo Chen <haibo.chen@nxp.com>
Signed-off-by: Li Yang <leoyang.li@nxp.com>
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Change from v2 to v3
- remove reduntant address-cell and size-cell
Change from v1 to v2
- update commit message.
- use common node name.
---
 .../boot/dts/freescale/imx93-11x11-evk.dts    | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
index 2597c5b2eacb4..e845ad896abeb 100644
--- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
@@ -145,6 +145,18 @@ ethphy2: ethernet-phy@2 {
 	};
 };
 
+&lpi2c1 {
+	clock-frequency = <400000>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_lpi2c1>;
+	status = "okay";
+
+	inertial-meter@6a {
+		compatible = "st,lsm6dso";
+		reg = <0x6a>;
+	};
+};
+
 &lpi2c2 {
 	clock-frequency = <400000>;
 	pinctrl-names = "default", "sleep";
@@ -504,6 +516,13 @@ MX93_PAD_DAP_TCLK_SWCLK__LPUART5_CTS_B		0x31e
 		>;
 	};
 
+	pinctrl_lpi2c1: lpi2c1grp {
+		fsl,pins = <
+			MX93_PAD_I2C1_SCL__LPI2C1_SCL			0x40000b9e
+			MX93_PAD_I2C1_SDA__LPI2C1_SDA			0x40000b9e
+		>;
+	};
+
 	pinctrl_lpi2c2: lpi2c2grp {
 		fsl,pins = <
 			MX93_PAD_I2C2_SCL__LPI2C2_SCL			0x40000b9e
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v3 1/1] arm64: dts: imx93: add lpi2c1 and st lsm6dso node
  2024-08-09 14:32 ` [PATCH v3 1/1] arm64: dts: imx93: add lpi2c1 and st lsm6dso node Frank Li
@ 2024-08-09 14:37   ` Frank Li
  0 siblings, 0 replies; 5+ messages in thread
From: Frank Li @ 2024-08-09 14:37 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	open list

On Fri, Aug 09, 2024 at 10:32:07AM -0400, Frank Li wrote:
> From: Clark Wang <xiaoning.wang@nxp.com>
>
> The i.MX93 11x11 EVK has a ST LSM6DSO connected to I2C, which a is 6-axis
> IMU (inertial measurement unit = accelerometer & gyroscope). So add the
> missing parts to the DTS file.
>
> Signed-off-by: Clark Wang <xiaoning.wang@nxp.com>
> Reviewed-by: Haibo Chen <haibo.chen@nxp.com>
> Signed-off-by: Li Yang <leoyang.li@nxp.com>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>

Sorry, this one is sent out accidently at this thread. It already post at
https://lore.kernel.org/imx/20240808162157.3323811-1-Frank.Li@nxp.com/

Frank

> ---
> Change from v2 to v3
> - remove reduntant address-cell and size-cell
> Change from v1 to v2
> - update commit message.
> - use common node name.
> ---
>  .../boot/dts/freescale/imx93-11x11-evk.dts    | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> index 2597c5b2eacb4..e845ad896abeb 100644
> --- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> @@ -145,6 +145,18 @@ ethphy2: ethernet-phy@2 {
>  	};
>  };
>
> +&lpi2c1 {
> +	clock-frequency = <400000>;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_lpi2c1>;
> +	status = "okay";
> +
> +	inertial-meter@6a {
> +		compatible = "st,lsm6dso";
> +		reg = <0x6a>;
> +	};
> +};
> +
>  &lpi2c2 {
>  	clock-frequency = <400000>;
>  	pinctrl-names = "default", "sleep";
> @@ -504,6 +516,13 @@ MX93_PAD_DAP_TCLK_SWCLK__LPUART5_CTS_B		0x31e
>  		>;
>  	};
>
> +	pinctrl_lpi2c1: lpi2c1grp {
> +		fsl,pins = <
> +			MX93_PAD_I2C1_SCL__LPI2C1_SCL			0x40000b9e
> +			MX93_PAD_I2C1_SDA__LPI2C1_SDA			0x40000b9e
> +		>;
> +	};
> +
>  	pinctrl_lpi2c2: lpi2c2grp {
>  		fsl,pins = <
>  			MX93_PAD_I2C2_SCL__LPI2C2_SCL			0x40000b9e
> --
> 2.34.1
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/1] dt-bindings: net: convert maxim,ds26522.txt to yaml format
  2024-08-09 14:32 [PATCH 1/1] dt-bindings: net: convert maxim,ds26522.txt to yaml format Frank Li
  2024-08-09 14:32 ` [PATCH v3 1/1] arm64: dts: imx93: add lpi2c1 and st lsm6dso node Frank Li
@ 2024-08-10 12:37 ` Krzysztof Kozlowski
  2024-08-13 19:48 ` Rob Herring
  2 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-10 12:37 UTC (permalink / raw)
  To: Frank Li, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	open list:NETWORKING DRIVERS,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list
  Cc: imx

On 09/08/2024 16:32, Frank Li wrote:
> Convert binding doc maxim,ds26522.txt to yaml format.
> Additional changes
> - Remove spi-max-frequency because ref to
> /schemas/spi/spi-peripheral-props.yaml
> - Add address-cells and size-cells in example
> 

This could go to trivial-devices, I think. Well, fine also as is.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/1] dt-bindings: net: convert maxim,ds26522.txt to yaml format
  2024-08-09 14:32 [PATCH 1/1] dt-bindings: net: convert maxim,ds26522.txt to yaml format Frank Li
  2024-08-09 14:32 ` [PATCH v3 1/1] arm64: dts: imx93: add lpi2c1 and st lsm6dso node Frank Li
  2024-08-10 12:37 ` [PATCH 1/1] dt-bindings: net: convert maxim,ds26522.txt to yaml format Krzysztof Kozlowski
@ 2024-08-13 19:48 ` Rob Herring
  2 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2024-08-13 19:48 UTC (permalink / raw)
  To: Frank Li
  Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Krzysztof Kozlowski, Conor Dooley, open list:NETWORKING DRIVERS,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list, imx

On Fri, Aug 09, 2024 at 10:32:06AM -0400, Frank Li wrote:
> Convert binding doc maxim,ds26522.txt to yaml format.
> Additional changes
> - Remove spi-max-frequency because ref to
> /schemas/spi/spi-peripheral-props.yaml
> - Add address-cells and size-cells in example
> 
> Fix below warning:
> arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dtb: /soc/spi@2100000/slic@2: failed to match any schema with compatible: ['maxim,ds26522']
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  .../devicetree/bindings/net/maxim,ds26522.txt | 13 ------
>  .../bindings/net/maxim,ds26522.yaml           | 40 +++++++++++++++++++
>  2 files changed, 40 insertions(+), 13 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/net/maxim,ds26522.txt
>  create mode 100644 Documentation/devicetree/bindings/net/maxim,ds26522.yaml

netdev didn't pick this up, so I applied, thanks.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-08-13 19:48 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-09 14:32 [PATCH 1/1] dt-bindings: net: convert maxim,ds26522.txt to yaml format Frank Li
2024-08-09 14:32 ` [PATCH v3 1/1] arm64: dts: imx93: add lpi2c1 and st lsm6dso node Frank Li
2024-08-09 14:37   ` Frank Li
2024-08-10 12:37 ` [PATCH 1/1] dt-bindings: net: convert maxim,ds26522.txt to yaml format Krzysztof Kozlowski
2024-08-13 19:48 ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).