From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: Rob Herring <robh@kernel.org>
Cc: "Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Robert Foss" <rfoss@kernel.org>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Derek Kiernan" <derek.kiernan@amd.com>,
"Dragan Cvetic" <dragan.cvetic@amd.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Saravana Kannan" <saravanak@google.com>,
"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Paul Kocialkowski" <contact@paulk.fr>,
"Hervé Codina" <herve.codina@bootlin.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org,
"Paul Kocialkowski" <paul.kocialkowski@bootlin.com>
Subject: Re: [PATCH v3 1/7] dt-bindings: connector: add GE SUNH hotplug addon connector
Date: Wed, 14 Aug 2024 16:42:44 +0200 [thread overview]
Message-ID: <20240814164244.25e9b3f4@booty> (raw)
In-Reply-To: <20240813151901.GA953664-robh@kernel.org>
Hello Rob,
On Tue, 13 Aug 2024 09:19:01 -0600
Rob Herring <robh@kernel.org> wrote:
> On Fri, Aug 09, 2024 at 05:34:49PM +0200, Luca Ceresoli wrote:
> > Add bindings for the GE SUNH add-on connector. This is a physical,
> > hot-pluggable connector that allows to attach and detach at runtime an
> > add-on adding peripherals on non-discoverable busses.
>
> Overall, looks pretty good.
Thanks, I'm very glad it does.
> > + maxItems: 1
> > +
> > + nobus-devices:
>
> Just 'devices'.
Sure, simple enough.
> > + description:
> > + A container for devices not accessible via any data bus. Common use
> > + cases include fixed and GPIO regulators, simple video panels and LED
> > + or GPIO backlight devices. When not hot-pluggable, nodes such devices
> > + are children of the root node.
> > +
> > + This node should not be present in the connector description in the
> > + base device tree. It should be added by overlays along with a subnode
> > + per device.
> > +
> > + type: object
> > + additionalProperties: false
>
> The schema needs to work with the overlay applied too. 'true' is fine
> here.
Does additionalProperties apply to nodes as well? No properties are
supposed to be added inside this node, only nodes, so I'm not sure what
to do about additionalProperties.
Queued all other changes for v4.
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2024-08-14 14:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-09 15:34 [PATCH v3 0/7] Add support for GE SUNH hot-pluggable connector Luca Ceresoli
2024-08-09 15:34 ` [PATCH v3 1/7] dt-bindings: connector: add GE SUNH hotplug addon connector Luca Ceresoli
2024-08-09 16:33 ` Rob Herring (Arm)
2024-08-13 9:06 ` Luca Ceresoli
2024-08-13 15:19 ` Rob Herring
2024-08-14 14:42 ` Luca Ceresoli [this message]
2024-08-09 15:34 ` [PATCH v3 2/7] drm/bridge: add bridge notifier to be notified of bridge addition and removal Luca Ceresoli
2024-08-09 15:34 ` [PATCH v3 3/7] drm/encoder: add drm_encoder_cleanup_from() Luca Ceresoli
2024-08-09 15:34 ` [PATCH v3 4/7] drm/bridge: hotplug-bridge: add driver to support hot-pluggable DSI bridges Luca Ceresoli
2024-08-09 15:34 ` [PATCH v3 5/7] i2c: i2c-core-of: follow i2c-parent phandle to probe devices from added nodes Luca Ceresoli
2024-08-09 15:34 ` [PATCH v3 6/7] misc: add ge-addon-connector driver Luca Ceresoli
2024-08-09 15:34 ` [PATCH DO NOT APPLY v3 7/7] driver core: do not unblock consumers any drivers found Luca Ceresoli
2024-08-14 15:59 ` [PATCH v3 0/7] Add support for GE SUNH hot-pluggable connector Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240814164244.25e9b3f4@booty \
--to=luca.ceresoli@bootlin.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=arnd@arndb.de \
--cc=conor+dt@kernel.org \
--cc=contact@paulk.fr \
--cc=daniel@ffwll.ch \
--cc=derek.kiernan@amd.com \
--cc=devicetree@vger.kernel.org \
--cc=dragan.cvetic@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=herve.codina@bootlin.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=paul.kocialkowski@bootlin.com \
--cc=rafael@kernel.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=saravanak@google.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tzimmermann@suse.de \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).