public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Jianping.Shen@de.bosch.com
Cc: jic23@kernel.org, lars@metafoo.de, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org, dima.fedrau@gmail.com,
	marcelo.schmitt1@gmail.com, linux-iio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Christian.Lorenz3@de.bosch.com, Ulrike.Frauendorf@de.bosch.com,
	Kai.Dolde@de.bosch.com
Subject: Re: [PATCH v3 1/2] dt-bindings: iio: imu: smi240: devicetree binding
Date: Thu, 15 Aug 2024 16:38:17 +0100	[thread overview]
Message-ID: <20240815-backboned-ashen-2f1319439953@spud> (raw)
In-Reply-To: <20240815-upright-roamer-cd6b16883350@spud>

[-- Attachment #1: Type: text/plain, Size: 676 bytes --]

On Thu, Aug 15, 2024 at 04:34:05PM +0100, Conor Dooley wrote:
> On Thu, Aug 15, 2024 at 05:25:44PM +0200, Jianping.Shen@de.bosch.com wrote:
> > From: Shen Jianping <Jianping.Shen@de.bosch.com>
> > 
> > dt-bindings: iio: imu: smi240: add sensor dt-binding
> > Signed-off-by: Shen Jianping <Jianping.Shen@de.bosch.com>
> 
> There should be a blank line between the body of the commit message and
> the signoff. That said, the body here just repeats $subject - but really
> should be something more like the description in the binding.

Crap, I meant to say that with a fixed commit message,
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2024-08-15 15:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-15 15:25 [PATCH v3 0/2] iio: imu: smi240: cover-letter Jianping.Shen
2024-08-15 15:25 ` [PATCH v3 1/2] dt-bindings: iio: imu: smi240: devicetree binding Jianping.Shen
2024-08-15 15:34   ` Conor Dooley
2024-08-15 15:38     ` Conor Dooley [this message]
2024-08-16  7:26   ` Krzysztof Kozlowski
2024-08-15 15:25 ` [PATCH v3 2/2] iio: imu: smi240: imu driver Jianping.Shen
2024-08-17  1:56   ` kernel test robot
2024-08-17 16:13   ` kernel test robot
2024-08-17 16:17   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240815-backboned-ashen-2f1319439953@spud \
    --to=conor@kernel.org \
    --cc=Christian.Lorenz3@de.bosch.com \
    --cc=Jianping.Shen@de.bosch.com \
    --cc=Kai.Dolde@de.bosch.com \
    --cc=Ulrike.Frauendorf@de.bosch.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dima.fedrau@gmail.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.schmitt1@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox