devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: rockchip: add LED_FUNCTION_STATUS for RGB LEDs on Radxa E25
@ 2024-08-16 21:53 FUKAUMI Naoki
  2024-09-30 10:55 ` Heiko Stuebner
  0 siblings, 1 reply; 2+ messages in thread
From: FUKAUMI Naoki @ 2024-08-16 21:53 UTC (permalink / raw)
  To: heiko; +Cc: robh, krzk+dt, conor+dt, devicetree, linux-rockchip,
	FUKAUMI Naoki

multicolor(RGB) PWM LEDs on Radxa E25 carrier board is clearly defined
as status LED ("use it to see the status") in product overview[1].

add "function = LED_FUNCTION_STATUS" to "multi-led".

fortunately CONFIG_LEDS_PWM_MULTICOLOR is not enabled in defconfig,
this change should not affect userland(sysfs).

[1] https://radxa.com/products/network-computer/e25#overview

Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
 arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts b/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts
index 72ad74c38a2b..1eaf304d94b9 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts
@@ -16,6 +16,7 @@ pwm-leds {
 
 		multi-led {
 			color = <LED_COLOR_ID_RGB>;
+			function = LED_FUNCTION_STATUS;
 			max-brightness = <255>;
 
 			led-red {
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm64: dts: rockchip: add LED_FUNCTION_STATUS for RGB LEDs on Radxa E25
  2024-08-16 21:53 [PATCH] arm64: dts: rockchip: add LED_FUNCTION_STATUS for RGB LEDs on Radxa E25 FUKAUMI Naoki
@ 2024-09-30 10:55 ` Heiko Stuebner
  0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2024-09-30 10:55 UTC (permalink / raw)
  To: FUKAUMI Naoki
  Cc: Heiko Stuebner, robh, krzk+dt, conor+dt, linux-rockchip,
	devicetree

On Sat, 17 Aug 2024 06:53:16 +0900, FUKAUMI Naoki wrote:
> multicolor(RGB) PWM LEDs on Radxa E25 carrier board is clearly defined
> as status LED ("use it to see the status") in product overview[1].
> 
> add "function = LED_FUNCTION_STATUS" to "multi-led".
> 
> fortunately CONFIG_LEDS_PWM_MULTICOLOR is not enabled in defconfig,
> this change should not affect userland(sysfs).
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: rockchip: add LED_FUNCTION_STATUS for RGB LEDs on Radxa E25
      commit: 40c60d826f4541668d81d8ee561dced5d4950223

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-09-30 10:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-16 21:53 [PATCH] arm64: dts: rockchip: add LED_FUNCTION_STATUS for RGB LEDs on Radxa E25 FUKAUMI Naoki
2024-09-30 10:55 ` Heiko Stuebner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).