* [PATCH] ARM: dts: imx28-apx4devkit: Fix the regulator description
@ 2024-08-20 0:24 Fabio Estevam
2024-08-31 14:01 ` Shawn Guo
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2024-08-20 0:24 UTC (permalink / raw)
To: shawnguo
Cc: robh, krzk+dt, conor+dt, devicetree, linux-arm-kernel,
Fabio Estevam
From: Fabio Estevam <festevam@denx.de>
The regulator should not be placed under simple-bus.
Remove it from simple-bus to fix the following dt-schema warnings:
'regulators' does not match '^([a-z][a-z0-9\\-]+-bus|bus|localbus|soc|axi|ahb|apb)(@.+)?$'
regulators: #size-cells:0:0: 0 is not one of [1, 2]
regulators: regulator@0:reg:0: [0] is too short
regulators: 'ranges' is a required property
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
.../arm/boot/dts/nxp/mxs/imx28-apx4devkit.dts | 20 +++++++------------
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/arch/arm/boot/dts/nxp/mxs/imx28-apx4devkit.dts b/arch/arm/boot/dts/nxp/mxs/imx28-apx4devkit.dts
index f9bf40d96568..4c4ea91c286f 100644
--- a/arch/arm/boot/dts/nxp/mxs/imx28-apx4devkit.dts
+++ b/arch/arm/boot/dts/nxp/mxs/imx28-apx4devkit.dts
@@ -11,19 +11,13 @@ memory@40000000 {
reg = <0x40000000 0x04000000>;
};
- regulators {
- compatible = "simple-bus";
- #address-cells = <1>;
- #size-cells = <0>;
-
- reg_3p3v: regulator@0 {
- compatible = "regulator-fixed";
- reg = <0>;
- regulator-name = "3P3V";
- regulator-min-microvolt = <3300000>;
- regulator-max-microvolt = <3300000>;
- regulator-always-on;
- };
+
+ reg_3p3v: regulator-3p3v {
+ compatible = "regulator-fixed";
+ regulator-name = "3P3V";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-always-on;
};
sound {
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: dts: imx28-apx4devkit: Fix the regulator description
2024-08-20 0:24 [PATCH] ARM: dts: imx28-apx4devkit: Fix the regulator description Fabio Estevam
@ 2024-08-31 14:01 ` Shawn Guo
0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2024-08-31 14:01 UTC (permalink / raw)
To: Fabio Estevam
Cc: shawnguo, robh, krzk+dt, conor+dt, devicetree, linux-arm-kernel,
Fabio Estevam
On Mon, Aug 19, 2024 at 09:24:35PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> The regulator should not be placed under simple-bus.
>
> Remove it from simple-bus to fix the following dt-schema warnings:
>
> 'regulators' does not match '^([a-z][a-z0-9\\-]+-bus|bus|localbus|soc|axi|ahb|apb)(@.+)?$'
> regulators: #size-cells:0:0: 0 is not one of [1, 2]
> regulators: regulator@0:reg:0: [0] is too short
> regulators: 'ranges' is a required property
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-31 14:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-20 0:24 [PATCH] ARM: dts: imx28-apx4devkit: Fix the regulator description Fabio Estevam
2024-08-31 14:01 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).