From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3858A1531F4 for ; Wed, 21 Aug 2024 12:18:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724242687; cv=none; b=ML1RYMGwDr2Edrm2m0+IYqbgZ4anpcntWzCyDaz4Ki0NVniqhcX0gkELQM3/f7x9FgVrG7Di/pQwNOMpGOrxhBywQCTTGUqgsOvmU9qTDF6oA1Ne82rgUQdfTystB30t+3lvqKtTvBy4emf1lHPc7eHghTppkqoEo2JZ6xMVsX4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724242687; c=relaxed/simple; bh=Av8PnhltKERJzpvNW1FtpzV51cIQpkw0ZawwnlhrH30=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XeyMyY0br8tyMNrycxpt7asigVL02SqIF5IdcihAyyGTMZbqbWN1gSHSRZwdG5Pjmofs7lnQjWN66SnorMniqjrDmpXWLeKwsu1lwhKHQtiI9r/adYx9B59ZtMw8KWI04BvZQrmHLcIX3B6k6rerRX+YJbMs0D3qJN4hyh3CKWc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com; spf=pass smtp.mailfrom=ventanamicro.com; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b=J6BzlODx; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b="J6BzlODx" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4280ee5f1e3so53731245e9.0 for ; Wed, 21 Aug 2024 05:18:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1724242684; x=1724847484; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=iQMTmLPogZcziJOzZF5KtcmCsv9/KHWQ2nfDgqi45D8=; b=J6BzlODxNxguW4utX8ItopwSEzsD+n6hrsGfBji4bB79HT80yXFy/LGr2DyEihgY7O 5cCyBspHnhai8MCoQI9peJZvoYE8gq2PrSA2FzgGvq//wDq4cjiwgHvWoZbuwqwYfRX1 LpEVvy8wty5LjNv47FPiAMvAg8untbJNPRkc73kJLMTL+CJjNIjk0YhpGOcRRHAMgNXJ y7wUxl1qilZesZMxYoa0SGp/PvTnJtgd/Ie28DLkYO9QkwA60mfbzx4mVDWwODWlLBh3 p4ScRJUO6JU9engVqi3VEUP+QH1yMSmfSDwb3C96SsByMcsI/JnBPwezQx/e/ZadnSCR u+4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724242684; x=1724847484; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iQMTmLPogZcziJOzZF5KtcmCsv9/KHWQ2nfDgqi45D8=; b=EHXP/YYv0Bpjrm9IevMRFycwGsXSwDXV41Ul6bXud7cf52irNufgSYxVngbmNH9GkT Pkjisi9C/1Szo+E2ASgwGgFOI+LqpeaPcSvLBEroeQsNIejIwPoN7i9nBQjP+72GY4iE ZLHhzBDGRNggnF3PC3GoQzRnbDjUEXr/oT//yQr3fV/WGLFkXAvO8U3KonzGhSQJ3U+7 jSUkbS0usbXPywPVkCNjeo/HbXGYp0T161cvmui6WUKqpK1jy6+cDnY1JN6PHXDEYDLi KUx9cibhZt/YRgeAPFxiILU/JShUKzJCOQzGKRjMb892LH4lpcTCW4UzDc4Go3sxR6jF +kpQ== X-Forwarded-Encrypted: i=1; AJvYcCVx06/OV6UQuks9NL2vXdkIS+SXIwfToyBhHvdvMO+8z7rrF0XKJafuC5SEHBcGAlWR3Feul4od6pJA@vger.kernel.org X-Gm-Message-State: AOJu0YylpiDTv/oISYK7MbFc0KEAiDmC37Z8JnM08EQoMDss9ULELGVd SnYLqsu0y+vjAjKYHLyIrMDsYpuGlnc2fiif5GqxC7HO4uc6r1m3kMGMUkfDTxQ= X-Google-Smtp-Source: AGHT+IEvDLQ9JZtvl3rdFrkdWkXXNhlmpHGUQNicJFbEKranRXP1xwJjc3KOZvUilRQvOAzVR/r8FQ== X-Received: by 2002:a5d:6349:0:b0:371:a70d:107e with SMTP id ffacd0b85a97d-372fd57f1bcmr1514219f8f.6.1724242683523; Wed, 21 Aug 2024 05:18:03 -0700 (PDT) Received: from localhost (cst2-173-13.cust.vodafone.cz. [31.30.173.13]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-371a937a694sm11257656f8f.65.2024.08.21.05.18.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Aug 2024 05:18:02 -0700 (PDT) Date: Wed, 21 Aug 2024 14:18:01 +0200 From: Andrew Jones To: Guo Ren Cc: Alexandre Ghiti , Alexandre Ghiti , Jonathan Corbet , Paul Walmsley , Palmer Dabbelt , Albert Ou , Conor Dooley , Rob Herring , Krzysztof Kozlowski , Andrea Parri , Nathan Chancellor , Peter Zijlstra , Ingo Molnar , Will Deacon , Waiman Long , Boqun Feng , Arnd Bergmann , Leonardo Bras , linux-doc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-arch@vger.kernel.org Subject: Re: [PATCH v4 13/13] riscv: Add qspinlock support Message-ID: <20240821-6befd27b90a9e9ff89f4a277@orel> References: <20240731072405.197046-1-alexghiti@rivosinc.com> <20240731072405.197046-14-alexghiti@rivosinc.com> <20240731-ce25dcdc5ce9ccc6c82912c0@orel> <6f1bcc9b-1812-4e8c-9050-a750bfadd008@ghiti.fr> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, Aug 17, 2024 at 01:08:34PM GMT, Guo Ren wrote: ... > > So I have just checked the size of the jump table section: > > > > * defconfig: > > > > - ticket: 26928 bytes > > - combo: 28320 bytes > > > > So that's a ~5% increase. > > > > * ubuntu config > > > > - ticket: 107840 bytes > > - combo: 174752 bytes > > > > And that's a ~62% increase. > The size of the jump table section has increased from 5% to 62%. I > think some configuration triggers the jump table's debug code. If it's > not a debugging configuration, that's a bug of the Ubuntu config. And I just remembered we wanted to check with CONFIG_CC_OPTIMIZE_FOR_SIZE Thanks, drew > > > > > This is the ELF size difference between ticket and combo spinlocks: > > > > * ticket: 776915592 bytes > > * combo: 786958968 bytes > > > > So that's an increase of ~1.3% on the ELF. > > > > And the .text section size: > > > > * ticket: 12290960 bytes > > * combo: 12366644 bytes > > > > And that's a ~0.6% increase! > > > > Finally, I'd say the impact is very limited :) > > > > Thanks, > > > > Alex > > > >