From: vtpieter@gmail.com
To: pabeni@redhat.com
Cc: Tristram.Ha@microchip.com, UNGLinuxDriver@microchip.com,
andrew@lunn.ch, conor+dt@kernel.org, davem@davemloft.net,
devicetree@vger.kernel.org, edumazet@google.com,
f.fainelli@gmail.com, krzk+dt@kernel.org, kuba@kernel.org,
linux-kernel@vger.kernel.org, marex@denx.de,
netdev@vger.kernel.org, o.rempel@pengutronix.de,
olteanv@gmail.com, robh@kernel.org, woojung.huh@microchip.com
Subject: [PATCH net-next v4 2/2] net: dsa: microchip: Add KSZ8895/KSZ8864 switch support
Date: Wed, 21 Aug 2024 13:02:26 +0200 [thread overview]
Message-ID: <20240821110226.1899167-1-vtpieter@gmail.com> (raw)
In-Reply-To: <584ce622-2acf-4b6f-94e0-17ed38a491b6@redhat.com>
Hi Tristram,
> @@ -325,7 +327,7 @@ void ksz8_r_mib_pkt(struct ksz_device *dev, int port, u16 addr,
>
> void ksz8_freeze_mib(struct ksz_device *dev, int port, bool freeze)
> {
> - if (ksz_is_ksz88x3(dev))
> + if (ksz_is_ksz88x3(dev) || ksz_is_8895_family(dev))
Small comment, would it not be more clear and consistent to introduce
a new ksz_is_ksz88xx function in ksz_common.h, being ksz_is_ksz88x3 ||
ksz_is_8895_family?
That would help with the renamed ksz88x3_dev_ops that you will
encounter when rebasing. In fact, seeing your additions here, I would
propose to rename this struct to ksz88xx_dev_ops.
Cheers, Pieter
next prev parent reply other threads:[~2024-08-21 11:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-15 2:20 [PATCH net-next v4 0/2] net: dsa: microchip: Add KSZ8895/KSZ8864 switch support Tristram.Ha
2024-08-15 2:20 ` [PATCH net-next v4 1/2] dt-bindings: " Tristram.Ha
2024-08-15 2:20 ` [PATCH net-next v4 2/2] " Tristram.Ha
2024-08-20 10:08 ` Paolo Abeni
2024-08-20 10:15 ` Paolo Abeni
2024-08-21 11:02 ` vtpieter [this message]
2024-08-22 23:30 ` Tristram.Ha
2024-08-22 23:33 ` Tristram.Ha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240821110226.1899167-1-vtpieter@gmail.com \
--to=vtpieter@gmail.com \
--cc=Tristram.Ha@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).