[PATCH v3 0/1] dt-bindings: phy: ti,tcan104x-can: Document Microchip

[PATCH v3 0/1] dt-bindings: phy: ti,tcan104x-can: Document Microchip

[Ilya Orazov]

Hi all,

As suggested in the previous email conversation on this patch, I am
sending this new version as a standalone email. I hope this approach
makes it easier to review and keeps the conversation history clearer.

Thank you for your feedback!

Ilya Orazov (1):
  dt-bindings: phy: ti,tcan104x-can: Document Microchip ATA6561

 .../devicetree/bindings/phy/ti,tcan104x-can.yaml    | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)


base-commit: b311c1b497e51a628aa89e7cb954481e5f9dced2
-- 
2.34.1

[PATCH v3 1/1] dt-bindings: phy: ti,tcan104x-can: Document Microchip ATA6561

[Ilya Orazov]

Microchip ATA6561 is High-Speed CAN Transceiver with Standby Mode.
It is pin-compatible with TI TCAN1042 and has a compatible programming
model, therefore use ti,tcan1042 as fallback compatible.

Signed-off-by: Ilya Orazov <ilordash02@gmail.com>
---
 .../devicetree/bindings/phy/ti,tcan104x-can.yaml    | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
index 79dad3e89aa6..4a8c3829d85d 100644
--- a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
+++ b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
@@ -14,10 +14,15 @@ properties:
     pattern: "^can-phy"
 
   compatible:
-    enum:
-      - nxp,tjr1443
-      - ti,tcan1042
-      - ti,tcan1043
+    oneOf:
+      - items:
+          - enum:
+              - microchip,ata6561
+          - const: ti,tcan1042
+      - enum:
+          - ti,tcan1042
+          - ti,tcan1043
+          - nxp,tjr1443
 
   '#phy-cells':
     const: 0
-- 
2.34.1

Re: [PATCH v3 1/1] dt-bindings: phy: ti,tcan104x-can: Document Microchip ATA6561

[Krzysztof Kozlowski]

On Thu, Aug 22, 2024 at 12:53:57AM +0300, Ilya Orazov wrote:
> Microchip ATA6561 is High-Speed CAN Transceiver with Standby Mode.
> It is pin-compatible with TI TCAN1042 and has a compatible programming
> model, therefore use ti,tcan1042 as fallback compatible.
> 
> Signed-off-by: Ilya Orazov <ilordash02@gmail.com>
> ---

Where is the changelog?

Where is the tag you received?

Why sending it again without any of the above?

<form letter>
This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation: Please add
Acked-by/Reviewed-by/Tested-by tags when posting new versions, under
or above your Signed-off-by tag. Tag is "received", when provided
in a message replied to you on the mailing list. Tools like b4 can help
here. However, there's no need to repost patches *only* to add the tags.
The upstream maintainer will do that for tags received on the version
they apply.

https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577

If a tag was not added on purpose, please state why and what changed.
</form letter>

Best regards,
Krzysztof

Re: [PATCH v3 0/1] dt-bindings: phy: ti,tcan104x-can: Document Microchip

[Ilya Orazov]

On Thu, 22 Aug 2024 at 10:09, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Thu, Aug 22, 2024 at 12:53:56AM +0300, Ilya Orazov wrote:
> > Hi all,
> >
> > As suggested in the previous email conversation on this patch, I am
> > sending this new version as a standalone email. I hope this approach
> > makes it easier to review and keeps the conversation history clearer.
>
> Where was it suggested?
>
> Best regards,
> Krzysztof
>

Hi Krzysztof,

Conor suggested that I should not send new versions of the patch as
replies in his mail [0]. So, I sent the new one as a separate email.

0- https://lore.kernel.org/all/20240809-guru-tassel-84a14486a596@spud/

-- 
Best regards,
Ilya Orazov

Re: [PATCH v3 0/1] dt-bindings: phy: ti,tcan104x-can: Document Microchip

[Krzysztof Kozlowski]

On 22/08/2024 12:35, Ilya Orazov wrote:
> On Thu, 22 Aug 2024 at 10:09, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On Thu, Aug 22, 2024 at 12:53:56AM +0300, Ilya Orazov wrote:
>>> Hi all,
>>>
>>> As suggested in the previous email conversation on this patch, I am
>>> sending this new version as a standalone email. I hope this approach
>>> makes it easier to review and keeps the conversation history clearer.
>>
>> Where was it suggested?
>>
>> Best regards,
>> Krzysztof
>>
> 
> Hi Krzysztof,
> 
> Conor suggested that I should not send new versions of the patch as
> replies in his mail [0]. So, I sent the new one as a separate email.
> 
> 0- https://lore.kernel.org/all/20240809-guru-tassel-84a14486a596@spud/

OK, I misunderstood what you mean by "standalone email". So this was
just resend? Then patch should be marked as RESEND.

Best regards,
Krzysztof

Re: [PATCH v2 1/1] dt-bindings: phy: ti,tcan104x-can: Document Microchip ATA6561

[Krzysztof Kozlowski]

On 08/08/2024 17:48, Conor Dooley wrote:
> On Wed, Aug 07, 2024 at 09:09:56PM +0300, Ilya Orazov wrote:
>> Microchip ATA6561 is High-Speed CAN Transceiver with Standby Mode.
>> It is pin-compatible with TI TCAN1042 and has a compatible programming
>> model, therefore use ti,tcan1042 as fallback compatible.
>>
>> Signed-off-by: Ilya Orazov <ilordash02@gmail.com>
>> ---
>>  .../devicetree/bindings/phy/ti,tcan104x-can.yaml    | 13 +++++++++----
>>  1 file changed, 9 insertions(+), 4 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
>> index 79dad3e89aa6..f6f1fd843874 100644
>> --- a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
>> +++ b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
>> @@ -14,10 +14,15 @@ properties:
>>      pattern: "^can-phy"
>>  
>>    compatible:
>> -    enum:
>> -      - nxp,tjr1443
>> -      - ti,tcan1042
>> -      - ti,tcan1043
>> +    oneOf:
>> +      - items:
>> +        - enum:
>> +          - microchip,ata6561
>> +        - const: ti,tcan1042
>> +      - enum:
>> +          const: ti,tcan1042
>> +          const: ti,tcan1043
>> +          const: nxp,tjr1443
> 
> The enum doesn't need the "const:s", just a "-", hence the bot
> complaining.

Plus indentation is broken, which is important for YAML. Before posting
the patch, please test it.

Please run `make dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
Maybe you need to update your dtschema and yamllint.

Best regards,
Krzysztof

[PATCH v3 1/1] dt-bindings: phy: ti,tcan104x-can: Document Microchip ATA6561

[Ilya Orazov]

Microchip ATA6561 is High-Speed CAN Transceiver with Standby Mode.
It is pin-compatible with TI TCAN1042 and has a compatible programming
model, therefore use ti,tcan1042 as fallback compatible.

Signed-off-by: Ilya Orazov <ilordash02@gmail.com>
---
 .../devicetree/bindings/phy/ti,tcan104x-can.yaml    | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
index 79dad3e89aa6..4a8c3829d85d 100644
--- a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
+++ b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
@@ -14,10 +14,15 @@ properties:
     pattern: "^can-phy"
 
   compatible:
-    enum:
-      - nxp,tjr1443
-      - ti,tcan1042
-      - ti,tcan1043
+    oneOf:
+      - items:
+          - enum:
+              - microchip,ata6561
+          - const: ti,tcan1042
+      - enum:
+          - ti,tcan1042
+          - ti,tcan1043
+          - nxp,tjr1443
 
   '#phy-cells':
     const: 0

base-commit: 6a0e38264012809afa24113ee2162dc07f4ed22b
-- 
2.34.1

Re: [PATCH v3 1/1] dt-bindings: phy: ti,tcan104x-can: Document Microchip ATA6561

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 593 bytes --]

On Thu, Aug 08, 2024 at 10:17:35PM +0300, Ilya Orazov wrote:
> Microchip ATA6561 is High-Speed CAN Transceiver with Standby Mode.
> It is pin-compatible with TI TCAN1042 and has a compatible programming
> model, therefore use ti,tcan1042 as fallback compatible.
> 
> Signed-off-by: Ilya Orazov <ilordash02@gmail.com>
> ---

Acked-by: Conor Dooley <conor.dooley@microchip.com>

btw, please don't send new versions as a reply to existing ones, it's a
shortcut to getting lost in deep mailboxes that sort by thread (or as I
almost did here, deletion of the mail without reading it).

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v3 1/1] dt-bindings: phy: ti,tcan104x-can: Document Microchip ATA6561

[Ilya Orazov]

On Thu, 8 Aug 2024 at 22:18, Ilya Orazov <ilordash02@gmail.com> wrote:
>
> Microchip ATA6561 is High-Speed CAN Transceiver with Standby Mode.
> It is pin-compatible with TI TCAN1042 and has a compatible programming
> model, therefore use ti,tcan1042 as fallback compatible.
>
> Signed-off-by: Ilya Orazov <ilordash02@gmail.com>
> ---
>  .../devicetree/bindings/phy/ti,tcan104x-can.yaml    | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> index 79dad3e89aa6..4a8c3829d85d 100644
> --- a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> +++ b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> @@ -14,10 +14,15 @@ properties:
>      pattern: "^can-phy"
>
>    compatible:
> -    enum:
> -      - nxp,tjr1443
> -      - ti,tcan1042
> -      - ti,tcan1043
> +    oneOf:
> +      - items:
> +          - enum:
> +              - microchip,ata6561
> +          - const: ti,tcan1042
> +      - enum:
> +          - ti,tcan1042
> +          - ti,tcan1043
> +          - nxp,tjr1443
>
>    '#phy-cells':
>      const: 0
>
> base-commit: 6a0e38264012809afa24113ee2162dc07f4ed22b
> --
> 2.34.1
>

Could you please review my patch?

I hope the new patch version hasn't been lost in your inbox. Thanks to
Conor, I understand now that sending new versions as a reply wasn't
the best approach. I appreciate your time and feedback.

-- 
Best regards,
Ilya Orazov

Re: [PATCH v3 1/1] dt-bindings: phy: ti,tcan104x-can: Document Microchip ATA6561

[Krzysztof Kozlowski]

On 13/08/2024 19:14, Ilya Orazov wrote:
>>    '#phy-cells':
>>      const: 0
>>
>> base-commit: 6a0e38264012809afa24113ee2162dc07f4ed22b
>> --
>> 2.34.1
>>
> 
> Could you please review my patch?

You received review. Why do you ping after few days?

Best regards,
Krzysztof

Re: [PATCH v3 1/1] dt-bindings: phy: ti,tcan104x-can: Document Microchip ATA6561

[Ilya Orazov]

On Wed, 14 Aug 2024 at 12:03, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 13/08/2024 19:14, Ilya Orazov wrote:
> >>    '#phy-cells':
> >>      const: 0
> >>
> >> base-commit: 6a0e38264012809afa24113ee2162dc07f4ed22b
> >> --
> >> 2.34.1
> >>
> >
> > Could you please review my patch?
>
> You received review. Why do you ping after few days?

I have uploaded new patch version and fixed all dt-binding errors, so
I thought you might want to review this updated version.

-- 
Best regards,
Ilya Orazov