From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BFA7188A20 for ; Thu, 22 Aug 2024 09:42:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724319773; cv=none; b=kzVVXdjQ9e0qN536zjDygIlecKkzGY02wqMVoiXgq+8Zw/CJnOc0eISMsu2ll0Arvatp0UfTQ74hDd6Bugq0UiZEuLkg2LoMH/E2VVzGV96gXow13LcNY3AJQ51suUI5lR0qZem8tdbhtO+YCddX6dY+q1mItZoOB76XLrmvGp4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724319773; c=relaxed/simple; bh=addi5O1iO8rPzp7Xba1I/SVDBMpDp0inLY71MiioA78=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=F2mrEOvZdY0qOZakXFqZqcNIhN3VPrP+LdWfWBbg3yM4gF/ckSKbyjLqQmrZzX3Y160xZu6y/onU90YLTAGllT6TrSVmtuDuLFiPUA8zo47Hj5yYIb3QJDBUvbwKBLtcKOt4KgfDtvoB+xanMdQ5YI6Bwg1UMw0d/sLLfwlAABY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=c5ZNT5Lk; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="c5ZNT5Lk" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2021aeee5e4so4243045ad.0 for ; Thu, 22 Aug 2024 02:42:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1724319771; x=1724924571; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=rT9nphr3FBy8w8TlOkDTcSqop/iUievOqu1C/QTIuD4=; b=c5ZNT5Lkf7Woof+RDwAmTdBCUkGwgHzZJ9vwFSQfvVVMcEj+aQF2Tvdh5Q+5d1zeM+ sa6RP9LuW9h300308GXQ4kTk3urVDoD1/R9BhINzL0A6V/SVCbL/6g5Qy4L9Rngtuu0t 0HKMCpj1dD2CUGxcdJ/Ri/KlRayIEnVp8E9gM2yocv90gCEVKNJ9VnPgPGSVauW+bOUn lOLzkatrVy4P5EUXxLUu6kEWcQGyA4j6QvDTvK/6lmVuxya86EgPaQvwOJnjIIjL7Es8 gpTnuKnfM/c5YBgVvJWCOTc+QoxyCKBx3zCDTVgKynK5CHnTQAYP62EZ2obzI/IwWLtS Oe5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724319771; x=1724924571; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rT9nphr3FBy8w8TlOkDTcSqop/iUievOqu1C/QTIuD4=; b=pf8lbGpzbs3ut2BbeDvfKv2odqwIQd6rmQW8OL22fHBgGTRzpbQzKB0WBueeQUOyhN AiwVhgrmVreJWBud1ceZIwonhY+bSAw9V0GS0SUduTgWfdP/BuJTxm0NoxxuxtPTT8+8 jdTrm4/NnCu1wDzsWN7b4tgEVaafTKByiRrM7svX46M/SgGyqNBlIC4dEHf/92tPKoDv i0T2/AYvz9PYFsp5mRHzwh8dTI8AtpmgEMRH0WYXYc6rmMxnRy2UmmUD+H6Tal2C4ULW 6JSLuFeK73guGjLIQMoswpsoihAjgsXxFrtlQu0OKHiXlk+mH5Ymw1XnaJbuP0SUD/3m j+tw== X-Forwarded-Encrypted: i=1; AJvYcCXqBht0756zETZ4SKQ1haBOjkFagLJSD2kigqSPfw5Xu+aaCyMek8qVuRMD7nplkdImgi7Vsln79j6E@vger.kernel.org X-Gm-Message-State: AOJu0YzXyJ48VLe7CJ1Bwb+5LIXs0kE9mSBzXn9417WwwJf4C5S2xZlT 6CojzWC97u7hlM5M2F0sNqQ8X+oyQa9LeHWLnZF6LNXPqTEH99qrmZRhFhcj7w== X-Google-Smtp-Source: AGHT+IHfsANLzJW+TqoOiWeWY8HxcLe//pwPC8OGFSSjXI3DlfJLCyXQY4eLQyLzlBfwBgYxNwVtwA== X-Received: by 2002:a17:903:22cc:b0:1fb:1afb:b864 with SMTP id d9443c01a7336-203881f3792mr15614615ad.5.1724319770860; Thu, 22 Aug 2024 02:42:50 -0700 (PDT) Received: from thinkpad ([117.213.99.42]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2038b7ebe0dsm6850535ad.287.2024.08.22.02.42.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Aug 2024 02:42:50 -0700 (PDT) Date: Thu, 22 Aug 2024 15:12:43 +0530 From: Manivannan Sadhasivam To: Johan Hovold Cc: Bjorn Helgaas , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Abel Vesa , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dt-bindings: PCI: qcom: Allow 'vddpe-3v3-supply' again Message-ID: <20240822094243.b7crebodnbb542te@thinkpad> References: <20240723151328.684-1-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240723151328.684-1-johan+linaro@kernel.org> On Tue, Jul 23, 2024 at 05:13:28PM +0200, Johan Hovold wrote: > Commit 756485bfbb85 ("dt-bindings: PCI: qcom,pcie-sc7280: Move SC7280 to > dedicated schema") incorrectly removed 'vddpe-3v3-supply' from the > bindings, which results in DT checker warnings like: > > arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dtb: pcie@600000: Unevaluated properties are not allowed ('vddpe-3v3-supply' was unexpected) > from schema $id: http://devicetree.org/schemas/pci/qcom,pcie.yaml# > > Note that this property has been part of the Qualcomm PCIe bindings > since 2018 and would need to be deprecated rather than simply removed if > there is a desire to replace it with 'vpcie3v3' which is used for some > non-Qualcomm controllers. > > Fixes: 756485bfbb85 ("dt-bindings: PCI: qcom,pcie-sc7280: Move SC7280 to dedicated schema") > Signed-off-by: Johan Hovold Reviewed-by: Manivannan Sadhasivam - Mani > --- > Documentation/devicetree/bindings/pci/qcom,pcie-common.yaml | 3 +++ > Documentation/devicetree/bindings/pci/qcom,pcie-sc7280.yaml | 3 --- > Documentation/devicetree/bindings/pci/qcom,pcie-sc8280xp.yaml | 3 --- > Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 3 +++ > 4 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-common.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-common.yaml > index 0a39bbfcb28b..2b6f5a171f20 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie-common.yaml > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-common.yaml > @@ -78,6 +78,9 @@ properties: > description: GPIO controlled connection to WAKE# signal > maxItems: 1 > > + vddpe-3v3-supply: > + description: PCIe endpoint power supply > + > required: > - reg > - reg-names > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-sc7280.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-sc7280.yaml > index 634da24ec3ed..7ed46a929d73 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie-sc7280.yaml > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-sc7280.yaml > @@ -66,9 +66,6 @@ properties: > items: > - const: pci > > - vddpe-3v3-supply: > - description: PCIe endpoint power supply > - > allOf: > - $ref: qcom,pcie-common.yaml# > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-sc8280xp.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-sc8280xp.yaml > index 25c9f13ae977..15ba2385eb73 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie-sc8280xp.yaml > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-sc8280xp.yaml > @@ -58,9 +58,6 @@ properties: > items: > - const: pci > > - vddpe-3v3-supply: > - description: A phandle to the PCIe endpoint power supply > - > required: > - interconnects > - interconnect-names > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > index f867746b1ae5..ffabbac57fc1 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > @@ -91,6 +91,9 @@ properties: > vdda_refclk-supply: > description: A phandle to the core analog power supply for IC which generates reference clock > > + vddpe-3v3-supply: > + description: A phandle to the PCIe endpoint power supply > + > phys: > maxItems: 1 > > -- > 2.44.2 > -- மணிவண்ணன் சதாசிவம்