From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 498497346D for ; Fri, 23 Aug 2024 08:30:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724401816; cv=none; b=fh8kepNPEMvRtkcHlJViXzg+Ae/AOGIUP2x7/3J5J7fnQFHRUuwIdX0uchofkWDALOMpOMH8OKeBW4yx8wlf/WDippzfFckjqjCYsb1wpfZj5f4DgKp49V8kK4YCrsxxRiUDUQswM+Lf4imPBEs/cCHwb2IAnqWdTxuPEOZ+ctY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724401816; c=relaxed/simple; bh=bqqGn/FT9f2u5+YF1xX/+JxI1FyqgycSOXAqnxCCfzE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qhFWYPl8/UybT+6K5/toXUuIuLWOUdSl6RRjYXHBNe0DN7YCFifLgXq+qetXO1X6mkd+MbDmDICAHmmOKUeWmYSEY0r9YWcAbThnHBfw1yG4CqOCgiES8aDAtaYIv2x/uKk4TRJ8kXKZIKD9UIUEjSF5lnepjMgMm2ao9FSnZeA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Tih7epZ4; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Tih7epZ4" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-7141285db14so1568241b3a.1 for ; Fri, 23 Aug 2024 01:30:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1724401814; x=1725006614; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=1g5yFnddqJtpT5ZB7dI72xoCG8cY+pVqMM33pT3uyxE=; b=Tih7epZ44tqAEYygHvbeielnnWKp6BqwLVbZmz5IDCdPbg5MnVSVqyt9DIPIM3sKXF cxOwbpVMR94Wi+iB0STTrIt5IOZk0vtveuEP/eL5JizkCSBWwzknuZCJdDZO5xecNAB1 mZuTBSwbx1hleQRxOglnKWMtSv0SeIX3DY1rVXzJN49sxd0pyUCYJtEwpvt2ZHjbA+M3 s0L7UWehzujQAhYIcjvcN8PgZM1H1dQISJyXpLUYL/kHZ4pUc418vqvdsOAw9SZUwDDn m8WExYfnm5ZHweN2B4tAjh6A9wMkIgEmspIz2aJVrn6iTe/1SnblR7orP3QnAdBzhs3j k4Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724401814; x=1725006614; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1g5yFnddqJtpT5ZB7dI72xoCG8cY+pVqMM33pT3uyxE=; b=w6QndPE1r4b0E9WzuJ46ir0d1sdGzM57iHq25QNVxuBDoP7zkTlkczsk1BxpmqUWJf dU3yNl7odq7Kva8PQ3egqMGWNCbtBWCmUx0B/qCLwsi/nooFtKcBDw7aVurQ/cwUDI2L OufRvH34Iz6lDLrBOfGaYp+a+cDIucog82UflfY+Kc+rARsm48AJ1QkfMUbebmlxtyEQ pKJzFZDkHhbKXEnR817mwMiPzJq0tSxD0WC3kCJbiqMNIEPcIAFCFIGMqfGzkZFF7kDB X+5LSzTvVbnzCEloYiKFOinb62LxuRr3FK/i8nP2VdmcoeDckzuxxSZRt8JOAV+gs/RA Mbow== X-Forwarded-Encrypted: i=1; AJvYcCU2TAUfXaqPbuX9FkHZhPiP7gg7WYnjKIevDsL7W1cKJ6G0lo4M3uZ/S3U7WwD79/s6xDMcvvUNcyaH@vger.kernel.org X-Gm-Message-State: AOJu0YzCCr+uqL2KLLMdkXill13hygUMlBYi5m8IHsTSavCzEz1w0r6A 9lyhIQfEPq2IDU6Dif/5B5JF8A8XIdQACp1a19UT3iHezKEEqf+IMfLYTCAtrQ== X-Google-Smtp-Source: AGHT+IFQHY7q9Pde3Vur1+ysnnW4dBHdUMSQBiVLGfF9YoHEBmVFtYzNOhvQUkAYxKs9nYASM4Cjdw== X-Received: by 2002:a05:6a20:d523:b0:1c4:7dbc:d21a with SMTP id adf61e73a8af0-1cc8b520264mr1524117637.32.1724401814409; Fri, 23 Aug 2024 01:30:14 -0700 (PDT) Received: from thinkpad ([120.60.60.148]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2d5eba2353csm5668143a91.26.2024.08.23.01.30.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Aug 2024 01:30:13 -0700 (PDT) Date: Fri, 23 Aug 2024 14:00:04 +0530 From: Manivannan Sadhasivam To: Bjorn Helgaas Cc: Bartosz Golaszewski , Krishna chaitanya chundru , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , cros-qcom-dts-watchers@chromium.org, Jingoo Han , andersson@kernel.org, quic_vbadigan@quicinc.com, linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH v2 4/8] PCI: Change the parent to correctly represent pcie hierarchy Message-ID: <20240823083004.rzylgm66yaw3rlyi@thinkpad> References: <20240822211336.GA349622@bhelgaas> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240822211336.GA349622@bhelgaas> On Thu, Aug 22, 2024 at 04:13:36PM -0500, Bjorn Helgaas wrote: > On Thu, Aug 22, 2024 at 10:01:04PM +0200, Bartosz Golaszewski wrote: > > On Thu, Aug 22, 2024 at 9:28 PM Bjorn Helgaas wrote: > > > > > > On Tue, Aug 13, 2024 at 09:15:06PM +0200, Bartosz Golaszewski wrote: > > > > On Sat, Aug 3, 2024 at 5:23 AM Krishna chaitanya chundru > > > > wrote: > > > > > > > > > > Currently the pwrctl driver is child of pci-pci bridge driver, > > > > > this will cause issue when suspend resume is introduced in the pwr > > > > > control driver. If the supply is removed to the endpoint in the > > > > > power control driver then the config space access by the > > > > > pci-pci bridge driver can cause issues like Timeouts. > > > > > > > > > > For this reason change the parent to controller from pci-pci bridge. > > > > > > > > > > Fixes: 4565d2652a37 ("PCI/pwrctl: Add PCI power control core code") > > > > > Signed-off-by: Krishna chaitanya chundru > > > > > --- > > > > > > > > Tested-by: Bartosz Golaszewski > > > > > > > > Bjorn, > > > > > > > > I think this should go into v6.11 as it does indeed better represent > > > > the underlying logic. > > > > > > Is this patch independent of the rest? I don't think the whole series > > > looks like v6.11 material, but if this patch can be applied > > > independently, *and* we can make a case in the commit log for why it > > > is v6.11 material, we can do that. > > > > > > Right now the commit log doesn't tell me enough to justify a > > > post-merge window change. > > > > Please, apply this patch independently. FYI I have a WiP branch[1] > > with a v3 of the fixes series rebased on top of this one. Manivannan > > and I are working on fixing one last remaining issue and I'll resend > > it. This should go into v6.11. > > OK. I just need to be able to justify *why* we need it in v6.11, so I > can apply it as soon as somebody supplies that kind of text for the > commit log. I.e., what is broken without this change? What bad > things happen if we defer it to v6.12? > I'm not sure if this is a 6.11 material as this patch is not fixing any crash or potential breakage in 6.11. This patch changes the hierarchy in such a way that the suspend/resume could work fine once added in the pwrctl drivers. At the same time, I'd like to get it merged separately for 6.12 instead of bundling it in this same series. - Mani -- மணிவண்ணன் சதாசிவம்